* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
@ 2013-12-16 15:53 Kishon Vijay Abraham I
2013-12-16 15:53 ` [PATCH v3 1/2] usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c Kishon Vijay Abraham I
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2013-12-16 15:53 UTC (permalink / raw)
To: linux-arm-kernel
After the platform devices are created using PLATFORM_DEVID_AUTO, the
device names given in usb_bind_phy (in board file) does not match with
the actual device name causing the USB PHY library not to return the
PHY reference when the MUSB controller request for the PHY in the non-dt boot
case.
So removed creating platform devices using PLATFORM_DEVID_AUTO in omap2430.c.
Did enumeration testing in omap3 beagle.
Changes from v2:
* Fixed the commit log
Changes from v1:
* refreshed to the latested mainline kernel
* added musb_put_id from omap2430 remove.
Kishon Vijay Abraham I (2):
usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
arm: omap: remove *.auto* from device names given in usb_bind_phy
arch/arm/mach-omap2/board-2430sdp.c | 2 +-
arch/arm/mach-omap2/board-3430sdp.c | 2 +-
arch/arm/mach-omap2/board-cm-t35.c | 2 +-
arch/arm/mach-omap2/board-devkit8000.c | 2 +-
arch/arm/mach-omap2/board-ldp.c | 2 +-
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
arch/arm/mach-omap2/board-omap3logic.c | 2 +-
arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
arch/arm/mach-omap2/board-overo.c | 2 +-
arch/arm/mach-omap2/board-rx51.c | 2 +-
drivers/usb/musb/musb_core.c | 31 +++++++++++++++++++++++++++-
drivers/usb/musb/musb_core.h | 2 ++
drivers/usb/musb/omap2430.c | 19 +++++++++++++++--
15 files changed, 61 insertions(+), 15 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 1/2] usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
2013-12-16 15:53 [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform Kishon Vijay Abraham I
@ 2013-12-16 15:53 ` Kishon Vijay Abraham I
2013-12-16 15:53 ` [PATCH v3 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy Kishon Vijay Abraham I
2013-12-16 21:29 ` [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform Felipe Balbi
2 siblings, 0 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2013-12-16 15:53 UTC (permalink / raw)
To: linux-arm-kernel
commit 2f7711 (usb: musb: remove hand-crafted id handling) used
PLATFORM_DEVID_AUTO while creating MUSB core device.
After the platform devices are created using PLATFORM_DEVID_AUTO, the
device names given in usb_bind_phy (in board file) does not match with
the actual device name causing the USB PHY library not to return the
PHY reference when the MUSB controller request for the PHY in the non-dt boot
case.
So removed creating platform devices using PLATFORM_DEVID_AUTO in omap2430.c.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/usb/musb/musb_core.c | 31 ++++++++++++++++++++++++++++++-
drivers/usb/musb/musb_core.h | 2 ++
drivers/usb/musb/omap2430.c | 19 +++++++++++++++++--
3 files changed, 49 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 0a43329..aaf734c 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -94,6 +94,7 @@
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/init.h>
+#include <linux/idr.h>
#include <linux/list.h>
#include <linux/kobject.h>
#include <linux/prefetch.h>
@@ -120,7 +121,7 @@ MODULE_DESCRIPTION(DRIVER_INFO);
MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_LICENSE("GPL");
MODULE_ALIAS("platform:" MUSB_DRIVER_NAME);
-
+static DEFINE_IDA(musb_ida);
/*-------------------------------------------------------------------------*/
@@ -131,6 +132,34 @@ static inline struct musb *dev_to_musb(struct device *dev)
/*-------------------------------------------------------------------------*/
+int musb_get_id(struct device *dev, gfp_t gfp_mask)
+{
+ int ret;
+ int id;
+
+ ret = ida_pre_get(&musb_ida, gfp_mask);
+ if (!ret) {
+ dev_err(dev, "failed to reserve resource for id\n");
+ return -ENOMEM;
+ }
+
+ ret = ida_get_new(&musb_ida, &id);
+ if (ret < 0) {
+ dev_err(dev, "failed to allocate a new id\n");
+ return ret;
+ }
+
+ return id;
+}
+EXPORT_SYMBOL_GPL(musb_get_id);
+
+void musb_put_id(struct device *dev, int id)
+{
+ dev_dbg(dev, "removing id %d\n", id);
+ ida_remove(&musb_ida, id);
+}
+EXPORT_SYMBOL_GPL(musb_put_id);
+
#ifndef CONFIG_BLACKFIN
static int musb_ulpi_read(struct usb_phy *phy, u32 offset)
{
diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h
index 29f7cd7..63614283 100644
--- a/drivers/usb/musb/musb_core.h
+++ b/drivers/usb/musb/musb_core.h
@@ -506,6 +506,8 @@ extern const char musb_driver_name[];
extern void musb_stop(struct musb *musb);
extern void musb_start(struct musb *musb);
+int musb_get_id(struct device *dev, gfp_t gfp_mask);
+void musb_put_id(struct device *dev, int id);
extern void musb_write_fifo(struct musb_hw_ep *ep, u16 len, const u8 *src);
extern void musb_read_fifo(struct musb_hw_ep *ep, u16 len, u8 *dst);
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 2a408cd..14a612c 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -45,6 +45,7 @@
struct omap2430_glue {
struct device *dev;
+ int id;
struct platform_device *musb;
enum omap_musb_vbus_id_status status;
struct work_struct omap_musb_mailbox_work;
@@ -508,6 +509,7 @@ static int omap2430_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node;
struct musb_hdrc_config *config;
int ret = -ENOMEM;
+ int musbid;
glue = devm_kzalloc(&pdev->dev, sizeof(*glue), GFP_KERNEL);
if (!glue) {
@@ -515,10 +517,18 @@ static int omap2430_probe(struct platform_device *pdev)
goto err0;
}
- musb = platform_device_alloc("musb-hdrc", PLATFORM_DEVID_AUTO);
+ /* get the musb id */
+ musbid = musb_get_id(&pdev->dev, GFP_KERNEL);
+ if (musbid < 0) {
+ dev_err(&pdev->dev, "failed to allocate musb id\n");
+ ret = -ENOMEM;
+ goto err0;
+ }
+
+ musb = platform_device_alloc("musb-hdrc", musbid);
if (!musb) {
dev_err(&pdev->dev, "failed to allocate musb device\n");
- goto err0;
+ goto err1;
}
musb->dev.parent = &pdev->dev;
@@ -528,6 +538,7 @@ static int omap2430_probe(struct platform_device *pdev)
glue->dev = &pdev->dev;
glue->musb = musb;
glue->status = OMAP_MUSB_UNKNOWN;
+ glue->id = musbid;
glue->control_otghs = ERR_PTR(-ENODEV);
if (np) {
@@ -633,6 +644,9 @@ static int omap2430_probe(struct platform_device *pdev)
err2:
platform_device_put(musb);
+err1:
+ musb_put_id(&pdev->dev, musbid);
+
err0:
return ret;
}
@@ -643,6 +657,7 @@ static int omap2430_remove(struct platform_device *pdev)
cancel_work_sync(&glue->omap_musb_mailbox_work);
platform_device_unregister(glue->musb);
+ musb_put_id(&pdev->dev, glue->id);
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy
2013-12-16 15:53 [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform Kishon Vijay Abraham I
2013-12-16 15:53 ` [PATCH v3 1/2] usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c Kishon Vijay Abraham I
@ 2013-12-16 15:53 ` Kishon Vijay Abraham I
2013-12-16 21:29 ` [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform Felipe Balbi
2 siblings, 0 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2013-12-16 15:53 UTC (permalink / raw)
To: linux-arm-kernel
commit 2f7711 (usb: musb: remove hand-crafted id handling) used
PLATFORM_DEVID_AUTO while creating MUSB core device. So commit 51482b
(ARM: OMAP: USB: Add phy binding information) added usb_bind_phy
(binds the controller with the PHY) in the board files, with *.auto* in
the device name of the controller. Since other devices started using
PLATFORM_DEVID_AUTO, the index in the device name given in usb_bind_phy
changed making the data given in usb_bind_phy obsolete and usb_get_phy
started failing. So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO.
Corresponding change is done in board file here.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
arch/arm/mach-omap2/board-2430sdp.c | 2 +-
arch/arm/mach-omap2/board-3430sdp.c | 2 +-
arch/arm/mach-omap2/board-cm-t35.c | 2 +-
arch/arm/mach-omap2/board-devkit8000.c | 2 +-
arch/arm/mach-omap2/board-ldp.c | 2 +-
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
arch/arm/mach-omap2/board-omap3logic.c | 2 +-
arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
arch/arm/mach-omap2/board-overo.c | 2 +-
arch/arm/mach-omap2/board-rx51.c | 2 +-
12 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
index c711ad6..cc679c6 100644
--- a/arch/arm/mach-omap2/board-2430sdp.c
+++ b/arch/arm/mach-omap2/board-2430sdp.c
@@ -246,7 +246,7 @@ static void __init omap_2430sdp_init(void)
omap_hsmmc_init(mmc);
omap_mux_init_signal("usb0hs_stp", OMAP_PULL_ENA | OMAP_PULL_UP);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
board_smc91x_init();
diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
index d95d0ef..873e463 100644
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -607,7 +607,7 @@ static void __init omap_3430sdp_init(void)
omap_ads7846_init(1, gpio_pendown, 310, NULL);
omap_serial_init();
omap_sdrc_init(hyb18m512160af6_sdrc_params, NULL);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
board_smc91x_init();
board_flash_init(sdp_flash_partitions, chip_sel_3430, 0);
diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
index 8dd0ec8..ddcadfa 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -725,7 +725,7 @@ static void __init cm_t3x_common_init(void)
cm_t35_init_display();
omap_twl4030_audio_init("cm-t3x", NULL);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
cm_t35_init_usbh();
cm_t35_init_camera();
diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c
index cdc4fb9..bb589f1 100644
--- a/arch/arm/mach-omap2/board-devkit8000.c
+++ b/arch/arm/mach-omap2/board-devkit8000.c
@@ -628,7 +628,7 @@ static void __init devkit8000_init(void)
omap_ads7846_init(2, OMAP3_DEVKIT_TS_GPIO, 0, NULL);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
usbhs_init(&usbhs_bdata);
board_nand_init(devkit8000_nand_partitions,
diff --git a/arch/arm/mach-omap2/board-ldp.c b/arch/arm/mach-omap2/board-ldp.c
index 4ec8d82..ec9b349 100644
--- a/arch/arm/mach-omap2/board-ldp.c
+++ b/arch/arm/mach-omap2/board-ldp.c
@@ -402,7 +402,7 @@ static void __init omap_ldp_init(void)
omap_ads7846_init(1, 54, 310, NULL);
omap_serial_init();
omap_sdrc_init(NULL, NULL);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
board_nand_init(ldp_nand_partitions, ARRAY_SIZE(ldp_nand_partitions),
0, 0, nand_default_timings);
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index d6ed819..0cba5eb 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -561,7 +561,7 @@ static void __init omap3_beagle_init(void)
omap_sdrc_init(mt46h32m32lf6_sdrc_params,
mt46h32m32lf6_sdrc_params);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
usbhs_init(&usbhs_bdata);
diff --git a/arch/arm/mach-omap2/board-omap3logic.c b/arch/arm/mach-omap2/board-omap3logic.c
index bab51e6..d9a6c38 100644
--- a/arch/arm/mach-omap2/board-omap3logic.c
+++ b/arch/arm/mach-omap2/board-omap3logic.c
@@ -216,7 +216,7 @@ static void __init omap3logic_init(void)
board_mmc_init();
board_smsc911x_init();
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
/* Ensure SDRC pins are mux'd for self-refresh */
diff --git a/arch/arm/mach-omap2/board-omap3pandora.c b/arch/arm/mach-omap2/board-omap3pandora.c
index de1bc6b..3826af6 100644
--- a/arch/arm/mach-omap2/board-omap3pandora.c
+++ b/arch/arm/mach-omap2/board-omap3pandora.c
@@ -607,7 +607,7 @@ static void __init omap3pandora_init(void)
usbhs_init_phys(phy_data, ARRAY_SIZE(phy_data));
usbhs_init(&usbhs_bdata);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
gpmc_nand_init(&pandora_nand_data, NULL);
diff --git a/arch/arm/mach-omap2/board-omap3stalker.c b/arch/arm/mach-omap2/board-omap3stalker.c
index 119efaf..9421987 100644
--- a/arch/arm/mach-omap2/board-omap3stalker.c
+++ b/arch/arm/mach-omap2/board-omap3stalker.c
@@ -407,7 +407,7 @@ static void __init omap3_stalker_init(void)
omap_serial_init();
omap_sdrc_init(mt46h32m32lf6_sdrc_params, NULL);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
usbhs_init_phys(phy_data, ARRAY_SIZE(phy_data));
diff --git a/arch/arm/mach-omap2/board-omap3touchbook.c b/arch/arm/mach-omap2/board-omap3touchbook.c
index 7da48bc..e8e053d 100644
--- a/arch/arm/mach-omap2/board-omap3touchbook.c
+++ b/arch/arm/mach-omap2/board-omap3touchbook.c
@@ -367,7 +367,7 @@ static void __init omap3_touchbook_init(void)
/* Touchscreen and accelerometer */
omap_ads7846_init(4, OMAP3_TS_GPIO, 310, &ads7846_pdata);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
usbhs_init_phys(phy_data, ARRAY_SIZE(phy_data));
diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index f6d3841..c69e049 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -511,7 +511,7 @@ static void __init overo_init(void)
mt46h32m32lf6_sdrc_params);
board_nand_init(overo_nand_partitions,
ARRAY_SIZE(overo_nand_partitions), NAND_CS, 0, NULL);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(NULL);
usbhs_init_phys(phy_data, ARRAY_SIZE(phy_data));
diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
index db168c9..31d218f 100644
--- a/arch/arm/mach-omap2/board-rx51.c
+++ b/arch/arm/mach-omap2/board-rx51.c
@@ -103,7 +103,7 @@ static void __init rx51_init(void)
sdrc_params = nokia_get_sdram_timings();
omap_sdrc_init(sdrc_params, sdrc_params);
- usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
+ usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb");
usb_musb_init(&musb_board_data);
rx51_peripherals_init();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2013-12-16 15:53 [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform Kishon Vijay Abraham I
2013-12-16 15:53 ` [PATCH v3 1/2] usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c Kishon Vijay Abraham I
2013-12-16 15:53 ` [PATCH v3 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy Kishon Vijay Abraham I
@ 2013-12-16 21:29 ` Felipe Balbi
2013-12-16 22:38 ` Tony Lindgren
2 siblings, 1 reply; 12+ messages in thread
From: Felipe Balbi @ 2013-12-16 21:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote:
> After the platform devices are created using PLATFORM_DEVID_AUTO, the
> device names given in usb_bind_phy (in board file) does not match with
> the actual device name causing the USB PHY library not to return the
> PHY reference when the MUSB controller request for the PHY in the non-dt boot
> case.
> So removed creating platform devices using PLATFORM_DEVID_AUTO in omap2430.c.
>
> Did enumeration testing in omap3 beagle.
>
> Changes from v2:
> * Fixed the commit log
>
> Changes from v1:
> * refreshed to the latested mainline kernel
> * added musb_put_id from omap2430 remove.
Tony, how do you want to handle this ? You want me to provide you a
branch which we both merge ?
cheers
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131216/13634c31/attachment-0001.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2013-12-16 21:29 ` [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform Felipe Balbi
@ 2013-12-16 22:38 ` Tony Lindgren
2013-12-16 23:48 ` Felipe Balbi
0 siblings, 1 reply; 12+ messages in thread
From: Tony Lindgren @ 2013-12-16 22:38 UTC (permalink / raw)
To: linux-arm-kernel
* Felipe Balbi <balbi@ti.com> [131216 13:31]:
> Hi,
>
> On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote:
> > After the platform devices are created using PLATFORM_DEVID_AUTO, the
> > device names given in usb_bind_phy (in board file) does not match with
> > the actual device name causing the USB PHY library not to return the
> > PHY reference when the MUSB controller request for the PHY in the non-dt boot
> > case.
> > So removed creating platform devices using PLATFORM_DEVID_AUTO in omap2430.c.
> >
> > Did enumeration testing in omap3 beagle.
> >
> > Changes from v2:
> > * Fixed the commit log
> >
> > Changes from v1:
> > * refreshed to the latested mainline kernel
> > * added musb_put_id from omap2430 remove.
>
> Tony, how do you want to handle this ? You want me to provide you a
> branch which we both merge ?
Yes that would be great thanks. For the mach-omap2 touching parts:
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2013-12-16 22:38 ` Tony Lindgren
@ 2013-12-16 23:48 ` Felipe Balbi
2014-07-21 15:04 ` Laurent Pinchart
0 siblings, 1 reply; 12+ messages in thread
From: Felipe Balbi @ 2013-12-16 23:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [131216 13:31]:
> > Hi,
> >
> > On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote:
> > > After the platform devices are created using PLATFORM_DEVID_AUTO, the
> > > device names given in usb_bind_phy (in board file) does not match with
> > > the actual device name causing the USB PHY library not to return the
> > > PHY reference when the MUSB controller request for the PHY in the non-dt boot
> > > case.
> > > So removed creating platform devices using PLATFORM_DEVID_AUTO in omap2430.c.
> > >
> > > Did enumeration testing in omap3 beagle.
> > >
> > > Changes from v2:
> > > * Fixed the commit log
> > >
> > > Changes from v1:
> > > * refreshed to the latested mainline kernel
> > > * added musb_put_id from omap2430 remove.
> >
> > Tony, how do you want to handle this ? You want me to provide you a
> > branch which we both merge ?
>
> Yes that would be great thanks. For the mach-omap2 touching parts:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Here it is, let me know if you prefer a signed tag:
The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git usb-phy-binding-omap3
for you to fetch changes up to 23ada3130cf4e56acb86fdff4c26113188d52d18:
arm: omap: remove *.auto* from device names given in usb_bind_phy (2013-12-16 17:44:43 -0600)
----------------------------------------------------------------
Kishon Vijay Abraham I (2):
usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
arm: omap: remove *.auto* from device names given in usb_bind_phy
arch/arm/mach-omap2/board-2430sdp.c | 2 +-
arch/arm/mach-omap2/board-3430sdp.c | 2 +-
arch/arm/mach-omap2/board-cm-t35.c | 2 +-
arch/arm/mach-omap2/board-devkit8000.c | 2 +-
arch/arm/mach-omap2/board-ldp.c | 2 +-
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
arch/arm/mach-omap2/board-omap3logic.c | 2 +-
arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
arch/arm/mach-omap2/board-overo.c | 2 +-
arch/arm/mach-omap2/board-rx51.c | 2 +-
drivers/usb/musb/musb_core.c | 31 +++++++++++++++++++++++++++++-
drivers/usb/musb/musb_core.h | 2 ++
drivers/usb/musb/omap2430.c | 19 ++++++++++++++++--
15 files changed, 61 insertions(+), 15 deletions(-)
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131216/a979ebc0/attachment-0001.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2013-12-16 23:48 ` Felipe Balbi
@ 2014-07-21 15:04 ` Laurent Pinchart
2014-07-21 15:15 ` Felipe Balbi
0 siblings, 1 reply; 12+ messages in thread
From: Laurent Pinchart @ 2014-07-21 15:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi Felipe,
What happened to these two patches ?
On Monday 16 December 2013 17:48:29 Felipe Balbi wrote:
> On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote:
> > * Felipe Balbi <balbi@ti.com> [131216 13:31]:
> > > On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote:
> > > > After the platform devices are created using PLATFORM_DEVID_AUTO, the
> > > > device names given in usb_bind_phy (in board file) does not match with
> > > > the actual device name causing the USB PHY library not to return the
> > > > PHY reference when the MUSB controller request for the PHY in the
> > > > non-dt boot case.
> > > > So removed creating platform devices using PLATFORM_DEVID_AUTO in
> > > > omap2430.c.
> > > >
> > > > Did enumeration testing in omap3 beagle.
> > > >
> > > > Changes from v2:
> > > > * Fixed the commit log
> > > >
> > > > Changes from v1:
> > > > * refreshed to the latested mainline kernel
> > > > * added musb_put_id from omap2430 remove.
> > >
> > > Tony, how do you want to handle this ? You want me to provide you a
> > > branch which we both merge ?
> >
> > Yes that would be great thanks. For the mach-omap2 touching parts:
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
>
> Here it is, let me know if you prefer a signed tag:
>
> The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
>
> Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> usb-phy-binding-omap3
>
> for you to fetch changes up to 23ada3130cf4e56acb86fdff4c26113188d52d18:
>
> arm: omap: remove *.auto* from device names given in usb_bind_phy
> (2013-12-16 17:44:43 -0600)
>
> ----------------------------------------------------------------
> Kishon Vijay Abraham I (2):
> usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
> arm: omap: remove *.auto* from device names given in usb_bind_phy
>
> arch/arm/mach-omap2/board-2430sdp.c | 2 +-
> arch/arm/mach-omap2/board-3430sdp.c | 2 +-
> arch/arm/mach-omap2/board-cm-t35.c | 2 +-
> arch/arm/mach-omap2/board-devkit8000.c | 2 +-
> arch/arm/mach-omap2/board-ldp.c | 2 +-
> arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
> arch/arm/mach-omap2/board-omap3logic.c | 2 +-
> arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
> arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
> arch/arm/mach-omap2/board-overo.c | 2 +-
> arch/arm/mach-omap2/board-rx51.c | 2 +-
> drivers/usb/musb/musb_core.c | 31 ++++++++++++++++++++++++++-
> drivers/usb/musb/musb_core.h | 2 ++
> drivers/usb/musb/omap2430.c | 19 ++++++++++++++++--
> 15 files changed, 61 insertions(+), 15 deletions(-)
--
Regards,
Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140721/209b6fa3/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2014-07-21 15:04 ` Laurent Pinchart
@ 2014-07-21 15:15 ` Felipe Balbi
2014-07-23 8:59 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 12+ messages in thread
From: Felipe Balbi @ 2014-07-21 15:15 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Jul 21, 2014 at 05:04:57PM +0200, Laurent Pinchart wrote:
> Hi Felipe,
>
> What happened to these two patches ?
looks like I lost them.
> On Monday 16 December 2013 17:48:29 Felipe Balbi wrote:
> > On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote:
> > > * Felipe Balbi <balbi@ti.com> [131216 13:31]:
> > > > On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote:
> > > > > After the platform devices are created using PLATFORM_DEVID_AUTO, the
> > > > > device names given in usb_bind_phy (in board file) does not match with
> > > > > the actual device name causing the USB PHY library not to return the
> > > > > PHY reference when the MUSB controller request for the PHY in the
> > > > > non-dt boot case.
> > > > > So removed creating platform devices using PLATFORM_DEVID_AUTO in
> > > > > omap2430.c.
> > > > >
> > > > > Did enumeration testing in omap3 beagle.
> > > > >
> > > > > Changes from v2:
> > > > > * Fixed the commit log
> > > > >
> > > > > Changes from v1:
> > > > > * refreshed to the latested mainline kernel
> > > > > * added musb_put_id from omap2430 remove.
> > > >
> > > > Tony, how do you want to handle this ? You want me to provide you a
> > > > branch which we both merge ?
> > >
> > > Yes that would be great thanks. For the mach-omap2 touching parts:
> > >
> > > Acked-by: Tony Lindgren <tony@atomide.com>
> >
> > Here it is, let me know if you prefer a signed tag:
> >
> > The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
> >
> > Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> > usb-phy-binding-omap3
> >
> > for you to fetch changes up to 23ada3130cf4e56acb86fdff4c26113188d52d18:
> >
> > arm: omap: remove *.auto* from device names given in usb_bind_phy
> > (2013-12-16 17:44:43 -0600)
> >
> > ----------------------------------------------------------------
> > Kishon Vijay Abraham I (2):
> > usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
> > arm: omap: remove *.auto* from device names given in usb_bind_phy
Kishon, are these still valid ?
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140721/a2857581/attachment-0001.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2014-07-21 15:15 ` Felipe Balbi
@ 2014-07-23 8:59 ` Kishon Vijay Abraham I
2014-07-29 12:38 ` Laurent Pinchart
0 siblings, 1 reply; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2014-07-23 8:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Felipe,
On Monday 21 July 2014 08:45 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Jul 21, 2014 at 05:04:57PM +0200, Laurent Pinchart wrote:
>> Hi Felipe,
>>
>> What happened to these two patches ?
>
> looks like I lost them.
>
>> On Monday 16 December 2013 17:48:29 Felipe Balbi wrote:
>>> On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote:
>>>> * Felipe Balbi <balbi@ti.com> [131216 13:31]:
>>>>> On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote:
>>>>>> After the platform devices are created using PLATFORM_DEVID_AUTO, the
>>>>>> device names given in usb_bind_phy (in board file) does not match with
>>>>>> the actual device name causing the USB PHY library not to return the
>>>>>> PHY reference when the MUSB controller request for the PHY in the
>>>>>> non-dt boot case.
>>>>>> So removed creating platform devices using PLATFORM_DEVID_AUTO in
>>>>>> omap2430.c.
>>>>>>
>>>>>> Did enumeration testing in omap3 beagle.
>>>>>>
>>>>>> Changes from v2:
>>>>>> * Fixed the commit log
>>>>>>
>>>>>> Changes from v1:
>>>>>> * refreshed to the latested mainline kernel
>>>>>> * added musb_put_id from omap2430 remove.
>>>>>
>>>>> Tony, how do you want to handle this ? You want me to provide you a
>>>>> branch which we both merge ?
>>>>
>>>> Yes that would be great thanks. For the mach-omap2 touching parts:
>>>>
>>>> Acked-by: Tony Lindgren <tony@atomide.com>
>>>
>>> Here it is, let me know if you prefer a signed tag:
>>>
>>> The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
>>>
>>> Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
>>>
>>> are available in the git repository at:
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
>>> usb-phy-binding-omap3
>>>
>>> for you to fetch changes up to 23ada3130cf4e56acb86fdff4c26113188d52d18:
>>>
>>> arm: omap: remove *.auto* from device names given in usb_bind_phy
>>> (2013-12-16 17:44:43 -0600)
>>>
>>> ----------------------------------------------------------------
>>> Kishon Vijay Abraham I (2):
>>> usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
>>> arm: omap: remove *.auto* from device names given in usb_bind_phy
>
> Kishon, are these still valid ?
Looks like board-2430sdp.c got removed. Apart from that the reset of the patch
series is still applicable for non-dt boot.
Thanks
Kishon
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2014-07-23 8:59 ` Kishon Vijay Abraham I
@ 2014-07-29 12:38 ` Laurent Pinchart
2014-07-29 16:39 ` Felipe Balbi
0 siblings, 1 reply; 12+ messages in thread
From: Laurent Pinchart @ 2014-07-29 12:38 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 23 July 2014 14:29:36 Kishon Vijay Abraham I wrote:
> On Monday 21 July 2014 08:45 PM, Felipe Balbi wrote:
> > On Mon, Jul 21, 2014 at 05:04:57PM +0200, Laurent Pinchart wrote:
> >> Hi Felipe,
> >>
> >> What happened to these two patches ?
> >
> > looks like I lost them.
> >
> >> On Monday 16 December 2013 17:48:29 Felipe Balbi wrote:
> >>> On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote:
> >>>> * Felipe Balbi <balbi@ti.com> [131216 13:31]:
> >>>>> On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I
wrote:
> >>>>>> After the platform devices are created using PLATFORM_DEVID_AUTO, the
> >>>>>> device names given in usb_bind_phy (in board file) does not match
> >>>>>> with the actual device name causing the USB PHY library not to return
> >>>>>> the PHY reference when the MUSB controller request for the PHY in the
> >>>>>> non-dt boot case.
> >>>>>> So removed creating platform devices using PLATFORM_DEVID_AUTO in
> >>>>>> omap2430.c.
> >>>>>>
> >>>>>> Did enumeration testing in omap3 beagle.
> >>>>>>
> >>>>>> Changes from v2:
> >>>>>> * Fixed the commit log
> >>>>>>
> >>>>>> Changes from v1:
> >>>>>> * refreshed to the latested mainline kernel
> >>>>>> * added musb_put_id from omap2430 remove.
> >>>>>
> >>>>> Tony, how do you want to handle this ? You want me to provide you a
> >>>>> branch which we both merge ?
> >>>>
> >>>> Yes that would be great thanks. For the mach-omap2 touching parts:
> >>>>
> >>>> Acked-by: Tony Lindgren <tony@atomide.com>
> >>>
> >>> Here it is, let me know if you prefer a signed tag:
> >>>
> >>> The following changes since commit
6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
> >>> Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
> >>>
> >>> are available in the git repository at:
> >>> git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> >>>
> >>> usb-phy-binding-omap3
> >>>
> >>> for you to fetch changes up to 23ada3130cf4e56acb86fdff4c26113188d52d18:
> >>> arm: omap: remove *.auto* from device names given in usb_bind_phy
> >>>
> >>> (2013-12-16 17:44:43 -0600)
> >>>
> >>> ----------------------------------------------------------------
> >>>
> >>> Kishon Vijay Abraham I (2):
> >>> usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
> >>> arm: omap: remove *.auto* from device names given in usb_bind_phy
> >
> > Kishon, are these still valid ?
>
> Looks like board-2430sdp.c got removed. Apart from that the reset of the
> patch series is still applicable for non-dt boot.
Felipe, do you plan to apply the patch without the baord-2430sdp.c change, or
would you like Kishon to rebase and resubmit it ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2014-07-29 12:38 ` Laurent Pinchart
@ 2014-07-29 16:39 ` Felipe Balbi
2014-07-30 6:46 ` Tony Lindgren
0 siblings, 1 reply; 12+ messages in thread
From: Felipe Balbi @ 2014-07-29 16:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tue, Jul 29, 2014 at 02:38:24PM +0200, Laurent Pinchart wrote:
> On Wednesday 23 July 2014 14:29:36 Kishon Vijay Abraham I wrote:
> > On Monday 21 July 2014 08:45 PM, Felipe Balbi wrote:
> > > On Mon, Jul 21, 2014 at 05:04:57PM +0200, Laurent Pinchart wrote:
> > >> Hi Felipe,
> > >>
> > >> What happened to these two patches ?
> > >
> > > looks like I lost them.
> > >
> > >> On Monday 16 December 2013 17:48:29 Felipe Balbi wrote:
> > >>> On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote:
> > >>>> * Felipe Balbi <balbi@ti.com> [131216 13:31]:
> > >>>>> On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I
> wrote:
> > >>>>>> After the platform devices are created using PLATFORM_DEVID_AUTO, the
> > >>>>>> device names given in usb_bind_phy (in board file) does not match
> > >>>>>> with the actual device name causing the USB PHY library not to return
> > >>>>>> the PHY reference when the MUSB controller request for the PHY in the
> > >>>>>> non-dt boot case.
> > >>>>>> So removed creating platform devices using PLATFORM_DEVID_AUTO in
> > >>>>>> omap2430.c.
> > >>>>>>
> > >>>>>> Did enumeration testing in omap3 beagle.
> > >>>>>>
> > >>>>>> Changes from v2:
> > >>>>>> * Fixed the commit log
> > >>>>>>
> > >>>>>> Changes from v1:
> > >>>>>> * refreshed to the latested mainline kernel
> > >>>>>> * added musb_put_id from omap2430 remove.
> > >>>>>
> > >>>>> Tony, how do you want to handle this ? You want me to provide you a
> > >>>>> branch which we both merge ?
> > >>>>
> > >>>> Yes that would be great thanks. For the mach-omap2 touching parts:
> > >>>>
> > >>>> Acked-by: Tony Lindgren <tony@atomide.com>
> > >>>
> > >>> Here it is, let me know if you prefer a signed tag:
> > >>>
> > >>> The following changes since commit
> 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
> > >>> Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
> > >>>
> > >>> are available in the git repository at:
> > >>> git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> > >>>
> > >>> usb-phy-binding-omap3
> > >>>
> > >>> for you to fetch changes up to 23ada3130cf4e56acb86fdff4c26113188d52d18:
> > >>> arm: omap: remove *.auto* from device names given in usb_bind_phy
> > >>>
> > >>> (2013-12-16 17:44:43 -0600)
> > >>>
> > >>> ----------------------------------------------------------------
> > >>>
> > >>> Kishon Vijay Abraham I (2):
> > >>> usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
> > >>> arm: omap: remove *.auto* from device names given in usb_bind_phy
> > >
> > > Kishon, are these still valid ?
> >
> > Looks like board-2430sdp.c got removed. Apart from that the reset of the
> > patch series is still applicable for non-dt boot.
>
> Felipe, do you plan to apply the patch without the baord-2430sdp.c change, or
> would you like Kishon to rebase and resubmit it ?
Not sure if Tony still wants board-* modifications. Tony ?
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140729/c83e2bbf/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform
2014-07-29 16:39 ` Felipe Balbi
@ 2014-07-30 6:46 ` Tony Lindgren
0 siblings, 0 replies; 12+ messages in thread
From: Tony Lindgren @ 2014-07-30 6:46 UTC (permalink / raw)
To: linux-arm-kernel
* Felipe Balbi <balbi@ti.com> [140729 09:42]:
> Hi,
>
> On Tue, Jul 29, 2014 at 02:38:24PM +0200, Laurent Pinchart wrote:
> > On Wednesday 23 July 2014 14:29:36 Kishon Vijay Abraham I wrote:
> > > On Monday 21 July 2014 08:45 PM, Felipe Balbi wrote:
> > > > On Mon, Jul 21, 2014 at 05:04:57PM +0200, Laurent Pinchart wrote:
> > > >> Hi Felipe,
> > > >>
> > > >> What happened to these two patches ?
> > > >
> > > > looks like I lost them.
> > > >
> > > >> On Monday 16 December 2013 17:48:29 Felipe Balbi wrote:
> > > >>> On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote:
> > > >>>> * Felipe Balbi <balbi@ti.com> [131216 13:31]:
> > > >>>>> On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I
> > wrote:
> > > >>>>>> After the platform devices are created using PLATFORM_DEVID_AUTO, the
> > > >>>>>> device names given in usb_bind_phy (in board file) does not match
> > > >>>>>> with the actual device name causing the USB PHY library not to return
> > > >>>>>> the PHY reference when the MUSB controller request for the PHY in the
> > > >>>>>> non-dt boot case.
> > > >>>>>> So removed creating platform devices using PLATFORM_DEVID_AUTO in
> > > >>>>>> omap2430.c.
> > > >>>>>>
> > > >>>>>> Did enumeration testing in omap3 beagle.
> > > >>>>>>
> > > >>>>>> Changes from v2:
> > > >>>>>> * Fixed the commit log
> > > >>>>>>
> > > >>>>>> Changes from v1:
> > > >>>>>> * refreshed to the latested mainline kernel
> > > >>>>>> * added musb_put_id from omap2430 remove.
> > > >>>>>
> > > >>>>> Tony, how do you want to handle this ? You want me to provide you a
> > > >>>>> branch which we both merge ?
> > > >>>>
> > > >>>> Yes that would be great thanks. For the mach-omap2 touching parts:
> > > >>>>
> > > >>>> Acked-by: Tony Lindgren <tony@atomide.com>
> > > >>>
> > > >>> Here it is, let me know if you prefer a signed tag:
> > > >>>
> > > >>> The following changes since commit
> > 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
> > > >>> Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
> > > >>>
> > > >>> are available in the git repository at:
> > > >>> git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> > > >>>
> > > >>> usb-phy-binding-omap3
> > > >>>
> > > >>> for you to fetch changes up to 23ada3130cf4e56acb86fdff4c26113188d52d18:
> > > >>> arm: omap: remove *.auto* from device names given in usb_bind_phy
> > > >>>
> > > >>> (2013-12-16 17:44:43 -0600)
> > > >>>
> > > >>> ----------------------------------------------------------------
> > > >>>
> > > >>> Kishon Vijay Abraham I (2):
> > > >>> usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
> > > >>> arm: omap: remove *.auto* from device names given in usb_bind_phy
> > > >
> > > > Kishon, are these still valid ?
> > >
> > > Looks like board-2430sdp.c got removed. Apart from that the reset of the
> > > patch series is still applicable for non-dt boot.
> >
> > Felipe, do you plan to apply the patch without the baord-2430sdp.c change, or
> > would you like Kishon to rebase and resubmit it ?
>
> Not sure if Tony still wants board-* modifications. Tony ?
Well omap2 is DT only already, so sounds like you can just ignore
board-2430sdp.c as it no longer exists.
If there are other minimal board-*.c file changes needed, then that's
fine as long as they fix things or are needed to keep things working.
Regards,
Tony
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-07-30 6:46 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-16 15:53 [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform Kishon Vijay Abraham I
2013-12-16 15:53 ` [PATCH v3 1/2] usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c Kishon Vijay Abraham I
2013-12-16 15:53 ` [PATCH v3 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy Kishon Vijay Abraham I
2013-12-16 21:29 ` [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform Felipe Balbi
2013-12-16 22:38 ` Tony Lindgren
2013-12-16 23:48 ` Felipe Balbi
2014-07-21 15:04 ` Laurent Pinchart
2014-07-21 15:15 ` Felipe Balbi
2014-07-23 8:59 ` Kishon Vijay Abraham I
2014-07-29 12:38 ` Laurent Pinchart
2014-07-29 16:39 ` Felipe Balbi
2014-07-30 6:46 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).