From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Arm64: Fix build error while switching from LE to BE
Date: Wed, 30 Jul 2014 15:09:35 +0100 [thread overview]
Message-ID: <20140730140935.GA8989@arm.com> (raw)
In-Reply-To: <CAFdej004ma0xyzBHCmijx1r3iQFiWPRMLRgi20ryZDJz5iJZGw@mail.gmail.com>
On Wed, Jul 30, 2014 at 03:01:35PM +0100, Arun Chandran wrote:
> On Thu, Jun 26, 2014 at 3:16 PM, Arun Chandran <achandran@mvista.com> wrote:
> > Building a kernel with CPU_BIG_ENDIAN fails if there are stale objects
> > from a !CPU_BIG_ENDIAN build. Due to a missing FORCE prerequisite on an
> > if_changed rule in the VDSO Makefile, we attempt to link a stale LE
> > object into the new BE kernel. According to Documentation/kbuild/makefiles.txt
> > FORCE is required for if_changed rules, and forgetting it is a common mistake
> >
> > So fix it by 'Forcing' the build of vdso. Fixes build errors like these:
> >
> > arch/arm64/kernel/vdso/note.o: compiled for a little endian system and target is big endian
> > failed to merge target specific data of file arch/arm64/kernel/vdso/note.o
> >
> > arch/arm64/kernel/vdso/sigreturn.o: compiled for a little endian system and target is big endian
> > failed to merge target specific data of file arch/arm64/kernel/vdso/sigreturn.o
> >
> > Signed-off-by: Arun Chandran <achandran@mvista.com>
> > Tested-by: Mark Rutland <mark.rutland@arm.com>
> > ---
> > arch/arm64/kernel/vdso/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile
> > index 6d20b7d..a268a9a 100644
> > --- a/arch/arm64/kernel/vdso/Makefile
> > +++ b/arch/arm64/kernel/vdso/Makefile
> > @@ -43,7 +43,7 @@ $(obj)/vdso-offsets.h: $(obj)/vdso.so.dbg FORCE
> > $(call if_changed,vdsosym)
> >
> > # Assembly rules for the .S files
> > -$(obj-vdso): %.o: %.S
> > +$(obj-vdso): %.o: %.S FORCE
> > $(call if_changed_dep,vdsoas)
> >
> > # Actual build commands
> > --
> > 1.7.9.5
> >
>
> Any update on this?
Sorry, this slipped through the cracks (neither myself or Catalin were on CC
and we didn't spot it on the list).
I've applied it to our for-next branch targetting 3.17 and will push out
after a bit of testing.
Will
next prev parent reply other threads:[~2014-07-30 14:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 9:46 [PATCH] Arm64: Fix build error while switching from LE to BE Arun Chandran
2014-07-30 14:01 ` Arun Chandran
2014-07-30 14:09 ` Will Deacon [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-26 6:46 Arun Chandran
2014-06-26 9:29 ` Mark Rutland
2014-06-26 9:37 ` Arun Chandran
2014-06-25 15:09 arun chandran
2014-06-25 16:33 ` Mark Rutland
2014-06-25 19:28 ` Geoff Levand
2014-06-26 6:03 ` Arun Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730140935.GA8989@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).