linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dyoung@redhat.com (Dave Young)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] UEFI arm64: add noefi boot param
Date: Thu, 7 Aug 2014 14:19:45 +0800	[thread overview]
Message-ID: <20140807061945.GE20295@darkstar.nay.redhat.com> (raw)
In-Reply-To: <20140806141814.GD15082@console-pimps.org>

On 08/06/14 at 03:18pm, Matt Fleming wrote:
> On Wed, 06 Aug, at 04:10:45PM, Ard Biesheuvel wrote:
> > 
> > Shouldn't we clear the bit here if we failed to enable runtime
> > services for some reason? Other code may test the bit assuming that it
> > signifies that runtime services have been enabled successfully, while
> > this patch changes it to mean that we /intended/ to enable them, which
> > is not quite the same thing.
> 
> Yep, good catch. We need to do something similar for efi_runtime_init()
> on x86 too.

The current efi_runtime_init() enables the bit after getting the efi callback
phyaddr of SetVirtualAddressMap.

Thinking more about it, since SetVirtualAddressMap() could fail somehow it
seems better to set EFI_RUNTIME_SERIVCES bit only when enter virtual mode
return EFI_SUCCESS.

Does it make sense to you, Matt?

Thanks
Dave

  parent reply	other threads:[~2014-08-07  6:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06  8:38 [PATCH 1/2] UEFI arm64: add noefi boot param Dave Young
2014-08-06 12:39 ` Will Deacon
2014-08-06 12:40 ` Ard Biesheuvel
2014-08-07  1:28   ` Dave Young
2014-08-07  7:07     ` Ard Biesheuvel
2014-08-06 13:06 ` Leif Lindholm
2014-08-06 13:20   ` Matt Fleming
2014-08-06 13:29     ` Leif Lindholm
2014-08-06 14:01       ` Matt Fleming
2014-08-06 14:10         ` Ard Biesheuvel
2014-08-06 14:18           ` Matt Fleming
2014-08-06 14:48             ` Leif Lindholm
2014-08-06 14:55               ` Matt Fleming
2014-08-07  6:19             ` Dave Young [this message]
2014-08-07 20:26               ` Matt Fleming
2014-08-11  9:00                 ` Dave Young
2014-08-07  1:27         ` Dave Young
2014-08-07 20:09           ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140807061945.GE20295@darkstar.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).