linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: matt@console-pimps.org (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] UEFI arm64: add noefi boot param
Date: Thu, 7 Aug 2014 21:26:20 +0100	[thread overview]
Message-ID: <20140807202620.GI15082@console-pimps.org> (raw)
In-Reply-To: <20140807061945.GE20295@darkstar.nay.redhat.com>

On Thu, 07 Aug, at 02:19:45PM, Dave Young wrote:
> 
> The current efi_runtime_init() enables the bit after getting the efi
> callback phyaddr of SetVirtualAddressMap.
> 
> Thinking more about it, since SetVirtualAddressMap() could fail
> somehow it seems better to set EFI_RUNTIME_SERIVCES bit only when
> enter virtual mode return EFI_SUCCESS.
> 
> Does it make sense to you, Matt?

If you're going ahead with the scheme I proposed yesterday you'd
actually want to *clear* the EFI_RUNTIME_SERVICES bit if
SetVirtualAddressMap() fails, since we would have set it by default for
EFI_BOOT.

However, I still think we want to panic() if SetVirtualAddressMap()
fails because we really never expect that function to return an error
under normal circumstances. Also, I'm not sure it's safe to make any
assumptions about the state of the system if SetVirtualAddressMap()
fails.

-- 
Matt Fleming, Intel Open Source Technology Center

  reply	other threads:[~2014-08-07 20:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06  8:38 [PATCH 1/2] UEFI arm64: add noefi boot param Dave Young
2014-08-06 12:39 ` Will Deacon
2014-08-06 12:40 ` Ard Biesheuvel
2014-08-07  1:28   ` Dave Young
2014-08-07  7:07     ` Ard Biesheuvel
2014-08-06 13:06 ` Leif Lindholm
2014-08-06 13:20   ` Matt Fleming
2014-08-06 13:29     ` Leif Lindholm
2014-08-06 14:01       ` Matt Fleming
2014-08-06 14:10         ` Ard Biesheuvel
2014-08-06 14:18           ` Matt Fleming
2014-08-06 14:48             ` Leif Lindholm
2014-08-06 14:55               ` Matt Fleming
2014-08-07  6:19             ` Dave Young
2014-08-07 20:26               ` Matt Fleming [this message]
2014-08-11  9:00                 ` Dave Young
2014-08-07  1:27         ` Dave Young
2014-08-07 20:09           ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140807202620.GI15082@console-pimps.org \
    --to=matt@console-pimps.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).