* [PATCH 2/14] net: axienet: delete unneeded test before of_node_put
@ 2014-08-08 10:07 Julia Lawall
2014-08-08 10:44 ` Michal Simek
2014-08-08 17:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2014-08-08 10:07 UTC (permalink / raw)
To: linux-arm-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Of_node_put supports NULL as its argument, so the initial test is not
necessary.
Suggested by Uwe Kleine-K?nig.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 7b0a735..30e8608 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1630,8 +1630,7 @@ static int axienet_of_remove(struct platform_device *op)
axienet_mdio_teardown(lp);
unregister_netdev(ndev);
- if (lp->phy_node)
- of_node_put(lp->phy_node);
+ of_node_put(lp->phy_node);
lp->phy_node = NULL;
iounmap(lp->regs);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/14] net: axienet: delete unneeded test before of_node_put
2014-08-08 10:07 [PATCH 2/14] net: axienet: delete unneeded test before of_node_put Julia Lawall
@ 2014-08-08 10:44 ` Michal Simek
2014-08-08 17:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2014-08-08 10:44 UTC (permalink / raw)
To: linux-arm-kernel
On 08/08/2014 12:07 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Of_node_put supports NULL as its argument, so the initial test is not
> necessary.
>
> Suggested by Uwe Kleine-K?nig.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e;
> @@
>
> -if (e)
> of_node_put(e);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 7b0a735..30e8608 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1630,8 +1630,7 @@ static int axienet_of_remove(struct platform_device *op)
> axienet_mdio_teardown(lp);
> unregister_netdev(ndev);
>
> - if (lp->phy_node)
> - of_node_put(lp->phy_node);
> + of_node_put(lp->phy_node);
> lp->phy_node = NULL;
>
> iounmap(lp->regs);
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/14] net: axienet: delete unneeded test before of_node_put
2014-08-08 10:07 [PATCH 2/14] net: axienet: delete unneeded test before of_node_put Julia Lawall
2014-08-08 10:44 ` Michal Simek
@ 2014-08-08 17:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-08-08 17:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Fri, 8 Aug 2014 12:07:43 +0200
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Of_node_put supports NULL as its argument, so the initial test is not
> necessary.
>
> Suggested by Uwe Kleine-K?nig.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-08 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-08 10:07 [PATCH 2/14] net: axienet: delete unneeded test before of_node_put Julia Lawall
2014-08-08 10:44 ` Michal Simek
2014-08-08 17:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).