* [PATCH v2] ARM: imx6: add pci config space as platform resource
@ 2014-08-07 17:39 Lucas Stach
2014-08-07 18:12 ` Fabio Estevam
2014-09-01 14:41 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Lucas Stach @ 2014-08-07 17:39 UTC (permalink / raw)
To: linux-arm-kernel
Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space"
error exposed by new versions of the designware pcie driver.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
v2: also fix documentation example
---
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
arch/arm/boot/dts/imx6qdl.dtsi | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 9455fd0ec830..6fbba53a309b 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
@@ -17,7 +17,9 @@ Example:
pcie at 0x01000000 {
compatible = "fsl,imx6q-pcie", "snps,dw-pcie";
- reg = <0x01ffc000 0x4000>;
+ reg = <0x01ffc000 0x04000>,
+ <0x01f00000 0x80000>;
+ reg-names = "dbi", "config";
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index ce0599134a69..6b5da2a98aaf 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -133,7 +133,9 @@
pcie: pcie at 0x01000000 {
compatible = "fsl,imx6q-pcie", "snps,dw-pcie";
- reg = <0x01ffc000 0x4000>; /* DBI */
+ reg = <0x01ffc000 0x04000>,
+ <0x01f00000 0x80000>;
+ reg-names = "dbi", "config";
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
--
2.0.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2] ARM: imx6: add pci config space as platform resource
2014-08-07 17:39 [PATCH v2] ARM: imx6: add pci config space as platform resource Lucas Stach
@ 2014-08-07 18:12 ` Fabio Estevam
2014-08-08 8:36 ` Lucas Stach
2014-09-01 14:41 ` Shawn Guo
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2014-08-07 18:12 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 7, 2014 at 2:39 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space"
> error exposed by new versions of the designware pcie driver.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2: also fix documentation example
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
> arch/arm/boot/dts/imx6qdl.dtsi | 4 +++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index 9455fd0ec830..6fbba53a309b 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -17,7 +17,9 @@ Example:
>
> pcie at 0x01000000 {
> compatible = "fsl,imx6q-pcie", "snps,dw-pcie";
> - reg = <0x01ffc000 0x4000>;
> + reg = <0x01ffc000 0x04000>,
> + <0x01f00000 0x80000>;
> + reg-names = "dbi", "config";
It would be nice to update the 'reg' description and add the
'reg-names' entry in the 'Required properties' section.
Currently we have the following description:
"reg: base addresse (---> typo here) and length of the pcie
controller" ,which does not match the provided example after your
patch.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] ARM: imx6: add pci config space as platform resource
2014-08-07 18:12 ` Fabio Estevam
@ 2014-08-08 8:36 ` Lucas Stach
2014-08-08 8:51 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Lucas Stach @ 2014-08-08 8:36 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, den 07.08.2014, 15:12 -0300 schrieb Fabio Estevam:
> On Thu, Aug 7, 2014 at 2:39 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space"
> > error exposed by new versions of the designware pcie driver.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > v2: also fix documentation example
> > ---
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
> > arch/arm/boot/dts/imx6qdl.dtsi | 4 +++-
> > 2 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > index 9455fd0ec830..6fbba53a309b 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > @@ -17,7 +17,9 @@ Example:
> >
> > pcie at 0x01000000 {
> > compatible = "fsl,imx6q-pcie", "snps,dw-pcie";
> > - reg = <0x01ffc000 0x4000>;
> > + reg = <0x01ffc000 0x04000>,
> > + <0x01f00000 0x80000>;
> > + reg-names = "dbi", "config";
>
> It would be nice to update the 'reg' description and add the
> 'reg-names' entry in the 'Required properties' section.
>
> Currently we have the following description:
>
> "reg: base addresse (---> typo here) and length of the pcie
> controller" ,which does not match the provided example after your
> patch.
>
I'm a bit on the fence here. Yes, it's a bit inconsistent with the
example, but it's actually the same approach chosen for other properties
like clocks. Base properties are inherited from designware-pcie.txt and
only additional things are documented in fsl,imx6q-pcie.txt.
I'm leaning toward not breaking the existing practice.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] ARM: imx6: add pci config space as platform resource
2014-08-08 8:36 ` Lucas Stach
@ 2014-08-08 8:51 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2014-08-08 8:51 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 08, 2014 at 10:36:04AM +0200, Lucas Stach wrote:
> Am Donnerstag, den 07.08.2014, 15:12 -0300 schrieb Fabio Estevam:
> > On Thu, Aug 7, 2014 at 2:39 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > > Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space"
> > > error exposed by new versions of the designware pcie driver.
> > >
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > > v2: also fix documentation example
> > > ---
> > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
> > > arch/arm/boot/dts/imx6qdl.dtsi | 4 +++-
> > > 2 files changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > > index 9455fd0ec830..6fbba53a309b 100644
> > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > > @@ -17,7 +17,9 @@ Example:
> > >
> > > pcie at 0x01000000 {
> > > compatible = "fsl,imx6q-pcie", "snps,dw-pcie";
> > > - reg = <0x01ffc000 0x4000>;
> > > + reg = <0x01ffc000 0x04000>,
> > > + <0x01f00000 0x80000>;
> > > + reg-names = "dbi", "config";
> >
> > It would be nice to update the 'reg' description and add the
> > 'reg-names' entry in the 'Required properties' section.
> >
> > Currently we have the following description:
> >
> > "reg: base addresse (---> typo here) and length of the pcie
> > controller" ,which does not match the provided example after your
> > patch.
> >
> I'm a bit on the fence here. Yes, it's a bit inconsistent with the
> example, but it's actually the same approach chosen for other properties
> like clocks. Base properties are inherited from designware-pcie.txt and
> only additional things are documented in fsl,imx6q-pcie.txt.
>
> I'm leaning toward not breaking the existing practice.
+1
Will apply it as a fix once v3.17-rc1 is out. Remind me if I forget.
Shawn
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: imx6: add pci config space as platform resource
2014-08-07 17:39 [PATCH v2] ARM: imx6: add pci config space as platform resource Lucas Stach
2014-08-07 18:12 ` Fabio Estevam
@ 2014-09-01 14:41 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2014-09-01 14:41 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 07, 2014 at 07:39:41PM +0200, Lucas Stach wrote:
> Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space"
> error exposed by new versions of the designware pcie driver.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-01 14:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-07 17:39 [PATCH v2] ARM: imx6: add pci config space as platform resource Lucas Stach
2014-08-07 18:12 ` Fabio Estevam
2014-08-08 8:36 ` Lucas Stach
2014-08-08 8:51 ` Shawn Guo
2014-09-01 14:41 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).