linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: tegra: Add PMC thermtrip programming to Jetson TK1 device tree
Date: Wed, 13 Aug 2014 10:03:25 +0200	[thread overview]
Message-ID: <20140813080324.GC7735@ulmo> (raw)
In-Reply-To: <53EB1932.9040601@nvidia.com>

On Wed, Aug 13, 2014 at 10:52:18AM +0300, Mikko Perttunen wrote:
> On 13/08/14 10:37, Thierry Reding wrote:
> >* PGP Signed by an unknown key
> >
> >On Tue, Aug 05, 2014 at 11:12:59AM +0300, Mikko Perttunen wrote:
> >>This adds the required information to reset the board during an overheating
> >>situation to the Jetson TK1 device tree. The thermal reset is handled by the
> >>PMC by sending an I2C message to the PMIC. The entries specify the I2C
> >>message to be sent.
> >>
> >>Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> >>---
> >>  arch/arm/boot/dts/tegra124-jetson-tk1.dts | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >>diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> >>index 624b0fb..ee178c4 100644
> >>--- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> >>+++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> >>@@ -1617,6 +1617,11 @@
> >>  		nvidia,core-pwr-off-time = <61036>;
> >>  		nvidia,core-power-req-active-high;
> >>  		nvidia,sys-clock-req-active-high;
> >>+
> >>+		nvidia,thermtrip-pmu-i2c-addr = <0x40>;
> >>+		nvidia,thermtrip-i2c-controller = <4>;
> >>+		nvidia,thermtrip-reg-addr = <0x36>;
> >>+		nvidia,thermtrip-reg-data = <0x2>;
> >
> >Given the number of properties that this can potentially have, I wonder
> >if perhaps it would be a good idea to put this into a subnode, like
> >this:
> >
> >		thermtrip {
> >			pmu-i2c-addr = <0x40>;
> >			i2c-controller = <4>;
> >			...
> >		};
> 
> I guess that'd look a bit nicer.

Mind you, this may be somewhat on the edge of what's considered good
practice for DT content, so maybe wait for a second opinion before going
ahead with this.

I don't have any objections to a set of nvidia,thermtrip-* properties, I
just think it's fairly redundant to keep repeating that prefix (and it
causes ugliness in drivers, too).

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140813/2c25f07b/attachment.sig>

  reply	other threads:[~2014-08-13  8:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  8:12 [PATCH 0/3] Thermal reset support in PMC Mikko Perttunen
2014-08-05  8:12 ` [PATCH 1/3] of: Add descriptions of thermtrip properties to Tegra PMC bindings Mikko Perttunen
2014-08-13  7:35   ` Thierry Reding
2014-08-13  7:51     ` Mikko Perttunen
2014-08-13  8:01       ` Thierry Reding
2014-08-05  8:12 ` [PATCH 2/3] ARM: tegra: Add PMC thermtrip programming to Jetson TK1 device tree Mikko Perttunen
2014-08-13  7:37   ` Thierry Reding
2014-08-13  7:52     ` Mikko Perttunen
2014-08-13  8:03       ` Thierry Reding [this message]
2014-08-13  8:06         ` Mikko Perttunen
2014-08-05  8:13 ` [PATCH 3/3] ARM: tegra: Add thermal reset (thermtrip) support to PMC Mikko Perttunen
2014-08-13  7:53   ` Thierry Reding
2014-08-13  8:05     ` Mikko Perttunen
2014-08-13 10:10   ` Wei Ni
2014-08-13  8:07 ` [PATCH 0/3] Thermal reset support in PMC Thierry Reding
2014-08-13  8:12   ` Mikko Perttunen
2014-08-13  8:42     ` Mikko Perttunen
2014-08-13  8:57       ` Thierry Reding
2014-08-13  9:52         ` Mikko Perttunen
2014-08-13 10:36           ` Thierry Reding
2014-08-13 10:41             ` Mikko Perttunen
2014-08-13 10:53               ` Thierry Reding
2014-08-13 10:59                 ` Mikko Perttunen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140813080324.GC7735@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).