From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 3/3] ARM: dts: socfpga: memreserve first 4KB for SMP code
Date: Fri, 15 Aug 2014 12:27:58 +0100 [thread overview]
Message-ID: <20140815112758.GE15621@leverpostej> (raw)
In-Reply-To: <1408050814-28595-4-git-send-email-dinguyen@opensource.altera.com>
Hi Dinh,
On Thu, Aug 14, 2014 at 10:13:34PM +0100, dinguyen at opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> The SOCFPGA's SMP code uses 0x0 for as the location for the trampoline to
> bring secondary cores online. This patch adds a /memreserve/ section to
> reserve the first 4K for the SMP trampoline code.
I'm slightly confused.
Sorry to split hairs here, but I think the comment is subtly wrong.
The trampoline code seems to be placed in this location by Linux, so
it's not that we're protecting the trampoline code, but rather we're
preserving the location for future use.
I take it that the reset address isn't configurable?
Thanks,
Mark.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Acked-by: Pavel Machek <pavel@denx.de>
> ---
> v2: Add a comment in the dts files
> ---
> arch/arm/boot/dts/socfpga_arria5.dtsi | 2 ++
> arch/arm/boot/dts/socfpga_cyclone5.dtsi | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/socfpga_arria5.dtsi b/arch/arm/boot/dts/socfpga_arria5.dtsi
> index 468fc4c..03e8268 100644
> --- a/arch/arm/boot/dts/socfpga_arria5.dtsi
> +++ b/arch/arm/boot/dts/socfpga_arria5.dtsi
> @@ -15,6 +15,8 @@
> */
>
> /dts-v1/;
> +/* First 4KB has trampoline code for secondary cores. */
> +/memreserve/ 0x00000000 0x0001000;
> #include "socfpga.dtsi"
>
> / {
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5.dtsi b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
> index 33cad8b..28c05e7 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5.dtsi
> +++ b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
> @@ -16,6 +16,8 @@
> */
>
> /dts-v1/;
> +/* First 4KB has trampoline code for secondary cores. */
> +/memreserve/ 0x00000000 0x0001000;
> #include "socfpga.dtsi"
>
> / {
> --
> 2.0.3
>
>
next prev parent reply other threads:[~2014-08-15 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 21:13 [PATCHv2 0/3] ARM: dts: socfpga: updates for SOCFPGA dinguyen at opensource.altera.com
2014-08-14 21:13 ` [PATCHv2 1/3] ARM: dts: socfpga: remove extra alias in the ArriaV devkit dinguyen at opensource.altera.com
2014-08-14 21:13 ` [PATCHv2 2/3] ARM: dts: socfpga: Add SD card detect dinguyen at opensource.altera.com
2014-08-14 21:13 ` [PATCHv2 3/3] ARM: dts: socfpga: memreserve first 4KB for SMP code dinguyen at opensource.altera.com
2014-08-15 11:27 ` Mark Rutland [this message]
2014-08-15 13:43 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815112758.GE15621@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox