* [PATCH 1/9] phy: phy-omap-control: Remove unncessary site specific OOM messages
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-08-15 12:40 ` [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc Peter Griffin
` (8 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().
Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-omap-control.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/phy-omap-control.c b/drivers/phy/phy-omap-control.c
index 9487bf1..cb2f4d1 100644
--- a/drivers/phy/phy-omap-control.c
+++ b/drivers/phy/phy-omap-control.c
@@ -295,10 +295,8 @@ static int omap_control_phy_probe(struct platform_device *pdev)
control_phy = devm_kzalloc(&pdev->dev, sizeof(*control_phy),
GFP_KERNEL);
- if (!control_phy) {
- dev_err(&pdev->dev, "unable to alloc memory for control phy\n");
+ if (!control_phy)
return -ENOMEM;
- }
control_phy->dev = &pdev->dev;
control_phy->type = *(enum omap_control_phy_type *)of_id->data;
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
2014-08-15 12:40 ` [PATCH 1/9] phy: phy-omap-control: Remove unncessary site specific OOM messages Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-08-15 13:10 ` Andrew Lunn
2014-08-15 12:40 ` [PATCH 3/9] phy: phy-omap-usb2: Remove unncessary site specific OOM messages Peter Griffin
` (7 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
Currently this driver is missing a check on the return value of devm_kzalloc,
which would cause a NULL pointer dereference in a OOM situation.
This patch adds the aformentioned missing check.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-mvebu-sata.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/phy-mvebu-sata.c b/drivers/phy/phy-mvebu-sata.c
index cc3c0e1..10bb8e5 100644
--- a/drivers/phy/phy-mvebu-sata.c
+++ b/drivers/phy/phy-mvebu-sata.c
@@ -89,6 +89,8 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev)
struct phy *phy;
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+ if (!priv)
+ return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
priv->base = devm_ioremap_resource(&pdev->dev, res);
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc
2014-08-15 12:40 ` [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc Peter Griffin
@ 2014-08-15 13:10 ` Andrew Lunn
0 siblings, 0 replies; 15+ messages in thread
From: Andrew Lunn @ 2014-08-15 13:10 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 15, 2014 at 01:40:09PM +0100, Peter Griffin wrote:
> Currently this driver is missing a check on the return value of devm_kzalloc,
> which would cause a NULL pointer dereference in a OOM situation.
>
> This patch adds the aformentioned missing check.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/phy/phy-mvebu-sata.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/phy-mvebu-sata.c b/drivers/phy/phy-mvebu-sata.c
> index cc3c0e1..10bb8e5 100644
> --- a/drivers/phy/phy-mvebu-sata.c
> +++ b/drivers/phy/phy-mvebu-sata.c
> @@ -89,6 +89,8 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev)
> struct phy *phy;
>
> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> priv->base = devm_ioremap_resource(&pdev->dev, res);
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/9] phy: phy-omap-usb2: Remove unncessary site specific OOM messages
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
2014-08-15 12:40 ` [PATCH 1/9] phy: phy-omap-control: Remove unncessary site specific OOM messages Peter Griffin
2014-08-15 12:40 ` [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-08-15 12:40 ` [PATCH 4/9] phy: phy-ti-pipe3: " Peter Griffin
` (6 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().
Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-omap-usb2.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c
index 93d7835..51c6f92 100644
--- a/drivers/phy/phy-omap-usb2.c
+++ b/drivers/phy/phy-omap-usb2.c
@@ -212,16 +212,12 @@ static int omap_usb2_probe(struct platform_device *pdev)
phy_data = (struct usb_phy_data *)of_id->data;
phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL);
- if (!phy) {
- dev_err(&pdev->dev, "unable to allocate memory for USB2 PHY\n");
+ if (!phy)
return -ENOMEM;
- }
otg = devm_kzalloc(&pdev->dev, sizeof(*otg), GFP_KERNEL);
- if (!otg) {
- dev_err(&pdev->dev, "unable to allocate memory for USB OTG\n");
+ if (!otg)
return -ENOMEM;
- }
phy->dev = &pdev->dev;
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 4/9] phy: phy-ti-pipe3: Remove unncessary site specific OOM messages
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
` (2 preceding siblings ...)
2014-08-15 12:40 ` [PATCH 3/9] phy: phy-omap-usb2: Remove unncessary site specific OOM messages Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-08-15 12:40 ` [PATCH 5/9] phy: phy-spear1310-miphy: " Peter Griffin
` (5 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().
Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-ti-pipe3.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
index b964aa9..9280ef8 100644
--- a/drivers/phy/phy-ti-pipe3.c
+++ b/drivers/phy/phy-ti-pipe3.c
@@ -299,10 +299,9 @@ static int ti_pipe3_probe(struct platform_device *pdev)
struct clk *clk;
phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL);
- if (!phy) {
- dev_err(&pdev->dev, "unable to alloc mem for TI PIPE3 PHY\n");
+ if (!phy)
return -ENOMEM;
- }
+
phy->dev = &pdev->dev;
if (!of_device_is_compatible(node, "ti,phy-pipe3-pcie")) {
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 5/9] phy: phy-spear1310-miphy: Remove unncessary site specific OOM messages
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
` (3 preceding siblings ...)
2014-08-15 12:40 ` [PATCH 4/9] phy: phy-ti-pipe3: " Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-08-15 12:40 ` [PATCH 6/9] phy: phy-spear1340-miphy: " Peter Griffin
` (4 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().
Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-spear1310-miphy.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c
index 6dcbfcd..911d25b 100644
--- a/drivers/phy/phy-spear1310-miphy.c
+++ b/drivers/phy/phy-spear1310-miphy.c
@@ -212,10 +212,8 @@ static int spear1310_miphy_probe(struct platform_device *pdev)
struct phy_provider *phy_provider;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(dev, "can't alloc spear1310_miphy private date memory\n");
+ if (!priv)
return -ENOMEM;
- }
priv->misc =
syscon_regmap_lookup_by_phandle(dev->of_node, "misc");
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 6/9] phy: phy-spear1340-miphy: Remove unncessary site specific OOM messages
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
` (4 preceding siblings ...)
2014-08-15 12:40 ` [PATCH 5/9] phy: phy-spear1310-miphy: " Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-08-15 12:40 ` [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver Peter Griffin
` (3 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().
Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-spear1340-miphy.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c
index 7135ba2..ee4d66f 100644
--- a/drivers/phy/phy-spear1340-miphy.c
+++ b/drivers/phy/phy-spear1340-miphy.c
@@ -249,10 +249,8 @@ static int spear1340_miphy_probe(struct platform_device *pdev)
struct phy_provider *phy_provider;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(dev, "can't alloc spear1340_miphy private date memory\n");
+ if (!priv)
return -ENOMEM;
- }
priv->misc =
syscon_regmap_lookup_by_phandle(dev->of_node, "misc");
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
` (5 preceding siblings ...)
2014-08-15 12:40 ` [PATCH 6/9] phy: phy-spear1340-miphy: " Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-09-17 16:19 ` Kishon Vijay Abraham I
2014-08-15 12:40 ` [PATCH 8/9] phy: phy-spear1310-miphy: Use module_platform_driver to register driver Peter Griffin
` (2 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
This patch removes the superflous .owner field for drivers which
use the module_platform_driver or platform_driver_register api,
as this is overriden in __platform_driver_register.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-bcm-kona-usb2.c | 1 -
drivers/phy/phy-berlin-sata.c | 1 -
drivers/phy/phy-exynos-dp-video.c | 1 -
drivers/phy/phy-exynos-mipi-video.c | 1 -
drivers/phy/phy-exynos5-usbdrd.c | 1 -
drivers/phy/phy-exynos5250-sata.c | 1 -
drivers/phy/phy-hix5hd2-sata.c | 1 -
drivers/phy/phy-miphy365x.c | 1 -
drivers/phy/phy-mvebu-sata.c | 1 -
drivers/phy/phy-omap-control.c | 1 -
drivers/phy/phy-omap-usb2.c | 1 -
drivers/phy/phy-qcom-apq8064-sata.c | 1 -
drivers/phy/phy-qcom-ipq806x-sata.c | 1 -
drivers/phy/phy-samsung-usb2.c | 1 -
drivers/phy/phy-sun4i-usb.c | 1 -
drivers/phy/phy-ti-pipe3.c | 1 -
drivers/phy/phy-twl4030-usb.c | 1 -
drivers/phy/phy-xgene.c | 1 -
18 files changed, 18 deletions(-)
diff --git a/drivers/phy/phy-bcm-kona-usb2.c b/drivers/phy/phy-bcm-kona-usb2.c
index 894fe74..c1e0ca3 100644
--- a/drivers/phy/phy-bcm-kona-usb2.c
+++ b/drivers/phy/phy-bcm-kona-usb2.c
@@ -143,7 +143,6 @@ static struct platform_driver bcm_kona_usb2_driver = {
.probe = bcm_kona_usb2_probe,
.driver = {
.name = "bcm-kona-usb2",
- .owner = THIS_MODULE,
.of_match_table = bcm_kona_usb2_dt_ids,
},
};
diff --git a/drivers/phy/phy-berlin-sata.c b/drivers/phy/phy-berlin-sata.c
index 5c3a042..69ced52 100644
--- a/drivers/phy/phy-berlin-sata.c
+++ b/drivers/phy/phy-berlin-sata.c
@@ -273,7 +273,6 @@ static struct platform_driver phy_berlin_sata_driver = {
.probe = phy_berlin_sata_probe,
.driver = {
.name = "phy-berlin-sata",
- .owner = THIS_MODULE,
.of_match_table = phy_berlin_sata_of_match,
},
};
diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
index 8b3026e..5c6e513 100644
--- a/drivers/phy/phy-exynos-dp-video.c
+++ b/drivers/phy/phy-exynos-dp-video.c
@@ -99,7 +99,6 @@ static struct platform_driver exynos_dp_video_phy_driver = {
.probe = exynos_dp_video_phy_probe,
.driver = {
.name = "exynos-dp-video-phy",
- .owner = THIS_MODULE,
.of_match_table = exynos_dp_video_phy_of_match,
}
};
diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
index b55a92e..6a9bef1 100644
--- a/drivers/phy/phy-exynos-mipi-video.c
+++ b/drivers/phy/phy-exynos-mipi-video.c
@@ -165,7 +165,6 @@ static struct platform_driver exynos_mipi_video_phy_driver = {
.driver = {
.of_match_table = exynos_mipi_video_phy_of_match,
.name = "exynos-mipi-video-phy",
- .owner = THIS_MODULE,
}
};
module_platform_driver(exynos_mipi_video_phy_driver);
diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index b05302b..929c7d0 100644
--- a/drivers/phy/phy-exynos5-usbdrd.c
+++ b/drivers/phy/phy-exynos5-usbdrd.c
@@ -666,7 +666,6 @@ static struct platform_driver exynos5_usb3drd_phy = {
.driver = {
.of_match_table = exynos5_usbdrd_phy_of_match,
.name = "exynos5_usb3drd_phy",
- .owner = THIS_MODULE,
}
};
diff --git a/drivers/phy/phy-exynos5250-sata.c b/drivers/phy/phy-exynos5250-sata.c
index 19a679a..54cf4ae 100644
--- a/drivers/phy/phy-exynos5250-sata.c
+++ b/drivers/phy/phy-exynos5250-sata.c
@@ -240,7 +240,6 @@ static struct platform_driver exynos_sata_phy_driver = {
.driver = {
.of_match_table = exynos_sata_phy_of_match,
.name = "samsung,sata-phy",
- .owner = THIS_MODULE,
}
};
module_platform_driver(exynos_sata_phy_driver);
diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c
index 6a08fa5..d5d9780 100644
--- a/drivers/phy/phy-hix5hd2-sata.c
+++ b/drivers/phy/phy-hix5hd2-sata.c
@@ -180,7 +180,6 @@ static struct platform_driver hix5hd2_sata_phy_driver = {
.probe = hix5hd2_sata_phy_probe,
.driver = {
.name = "hix5hd2-sata-phy",
- .owner = THIS_MODULE,
.of_match_table = hix5hd2_sata_phy_of_match,
}
};
diff --git a/drivers/phy/phy-miphy365x.c b/drivers/phy/phy-miphy365x.c
index e111baf..a010bf4 100644
--- a/drivers/phy/phy-miphy365x.c
+++ b/drivers/phy/phy-miphy365x.c
@@ -625,7 +625,6 @@ static struct platform_driver miphy365x_driver = {
.probe = miphy365x_probe,
.driver = {
.name = "miphy365x-phy",
- .owner = THIS_MODULE,
.of_match_table = miphy365x_of_match,
}
};
diff --git a/drivers/phy/phy-mvebu-sata.c b/drivers/phy/phy-mvebu-sata.c
index 10bb8e5..d395558 100644
--- a/drivers/phy/phy-mvebu-sata.c
+++ b/drivers/phy/phy-mvebu-sata.c
@@ -128,7 +128,6 @@ static struct platform_driver phy_mvebu_sata_driver = {
.probe = phy_mvebu_sata_probe,
.driver = {
.name = "phy-mvebu-sata",
- .owner = THIS_MODULE,
.of_match_table = phy_mvebu_sata_of_match,
}
};
diff --git a/drivers/phy/phy-omap-control.c b/drivers/phy/phy-omap-control.c
index cb2f4d1..c96e818 100644
--- a/drivers/phy/phy-omap-control.c
+++ b/drivers/phy/phy-omap-control.c
@@ -345,7 +345,6 @@ static struct platform_driver omap_control_phy_driver = {
.probe = omap_control_phy_probe,
.driver = {
.name = "omap-control-phy",
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(omap_control_phy_id_table),
},
};
diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c
index 51c6f92..8c84298 100644
--- a/drivers/phy/phy-omap-usb2.c
+++ b/drivers/phy/phy-omap-usb2.c
@@ -378,7 +378,6 @@ static struct platform_driver omap_usb2_driver = {
.remove = omap_usb2_remove,
.driver = {
.name = "omap-usb2",
- .owner = THIS_MODULE,
.pm = DEV_PM_OPS,
.of_match_table = of_match_ptr(omap_usb2_id_table),
},
diff --git a/drivers/phy/phy-qcom-apq8064-sata.c b/drivers/phy/phy-qcom-apq8064-sata.c
index b3ef7d8..7b3ddfb 100644
--- a/drivers/phy/phy-qcom-apq8064-sata.c
+++ b/drivers/phy/phy-qcom-apq8064-sata.c
@@ -279,7 +279,6 @@ static struct platform_driver qcom_apq8064_sata_phy_driver = {
.remove = qcom_apq8064_sata_phy_remove,
.driver = {
.name = "qcom-apq8064-sata-phy",
- .owner = THIS_MODULE,
.of_match_table = qcom_apq8064_sata_phy_of_match,
}
};
diff --git a/drivers/phy/phy-qcom-ipq806x-sata.c b/drivers/phy/phy-qcom-ipq806x-sata.c
index 909b5a8..759b0bf 100644
--- a/drivers/phy/phy-qcom-ipq806x-sata.c
+++ b/drivers/phy/phy-qcom-ipq806x-sata.c
@@ -201,7 +201,6 @@ static struct platform_driver qcom_ipq806x_sata_phy_driver = {
.remove = qcom_ipq806x_sata_phy_remove,
.driver = {
.name = "qcom-ipq806x-sata-phy",
- .owner = THIS_MODULE,
.of_match_table = qcom_ipq806x_sata_phy_of_match,
}
};
diff --git a/drivers/phy/phy-samsung-usb2.c b/drivers/phy/phy-samsung-usb2.c
index 3732ca2..908949d 100644
--- a/drivers/phy/phy-samsung-usb2.c
+++ b/drivers/phy/phy-samsung-usb2.c
@@ -231,7 +231,6 @@ static struct platform_driver samsung_usb2_phy_driver = {
.driver = {
.of_match_table = samsung_usb2_phy_of_match,
.name = "samsung-usb2-phy",
- .owner = THIS_MODULE,
}
};
diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
index 61ebea4..0baf5ef 100644
--- a/drivers/phy/phy-sun4i-usb.c
+++ b/drivers/phy/phy-sun4i-usb.c
@@ -325,7 +325,6 @@ static struct platform_driver sun4i_usb_phy_driver = {
.driver = {
.of_match_table = sun4i_usb_phy_of_match,
.name = "sun4i-usb-phy",
- .owner = THIS_MODULE,
}
};
module_platform_driver(sun4i_usb_phy_driver);
diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
index 9280ef8..ab1e22d 100644
--- a/drivers/phy/phy-ti-pipe3.c
+++ b/drivers/phy/phy-ti-pipe3.c
@@ -518,7 +518,6 @@ static struct platform_driver ti_pipe3_driver = {
.remove = ti_pipe3_remove,
.driver = {
.name = "ti-pipe3",
- .owner = THIS_MODULE,
.pm = DEV_PM_OPS,
.of_match_table = of_match_ptr(ti_pipe3_id_table),
},
diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
index e1a6623..191a34c 100644
--- a/drivers/phy/phy-twl4030-usb.c
+++ b/drivers/phy/phy-twl4030-usb.c
@@ -792,7 +792,6 @@ static struct platform_driver twl4030_usb_driver = {
.remove = twl4030_usb_remove,
.driver = {
.name = "twl4030_usb",
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(twl4030_usb_id_table),
},
};
diff --git a/drivers/phy/phy-xgene.c b/drivers/phy/phy-xgene.c
index db809b9..f8a51b1 100644
--- a/drivers/phy/phy-xgene.c
+++ b/drivers/phy/phy-xgene.c
@@ -1738,7 +1738,6 @@ static struct platform_driver xgene_phy_driver = {
.probe = xgene_phy_probe,
.driver = {
.name = "xgene-phy",
- .owner = THIS_MODULE,
.of_match_table = xgene_phy_of_match,
},
};
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver
2014-08-15 12:40 ` [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver Peter Griffin
@ 2014-09-17 16:19 ` Kishon Vijay Abraham I
2014-09-17 19:04 ` Peter Griffin
0 siblings, 1 reply; 15+ messages in thread
From: Kishon Vijay Abraham I @ 2014-09-17 16:19 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Friday 15 August 2014 06:10 PM, Peter Griffin wrote:
> This patch removes the superflous .owner field for drivers which
> use the module_platform_driver or platform_driver_register api,
> as this is overriden in __platform_driver_register.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> drivers/phy/phy-bcm-kona-usb2.c | 1 -
> drivers/phy/phy-berlin-sata.c | 1 -
> drivers/phy/phy-exynos-dp-video.c | 1 -
> drivers/phy/phy-exynos-mipi-video.c | 1 -
> drivers/phy/phy-exynos5-usbdrd.c | 1 -
> drivers/phy/phy-exynos5250-sata.c | 1 -
> drivers/phy/phy-hix5hd2-sata.c | 1 -
> drivers/phy/phy-miphy365x.c | 1 -
> drivers/phy/phy-mvebu-sata.c | 1 -
> drivers/phy/phy-omap-control.c | 1 -
> drivers/phy/phy-omap-usb2.c | 1 -
> drivers/phy/phy-qcom-apq8064-sata.c | 1 -
> drivers/phy/phy-qcom-ipq806x-sata.c | 1 -
> drivers/phy/phy-samsung-usb2.c | 1 -
> drivers/phy/phy-sun4i-usb.c | 1 -
> drivers/phy/phy-ti-pipe3.c | 1 -
> drivers/phy/phy-twl4030-usb.c | 1 -
twl4030-usb doesn't use module_platform_driver. Care to resend this patch
along? I've merged all other patches in this series.
Cheers
Kishon
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver
2014-09-17 16:19 ` Kishon Vijay Abraham I
@ 2014-09-17 19:04 ` Peter Griffin
2014-09-18 5:32 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 15+ messages in thread
From: Peter Griffin @ 2014-09-17 19:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kishon,
On Wed, 17 Sep 2014, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Friday 15 August 2014 06:10 PM, Peter Griffin wrote:
> > This patch removes the superflous .owner field for drivers which
> > use the module_platform_driver or platform_driver_register api,
> > as this is overriden in __platform_driver_register.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
<snip>
> > drivers/phy/phy-twl4030-usb.c | 1 -
>
> twl4030-usb doesn't use module_platform_driver. Care to resend this patch
> along? I've merged all other patches in this series.
That is true, but it does use platform_driver_register whih overrides .owner.
So the patch is stil good I think (fyi see include/linux/platform_device.h).
regards,
Peter.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver
2014-09-17 19:04 ` Peter Griffin
@ 2014-09-18 5:32 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 15+ messages in thread
From: Kishon Vijay Abraham I @ 2014-09-18 5:32 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 18 September 2014 12:34 AM, Peter Griffin wrote:
> Hi Kishon,
>
> On Wed, 17 Sep 2014, Kishon Vijay Abraham I wrote:
>
>> Hi,
>>
>> On Friday 15 August 2014 06:10 PM, Peter Griffin wrote:
>>> This patch removes the superflous .owner field for drivers which
>>> use the module_platform_driver or platform_driver_register api,
>>> as this is overriden in __platform_driver_register.
>>>
>>> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>
> <snip>
>>> drivers/phy/phy-twl4030-usb.c | 1 -
>>
>> twl4030-usb doesn't use module_platform_driver. Care to resend this patch
>> along? I've merged all other patches in this series.
>
> That is true, but it does use platform_driver_register whih overrides .owner.
> So the patch is stil good I think (fyi see include/linux/platform_device.h).
Indeed. Will merge this one.
Thanks
Kishon
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 8/9] phy: phy-spear1310-miphy: Use module_platform_driver to register driver.
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
` (6 preceding siblings ...)
2014-08-15 12:40 ` [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-08-15 12:40 ` [PATCH 9/9] phy: phy-spear1340-miphy: " Peter Griffin
2014-08-20 15:03 ` [PATCH 0/9] phy: various misc cleanups to phy drivers Kishon Vijay Abraham I
9 siblings, 0 replies; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
Use the module_platform_driver macro to register the driver as this gets
rid of a lot of the boilerplate code.
Also remove .owner field as this gets overridden in __platform_driver_register.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-spear1310-miphy.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c
index 911d25b..5f4c586 100644
--- a/drivers/phy/phy-spear1310-miphy.c
+++ b/drivers/phy/phy-spear1310-miphy.c
@@ -250,22 +250,11 @@ static struct platform_driver spear1310_miphy_driver = {
.probe = spear1310_miphy_probe,
.driver = {
.name = "spear1310-miphy",
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(spear1310_miphy_of_match),
},
};
-static int __init spear1310_miphy_phy_init(void)
-{
- return platform_driver_register(&spear1310_miphy_driver);
-}
-module_init(spear1310_miphy_phy_init);
-
-static void __exit spear1310_miphy_phy_exit(void)
-{
- platform_driver_unregister(&spear1310_miphy_driver);
-}
-module_exit(spear1310_miphy_phy_exit);
+module_platform_driver(spear1310_miphy_driver);
MODULE_DESCRIPTION("ST SPEAR1310-MIPHY driver");
MODULE_AUTHOR("Pratyush Anand <pratyush.anand@st.com>");
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 9/9] phy: phy-spear1340-miphy: Use module_platform_driver to register driver.
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
` (7 preceding siblings ...)
2014-08-15 12:40 ` [PATCH 8/9] phy: phy-spear1310-miphy: Use module_platform_driver to register driver Peter Griffin
@ 2014-08-15 12:40 ` Peter Griffin
2014-08-20 15:03 ` [PATCH 0/9] phy: various misc cleanups to phy drivers Kishon Vijay Abraham I
9 siblings, 0 replies; 15+ messages in thread
From: Peter Griffin @ 2014-08-15 12:40 UTC (permalink / raw)
To: linux-arm-kernel
Using the module_platform_driver macro to register the driver as this gets
rid of a lot of the boilerplate code.
Also remove .owner field as this gets overridden in __platform_driver_register.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/phy-spear1340-miphy.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c
index ee4d66f..1ecd094 100644
--- a/drivers/phy/phy-spear1340-miphy.c
+++ b/drivers/phy/phy-spear1340-miphy.c
@@ -282,23 +282,12 @@ static struct platform_driver spear1340_miphy_driver = {
.probe = spear1340_miphy_probe,
.driver = {
.name = "spear1340-miphy",
- .owner = THIS_MODULE,
.pm = &spear1340_miphy_pm_ops,
.of_match_table = of_match_ptr(spear1340_miphy_of_match),
},
};
-static int __init spear1340_miphy_phy_init(void)
-{
- return platform_driver_register(&spear1340_miphy_driver);
-}
-module_init(spear1340_miphy_phy_init);
-
-static void __exit spear1340_miphy_phy_exit(void)
-{
- platform_driver_unregister(&spear1340_miphy_driver);
-}
-module_exit(spear1340_miphy_phy_exit);
+module_platform_driver(spear1340_miphy_driver);
MODULE_DESCRIPTION("ST SPEAR1340-MIPHY driver");
MODULE_AUTHOR("Pratyush Anand <pratyush.anand@st.com>");
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 0/9] phy: various misc cleanups to phy drivers
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
` (8 preceding siblings ...)
2014-08-15 12:40 ` [PATCH 9/9] phy: phy-spear1340-miphy: " Peter Griffin
@ 2014-08-20 15:03 ` Kishon Vijay Abraham I
9 siblings, 0 replies; 15+ messages in thread
From: Kishon Vijay Abraham I @ 2014-08-20 15:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Friday 15 August 2014 06:10 PM, Peter Griffin wrote:
> Hi,
>
> This series some a few misc cleanups to the PHY drivers: -
>
> 1) Use module_platform_driver to register spear PHY drivers. This gets rid
> of a lof of boiler plate code.
>
> 2) Remove .owner field from drivers using module_platform_driver, as this gets
> overridden anyway in __platform_driver_register.
>
> 3) Remove OOM site specific failure messages. These are unecessary and make
> the kernel bigger.
>
> 4) Add missing kzalloc error check, which could avoid NULL ptr dereference.
Thanks for doing this clean-up.
But I can queue this only for 3.18 (since these are cleanups) after -rc4 is tagged.
Thanks
Kishon
>
> regards,
>
> Peter.
>
> Peter Griffin (9):
> phy: phy-omap-control: Remove unncessary site specific OOM messages
> phy: phy-mvebu-sata: Add missing error check for devm_kzalloc
> phy: phy-omap-usb2: Remove unncessary site specific OOM messages
> phy: phy-ti-pipe3: Remove unncessary site specific OOM messages
> phy: phy-spear1310-miphy: Remove unncessary site specific OOM messages
> phy: phy-spear1340-miphy: Remove unncessary site specific OOM messages
> phy: remove .owner field for drivers using module_platform_driver
> phy: phy-spear1310-miphy: Use module_platform_driver to register
> driver.
> phy: phy-spear1340-miphy: Use module_platform_driver to register
> driver.
>
> drivers/phy/phy-bcm-kona-usb2.c | 1 -
> drivers/phy/phy-berlin-sata.c | 1 -
> drivers/phy/phy-exynos-dp-video.c | 1 -
> drivers/phy/phy-exynos-mipi-video.c | 1 -
> drivers/phy/phy-exynos5-usbdrd.c | 1 -
> drivers/phy/phy-exynos5250-sata.c | 1 -
> drivers/phy/phy-hix5hd2-sata.c | 1 -
> drivers/phy/phy-miphy365x.c | 1 -
> drivers/phy/phy-mvebu-sata.c | 3 ++-
> drivers/phy/phy-omap-control.c | 5 +----
> drivers/phy/phy-omap-usb2.c | 9 ++-------
> drivers/phy/phy-qcom-apq8064-sata.c | 1 -
> drivers/phy/phy-qcom-ipq806x-sata.c | 1 -
> drivers/phy/phy-samsung-usb2.c | 1 -
> drivers/phy/phy-spear1310-miphy.c | 17 ++---------------
> drivers/phy/phy-spear1340-miphy.c | 17 ++---------------
> drivers/phy/phy-sun4i-usb.c | 1 -
> drivers/phy/phy-ti-pipe3.c | 6 ++----
> drivers/phy/phy-twl4030-usb.c | 1 -
> drivers/phy/phy-xgene.c | 1 -
> 20 files changed, 11 insertions(+), 60 deletions(-)
>
^ permalink raw reply [flat|nested] 15+ messages in thread