[PATCH] This adds a generic PWM framework driver for the PWM controller

jonsmirl at gmail.com
2014-08-19T12:11:40Z

On Mon, Aug 18, 2014 at 4:19 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Mon, Aug 18, 2014 at 03:53:08PM -0400, jonsmirl at gmail.com wrote:
>> On Mon, Aug 18, 2014 at 3:23 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > Hi,
>> >
>> > On Mon, Aug 18, 2014 at 02:03:16PM -0400, Jon Smirl wrote:
>> >> found on Allwinner SoCs.x
>> >>
>> >> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
>> >
>> > Is there any notable difference with Alexandre's driver?
>> > https://lkml.org/lkml/2014/5/19/568
>> >
>> > If so, why didn't you posted incremental patches on top of his driver?
>>
>> Better A10 support.
>
> Better how?
>
>> And I wrote this one without know about his.
>
> So you're just require us to trash an already extensively reviewed
> driver and start from scratch again?

Forget mine then.

Problems in the other one....
1) The math is not right in either patch. Selsinork has been checking
mine with a scope and just found another math error in mine. The
internal math needs to be done in picoseconds or round off errors mess
up the high frequency outputs (24Mhz, 12Mhz, 8Mhz, ...).
3) By-pass mode on the A20 is not implemented.
2) A10 is not correctly handled. Specifically the prescaler is
different on the A10 vs A20.

>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

--
Jon Smirl
jonsmirl at gmail.com