From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] imx-drm: imx-drm-core: add suspend/resume support
Date: Tue, 19 Aug 2014 15:21:24 +0800 [thread overview]
Message-ID: <20140819072122.GL2114@dragon> (raw)
In-Reply-To: <53F1FB9A.4070305@samsung.com>
On Mon, Aug 18, 2014 at 03:11:54PM +0200, Andrzej Hajda wrote:
> On 08/18/2014 02:58 PM, Andrzej Hajda wrote:
> > .load hook is called after all components are attached to the master.
> > So if suspend happen after probe of the master and before attaching the last
> > component you will have NULL here, I guess.
>
> Probably you can test it by disabling driver for one of drm components
> and putting board in sleep mode.
>
> Moreover I guess drvdata should be cleaned in .unload callback,
> otherwise if for some reason one of components will be detached and suspend
> happens drvdata will contain invalid pointer.
You're right, Andrzej. I will fix it in v3. Thanks for the comment.
Shawn
prev parent reply other threads:[~2014-08-19 7:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 6:20 [PATCH v2] imx-drm: imx-drm-core: add suspend/resume support Shawn Guo
2014-08-18 6:25 ` Shawn Guo
2014-08-19 8:08 ` Russell King - ARM Linux
2014-08-19 9:16 ` Greg KH
2014-08-19 9:42 ` Russell King - ARM Linux
2014-08-18 7:43 ` Andrzej Hajda
2014-08-18 12:38 ` Shawn Guo
2014-08-18 12:58 ` Andrzej Hajda
2014-08-18 13:11 ` Andrzej Hajda
2014-08-19 7:21 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819072122.GL2114@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).