From mboxrd@z Thu Jan 1 00:00:00 1970 From: balbi@ti.com (Felipe Balbi) Date: Thu, 21 Aug 2014 08:56:21 -0500 Subject: [PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation In-Reply-To: <20140821133340.GC17487@griffinp-ThinkPad-X1-Carbon-2nd> References: <1406734091-16202-1-git-send-email-peter.griffin@linaro.org> <1406734091-16202-3-git-send-email-peter.griffin@linaro.org> <20140820180005.GU24500@saruman.home> <20140821133340.GC17487@griffinp-ThinkPad-X1-Carbon-2nd> Message-ID: <20140821135620.GD9608@saruman.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 21, 2014 at 02:33:40PM +0100, Peter Griffin wrote: > Hi Felipe, > > Thanks for reviewing, see my comments below: - > > On Wed, 20 Aug 2014, Felipe Balbi wrote: > > > > + dwc3: dwc3 at 9900000 { > > > + compatible = "snps,dwc3"; > > > + reg = <0x09900000 0x100000>; > > > + interrupts = ; > > > + dr_mode = "host" > > > + usb-phy = <&usb3_phy>; > > > + phy-names = "usb2-phy"; > > > + phys = <&usb2_picophy2>; > > > > why are you using different binding for usb2 and usb3 phys ? Why can't > > you just: > > > > phys-names = "usb2-phy", "usb3-phy"; > > phys = <&usb2_picophy2>, <&usb3_phy>; > > > > ?? > > Currently (in the vendor tree) one of the phys lives in > drivers/usb/phy and the other in drivers/phy. > I believe that is because one is only a usb phy and the other is a > multi function phy which can drive PCI-E or USB3. right, but for mainline, we can have both PHYs in drivers/phy only. > So to make that work, when dwc3/core.c gets the PHYS in > dwc3_core_get_phy() we need to use the different bindings. > > I think we are the only platform using "one of each", but luckily > dwc3_core_get_phy() has been written generically enough that it "just > works" :-). true, but I want to drop support for the legacy drivers/usb/phy layer from dwc3. I'll try to move all PHYs to drivers/phy for v3.18. cheers -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: