From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/4] ARM: tegra: Add thermal trip points for Jetson TK1
Date: Thu, 21 Aug 2014 12:04:43 -0400 [thread overview]
Message-ID: <20140821160442.GB17621@developer> (raw)
In-Reply-To: <53F4FA80.9050103@wwwdotorg.org>
Stephen,
On Wed, Aug 20, 2014 at 01:44:00PM -0600, Stephen Warren wrote:
> On 08/06/2014 04:25 AM, Mikko Perttunen wrote:
> > This adds critical trip points to the Jetson TK1 device tree.
> > The device will do a controlled shutdown when either the CPU, GPU
> > or MEM thermal zone reaches 101 degrees Celsius.
>
> > diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
>
> > + thermal-zones {
> > + cpu {
> > + trips {
> ...
> > + };
> > + };
>
> thermal.txt states that a cooling-maps sub-node is mandatory. However,
> it seems to be missing here. Is the DT binding documentation overly
> strict, or do we need to add such a node here?
I believe the binding documentation is correct. I believe this driver
should still evolve a little bit to accomplish full thermal DT
description and include the cooling devices mapping.
All the best,
next prev parent reply other threads:[~2014-08-21 16:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 10:25 [PATCH v3 0/4] Tegra124 soctherm driver Mikko Perttunen
2014-08-06 10:25 ` [PATCH v3 1/4] of: Add bindings for nvidia,tegra124-soctherm Mikko Perttunen
2014-08-20 19:37 ` Stephen Warren
2014-08-06 10:25 ` [PATCH v3 2/4] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree Mikko Perttunen
2014-08-20 19:42 ` Stephen Warren
2014-08-06 10:25 ` [PATCH v3 3/4] ARM: tegra: Add thermal trip points for Jetson TK1 Mikko Perttunen
2014-08-20 19:44 ` Stephen Warren
2014-08-21 7:37 ` Mikko Perttunen
2014-08-21 16:04 ` Eduardo Valentin [this message]
2014-08-21 16:35 ` Stephen Warren
2014-08-06 10:25 ` [PATCH v3 4/4] thermal: Add Tegra SOCTHERM thermal management driver Mikko Perttunen
2014-08-11 13:32 ` Eduardo Valentin
2014-08-12 9:51 ` Mikko Perttunen
2014-08-15 11:00 ` [PATCH v4 " Mikko Perttunen
2014-08-19 14:09 ` Juha-Matti Tilli
2014-08-19 14:31 ` Mikko Perttunen
2014-08-19 14:33 ` edubezval at gmail.com
2014-08-19 15:27 ` Mikko Perttunen
2014-08-19 18:25 ` Juha-Matti Tilli
2014-08-19 18:25 ` Juha-Matti Tilli
2014-08-20 12:05 ` Juha-Matti Tilli
2014-08-20 19:50 ` [PATCH v3 " Stephen Warren
2014-08-21 7:39 ` Mikko Perttunen
2014-08-21 16:08 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821160442.GB17621@developer \
--to=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).