* [PATCH] arm: tegra: apalis/colibri t30: fix on-module 5v0 supplies
@ 2014-08-22 15:06 Marcel Ziswiler
2014-08-22 19:26 ` Stephen Warren
0 siblings, 1 reply; 4+ messages in thread
From: Marcel Ziswiler @ 2014-08-22 15:06 UTC (permalink / raw)
To: linux-arm-kernel
Working on Gigabit/PCIe support in U-Boot for Apalis T30 I realised
that the current device tree source includes for our modules only
happen to work due to referencing the on-carrier 5v0 supply from USB
which is not at all available on-module. The modules actually contain
TPS60150 charge pumps to generate the PMIC required 5 volts from the
one and only 3.3 volt module supply. This patch fixes this.
Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
---
arch/arm/boot/dts/tegra30-apalis.dtsi | 11 ++++++++++-
arch/arm/boot/dts/tegra30-colibri.dtsi | 11 ++++++++++-
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index 8adaa78..a5446cb 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -423,7 +423,7 @@
vcc4-supply = <&sys_3v3_reg>;
vcc5-supply = <&sys_3v3_reg>;
vcc6-supply = <&vio_reg>;
- vcc7-supply = <&sys_5v0_reg>;
+ vcc7-supply = <&charge_pump_5v0_reg>;
vccio-supply = <&sys_3v3_reg>;
regulators {
@@ -674,5 +674,14 @@
regulator-max-microvolt = <3300000>;
regulator-always-on;
};
+
+ charge_pump_5v0_reg: regulator at 101 {
+ compatible = "regulator-fixed";
+ reg = <101>;
+ regulator-name = "5v0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ };
};
};
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index bf16f8e..c4ed1be 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -201,7 +201,7 @@
vcc4-supply = <&sys_3v3_reg>;
vcc5-supply = <&sys_3v3_reg>;
vcc6-supply = <&vio_reg>;
- vcc7-supply = <&sys_5v0_reg>;
+ vcc7-supply = <&charge_pump_5v0_reg>;
vccio-supply = <&sys_3v3_reg>;
regulators {
@@ -373,5 +373,14 @@
regulator-max-microvolt = <3300000>;
regulator-always-on;
};
+
+ charge_pump_5v0_reg: regulator at 101 {
+ compatible = "regulator-fixed";
+ reg = <101>;
+ regulator-name = "5v0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ };
};
};
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: tegra: apalis/colibri t30: fix on-module 5v0 supplies
@ 2014-08-22 19:25 Stephen Warren
2014-08-24 18:21 ` Olof Johansson
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2014-08-22 19:25 UTC (permalink / raw)
To: linux-arm-kernel
From: Marcel Ziswiler <marcel@ziswiler.com>
Working on Gigabit/PCIe support in U-Boot for Apalis T30 I realised
that the current device tree source includes for our modules only
happen to work due to referencing the on-carrier 5v0 supply from USB
which is not at all available on-module. The modules actually contain
TPS60150 charge pumps to generate the PMIC required 5 volts from the
one and only 3.3 volt module supply. This patch fixes this.
(Note: When back-porting this to v3.16 stable releases, simply drop the
change to tegra30-apalis.dtsi; that file was added in v3.17)
Cc: <stable@vger.kernel.org> #v3.16+
Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
arch/arm/boot/dts/tegra30-apalis.dtsi | 11 ++++++++++-
arch/arm/boot/dts/tegra30-colibri.dtsi | 11 ++++++++++-
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index 8adaa7871dd3..a5446cba9804 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -423,7 +423,7 @@
vcc4-supply = <&sys_3v3_reg>;
vcc5-supply = <&sys_3v3_reg>;
vcc6-supply = <&vio_reg>;
- vcc7-supply = <&sys_5v0_reg>;
+ vcc7-supply = <&charge_pump_5v0_reg>;
vccio-supply = <&sys_3v3_reg>;
regulators {
@@ -674,5 +674,14 @@
regulator-max-microvolt = <3300000>;
regulator-always-on;
};
+
+ charge_pump_5v0_reg: regulator at 101 {
+ compatible = "regulator-fixed";
+ reg = <101>;
+ regulator-name = "5v0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ };
};
};
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index bf16f8e65627..c4ed1bec4d92 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -201,7 +201,7 @@
vcc4-supply = <&sys_3v3_reg>;
vcc5-supply = <&sys_3v3_reg>;
vcc6-supply = <&vio_reg>;
- vcc7-supply = <&sys_5v0_reg>;
+ vcc7-supply = <&charge_pump_5v0_reg>;
vccio-supply = <&sys_3v3_reg>;
regulators {
@@ -373,5 +373,14 @@
regulator-max-microvolt = <3300000>;
regulator-always-on;
};
+
+ charge_pump_5v0_reg: regulator at 101 {
+ compatible = "regulator-fixed";
+ reg = <101>;
+ regulator-name = "5v0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ };
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm: tegra: apalis/colibri t30: fix on-module 5v0 supplies
2014-08-22 15:06 [PATCH] arm: " Marcel Ziswiler
@ 2014-08-22 19:26 ` Stephen Warren
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2014-08-22 19:26 UTC (permalink / raw)
To: linux-arm-kernel
On 08/22/2014 09:06 AM, Marcel Ziswiler wrote:
> Working on Gigabit/PCIe support in U-Boot for Apalis T30 I realised
> that the current device tree source includes for our modules only
> happen to work due to referencing the on-carrier 5v0 supply from USB
> which is not at all available on-module. The modules actually contain
> TPS60150 charge pumps to generate the PMIC required 5 volts from the
> one and only 3.3 volt module supply. This patch fixes this.
I've forwarded this to the ARM SoC maintainers as a fix for v3.17.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: tegra: apalis/colibri t30: fix on-module 5v0 supplies
2014-08-22 19:25 [PATCH] ARM: tegra: apalis/colibri t30: fix on-module 5v0 supplies Stephen Warren
@ 2014-08-24 18:21 ` Olof Johansson
0 siblings, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2014-08-24 18:21 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 22, 2014 at 01:25:10PM -0600, Stephen Warren wrote:
> From: Marcel Ziswiler <marcel@ziswiler.com>
>
> Working on Gigabit/PCIe support in U-Boot for Apalis T30 I realised
> that the current device tree source includes for our modules only
> happen to work due to referencing the on-carrier 5v0 supply from USB
> which is not at all available on-module. The modules actually contain
> TPS60150 charge pumps to generate the PMIC required 5 volts from the
> one and only 3.3 volt module supply. This patch fixes this.
>
> (Note: When back-porting this to v3.16 stable releases, simply drop the
> change to tegra30-apalis.dtsi; that file was added in v3.17)
>
> Cc: <stable@vger.kernel.org> #v3.16+
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Applied, thanks.
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-24 18:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 19:25 [PATCH] ARM: tegra: apalis/colibri t30: fix on-module 5v0 supplies Stephen Warren
2014-08-24 18:21 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2014-08-22 15:06 [PATCH] arm: " Marcel Ziswiler
2014-08-22 19:26 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).