[PATCH] watchdog: imx2_wdt: Remove seperate big endian handling

[PATCH] watchdog: imx2_wdt: Remove seperate big endian handling

[Markus Pargmann]

3.18 will contain a patch that handles endianess within the regmap
framework. It does not need any parsing of DT properties within the
driver, so we can savely remove it here.
The required mainline patch is
	(regmap: add DT endianness binding support.)

Cc: Xiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
Hi,

This is the topic branch with the patches which replace the functionality of
this code.
https://git.kernel.org/cgit/linux/kernel/git/broonie/regmap.git/log/?h=topic/dt-endian

Best regards,

Markus


 drivers/watchdog/imx2_wdt.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
index 68c3d379ffa8..9d4874f09948 100644
--- a/drivers/watchdog/imx2_wdt.c
+++ b/drivers/watchdog/imx2_wdt.c
@@ -28,7 +28,6 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
-#include <linux/of_address.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/timer.h>
@@ -191,12 +190,10 @@ static struct regmap_config imx2_wdt_regmap_config = {
 
 static int __init imx2_wdt_probe(struct platform_device *pdev)
 {
-	struct device_node *np = pdev->dev.of_node;
 	struct imx2_wdt_device *wdev;
 	struct watchdog_device *wdog;
 	struct resource *res;
 	void __iomem *base;
-	bool big_endian;
 	int ret;
 	u32 val;
 
@@ -204,10 +201,6 @@ static int __init imx2_wdt_probe(struct platform_device *pdev)
 	if (!wdev)
 		return -ENOMEM;
 
-	big_endian = of_property_read_bool(np, "big-endian");
-	if (big_endian)
-		imx2_wdt_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
-
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(base))
-- 
2.1.0.rc1

[PATCH] watchdog: imx2_wdt: Remove seperate big endian handling

[Li.Xiubo at freescale.com]

Hi Markus,

Thanks for your work.

And there has already one patch for this:

"watchdog: imx2_wdt: Convert to use regmap framework's endianness method."

Thanks,

BRs
Xiubo



> -----Original Message-----
> From: Markus Pargmann [mailto:mpa at pengutronix.de]
> Sent: Monday, August 25, 2014 2:44 PM
> To: Wim Van Sebroeck
> Cc: linux-watchdog at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> kernel at pengutronix.de; Markus Pargmann; Xiubo Li-B47053
> Subject: [PATCH] watchdog: imx2_wdt: Remove seperate big endian handling
> 
> 3.18 will contain a patch that handles endianess within the regmap
> framework. It does not need any parsing of DT properties within the
> driver, so we can savely remove it here.
> The required mainline patch is
> 	(regmap: add DT endianness binding support.)
> 
> Cc: Xiubo Li <Li.Xiubo@freescale.com>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> Hi,
> 
> This is the topic branch with the patches which replace the functionality of
> this code.
> https://git.kernel.org/cgit/linux/kernel/git/broonie/regmap.git/log/?h=topic/d
> t-endian
> 
> Best regards,
> 
> Markus
> 
> 
>  drivers/watchdog/imx2_wdt.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> index 68c3d379ffa8..9d4874f09948 100644
> --- a/drivers/watchdog/imx2_wdt.c
> +++ b/drivers/watchdog/imx2_wdt.c
> @@ -28,7 +28,6 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
> -#include <linux/of_address.h>
>  #include <linux/platform_device.h>
>  #include <linux/regmap.h>
>  #include <linux/timer.h>
> @@ -191,12 +190,10 @@ static struct regmap_config imx2_wdt_regmap_config = {
> 
>  static int __init imx2_wdt_probe(struct platform_device *pdev)
>  {
> -	struct device_node *np = pdev->dev.of_node;
>  	struct imx2_wdt_device *wdev;
>  	struct watchdog_device *wdog;
>  	struct resource *res;
>  	void __iomem *base;
> -	bool big_endian;
>  	int ret;
>  	u32 val;
> 
> @@ -204,10 +201,6 @@ static int __init imx2_wdt_probe(struct platform_device
> *pdev)
>  	if (!wdev)
>  		return -ENOMEM;
> 
> -	big_endian = of_property_read_bool(np, "big-endian");
> -	if (big_endian)
> -		imx2_wdt_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
> -
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	base = devm_ioremap_resource(&pdev->dev, res);
>  	if (IS_ERR(base))
> --
> 2.1.0.rc1

[PATCH] watchdog: imx2_wdt: Remove seperate big endian handling

[Markus Pargmann]

Hi Xiubo,

On Mon, Aug 25, 2014 at 07:01:57AM +0000, Li.Xiubo at freescale.com wrote:
> Hi Markus,
> 
> Thanks for your work.
> 
> And there has already one patch for this:
> 
> "watchdog: imx2_wdt: Convert to use regmap framework's endianness method."

Thanks didn't see this one.

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140825/9e17bf43/attachment.sig>

[PATCH] watchdog: imx2_wdt: Remove seperate big endian handling

[Li.Xiubo at freescale.com]

> On Mon, Aug 25, 2014 at 07:01:57AM +0000, Li.Xiubo at freescale.com wrote:
> > Hi Markus,
> >
> > Thanks for your work.
> >
> > And there has already one patch for this:
> >
> > "watchdog: imx2_wdt: Convert to use regmap framework's endianness method."
> 
> Thanks didn't see this one.
> 
> Best regards,
> 
> Markus
> 

I also hoping for your comments about it if there has any problem.

Thanks very much,

BRs
Xiubo

[PATCH] watchdog: imx2_wdt: Remove seperate big endian handling

[Markus Pargmann]

On Mon, Aug 25, 2014 at 07:11:36AM +0000, Li.Xiubo at freescale.com wrote:
> > On Mon, Aug 25, 2014 at 07:01:57AM +0000, Li.Xiubo at freescale.com wrote:
> > > Hi Markus,
> > >
> > > Thanks for your work.
> > >
> > > And there has already one patch for this:
> > >
> > > "watchdog: imx2_wdt: Convert to use regmap framework's endianness method."
> > 
> > Thanks didn't see this one.
> > 
> > Best regards,
> > 
> > Markus
> > 
> 
> I also hoping for your comments about it if there has any problem.

I just noticed that you added an include of of_address.h in your
original patch:
f728f4bfc495 (watchdog: imx2_wdt: adds big endianness support.)

But you don't remove the include in your current patch. Was the include
missing in the driver?

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140825/67a5ccd9/attachment-0001.sig>

[PATCH] watchdog: imx2_wdt: Remove seperate big endian handling

[Li.Xiubo at freescale.com]

> > > > "watchdog: imx2_wdt: Convert to use regmap framework's endianness
> method."
> > >
> > > Thanks didn't see this one.
> > >
> > > Best regards,
> > >
> > > Markus
> > >
> >
> > I also hoping for your comments about it if there has any problem.
> 
> I just noticed that you added an include of of_address.h in your
> original patch:
> f728f4bfc495 (watchdog: imx2_wdt: adds big endianness support.)
> 
> But you don't remove the include in your current patch. Was the include
> missing in the driver?
> 

No, 

Well, if it does matter here, I will send another version to remove this.


Thanks,

BRs
Xiubo