From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] watchdog: imx2_wdt: Remove seperate big endian handling
Date: Mon, 25 Aug 2014 09:24:55 +0200 [thread overview]
Message-ID: <20140825072455.GB11914@pengutronix.de> (raw)
In-Reply-To: <5d35f7c722e14022ba7db0221b9cfdb1@BY2PR0301MB0613.namprd03.prod.outlook.com>
On Mon, Aug 25, 2014 at 07:11:36AM +0000, Li.Xiubo at freescale.com wrote:
> > On Mon, Aug 25, 2014 at 07:01:57AM +0000, Li.Xiubo at freescale.com wrote:
> > > Hi Markus,
> > >
> > > Thanks for your work.
> > >
> > > And there has already one patch for this:
> > >
> > > "watchdog: imx2_wdt: Convert to use regmap framework's endianness method."
> >
> > Thanks didn't see this one.
> >
> > Best regards,
> >
> > Markus
> >
>
> I also hoping for your comments about it if there has any problem.
I just noticed that you added an include of of_address.h in your
original patch:
f728f4bfc495 (watchdog: imx2_wdt: adds big endianness support.)
But you don't remove the include in your current patch. Was the include
missing in the driver?
Best regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140825/67a5ccd9/attachment-0001.sig>
next prev parent reply other threads:[~2014-08-25 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 6:43 [PATCH] watchdog: imx2_wdt: Remove seperate big endian handling Markus Pargmann
2014-08-25 7:01 ` Li.Xiubo at freescale.com
2014-08-25 7:05 ` Markus Pargmann
2014-08-25 7:11 ` Li.Xiubo at freescale.com
2014-08-25 7:24 ` Markus Pargmann [this message]
2014-08-25 7:32 ` Li.Xiubo at freescale.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825072455.GB11914@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox