From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 2/2] arm64: Add CONFIG_DEBUG_SET_MODULE_RONX support
Date: Tue, 26 Aug 2014 15:40:23 +0100 [thread overview]
Message-ID: <20140826144023.GA22256@localhost> (raw)
In-Reply-To: <1408477303-2640-3-git-send-email-lauraa@codeaurora.org>
On Tue, Aug 19, 2014 at 08:41:43PM +0100, Laura Abbott wrote:
> --- /dev/null
> +++ b/arch/arm64/mm/pageattr.c
[...]
> +static int change_memory_common(unsigned long addr, int numpages,
> + pgprot_t set_mask, pgprot_t clear_mask)
> +{
> + unsigned long start = addr;
> + unsigned long size = PAGE_SIZE*numpages;
> + unsigned long end = start + size;
> + int ret;
> + struct page_change_data data;
> +
> + if (!IS_ALIGNED(addr, PAGE_SIZE)) {
> + addr &= PAGE_MASK;
> + WARN_ON_ONCE(1);
> + }
> +
> + if (!is_module_address(start) || !is_module_address(end))
> + return -EINVAL;
Minor thing, "end" is exclusive here. Do you still get the right check
with is_module_address(end)?
--
Catalin
next prev parent reply other threads:[~2014-08-26 14:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 19:41 [PATCHv4 0/2] arm64 CONFIG_DEBUG_SET_MODULE_RONX support Laura Abbott
2014-08-19 19:41 ` [PATCHv4 1/2] arm64: Introduce {set,clear}_pte_bit Laura Abbott
2014-08-26 14:27 ` Catalin Marinas
2014-08-26 20:15 ` Laura Abbott
2014-08-27 8:07 ` Will Deacon
2014-09-01 15:42 ` Laura Abbott
2014-08-19 19:41 ` [PATCHv4 2/2] arm64: Add CONFIG_DEBUG_SET_MODULE_RONX support Laura Abbott
2014-08-26 14:40 ` Catalin Marinas [this message]
2014-09-01 15:42 ` Laura Abbott
2014-09-01 15:45 ` Will Deacon
2014-09-10 3:58 ` Zi Shen Lim
2014-09-10 8:47 ` Will Deacon
2014-09-11 4:42 ` Laura Abbott
2014-09-11 22:10 ` [PATCH] arm64: pageattr: Correctly adjust unaligned start addresses Laura Abbott
2014-09-12 3:40 ` Z Lim
2014-09-12 15:36 ` Catalin Marinas
2014-08-22 17:36 ` [PATCHv4 0/2] arm64 CONFIG_DEBUG_SET_MODULE_RONX support Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826144023.GA22256@localhost \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).