From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 3/3] ahci_xgene: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver.
Date: Tue, 26 Aug 2014 11:29:48 -0400 [thread overview]
Message-ID: <20140826152948.GC29286@htj.dyndns.org> (raw)
In-Reply-To: <CAOHikRDpLBAnH4pmFzfu_RXFUZNAWPc-Q34zS1_Mx-odOmXonA@mail.gmail.com>
On Tue, Aug 26, 2014 at 12:17:35PM +0530, Suman Tripathi wrote:
> Didn't I ask you to update the comment to explain what's going on?
> [suman] : can you specifically tell which part of the comment is not clear
> and need more explanation?
The comment on top of the function doesn't seem to match what's being
implemented. In addition, it's generally not very useful to list the
actual algorithm in text. Put algorithm in code and explain the
summary and rationales for it in the comments. Nothing explains why
the retries are being done.
> is the existing comment already sufficient?
> [suman] : The existing comment is sufficient .
No, this isn't. You don't have to include a novel to explain it but
there's something different going on here and you should provide
information on why this sort of deviation is necessary.
--
tejun
prev parent reply other threads:[~2014-08-26 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1408819047-17224-1-git-send-email-stripathi@apm.com>
[not found] ` <1408819047-17224-3-git-send-email-stripathi@apm.com>
2014-08-23 18:43 ` [PATCH v8 2/3] ahci_xgene: Skip the PHY and clock initialization if already configured by the firmware Sergei Shtylyov
[not found] ` <1408819047-17224-4-git-send-email-stripathi@apm.com>
2014-08-25 19:30 ` [PATCH v8 3/3] ahci_xgene: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver Tejun Heo
[not found] ` <CAOHikRDpLBAnH4pmFzfu_RXFUZNAWPc-Q34zS1_Mx-odOmXonA@mail.gmail.com>
2014-08-26 15:29 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826152948.GC29286@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).