linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] arm64: Remove unneeded extern keyword
Date: Tue, 26 Aug 2014 17:11:28 +0100	[thread overview]
Message-ID: <20140826161128.GE4078@leverpostej> (raw)
In-Reply-To: <1e9885b2581bae7e296b59411b26e03ba44a43e5.1408736066.git.geoff@infradead.org>

Hi Geoff,

On Fri, Aug 22, 2014 at 08:49:16PM +0100, Geoff Levand wrote:
> Function prototypes are never definitions, so remove any 'extern' keyword
> from the funcion prototypes in cpu_ops.h. Fixes warnings emited by
> checkpatch.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>

Looks sane to me:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/include/asm/cpu_ops.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/cpu_ops.h b/arch/arm64/include/asm/cpu_ops.h
> index d7b4b38..150ce63 100644
> --- a/arch/arm64/include/asm/cpu_ops.h
> +++ b/arch/arm64/include/asm/cpu_ops.h
> @@ -61,7 +61,7 @@ struct cpu_operations {
>  };
>  
>  extern const struct cpu_operations *cpu_ops[NR_CPUS];
> -extern int __init cpu_read_ops(struct device_node *dn, int cpu);
> -extern void __init cpu_read_bootcpu_ops(void);
> +int __init cpu_read_ops(struct device_node *dn, int cpu);
> +void __init cpu_read_bootcpu_ops(void);
>  
>  #endif /* ifndef __ASM_CPU_OPS_H */
> -- 
> 1.9.1
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

  reply	other threads:[~2014-08-26 16:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 19:49 [PATCH 0/9] arm64: minor fixups and enhancements Geoff Levand
2014-08-22 19:49 ` [PATCH 1/9] arm64: Fix efi kernel entry Geoff Levand
2014-08-26 15:55   ` Catalin Marinas
2014-08-26 16:19     ` Ard Biesheuvel
2014-08-26 18:42       ` Geoff Levand
2014-08-22 19:49 ` [PATCH 3/9] arm64: Remove unneeded extern keyword Geoff Levand
2014-08-26 16:11   ` Mark Rutland [this message]
2014-08-22 19:49 ` [PATCH 7/9] arm64: Add atomic macros to assembler.h Geoff Levand
2014-08-26 16:05   ` Catalin Marinas
2014-08-26 19:40     ` Geoff Levand
2014-08-27  8:25       ` Catalin Marinas
2014-08-22 19:49 ` [PATCH 4/9] arm64: Remove unused variable in head.S Geoff Levand
2014-08-27  8:40   ` Will Deacon
2014-08-22 19:49 ` [PATCH 2/9] arm64: Fix INVALID_HWID definition Geoff Levand
2014-08-26 15:57   ` Catalin Marinas
2014-08-26 18:18     ` Geoff Levand
2014-08-27  8:21       ` Catalin Marinas
2014-08-26 16:31   ` Mark Rutland
2014-08-26 17:38     ` Geoff Levand
2014-08-22 19:49 ` [PATCH 5/9] arm64: Fix include header order in vmlinux.lds.S Geoff Levand
2014-08-26 16:27   ` Mark Rutland
2014-08-26 19:27     ` Geoff Levand
2014-08-27  8:24       ` Catalin Marinas
2014-08-29 21:53         ` Geoff Levand
2014-08-22 19:49 ` [PATCH 6/9] arm64: Add new routine local_disable Geoff Levand
2014-08-26 16:04   ` Catalin Marinas
2014-08-26 16:23     ` Mark Rutland
2014-08-22 19:49 ` [PATCH 8/9] arm64: Add missing AT() macros to vmlinux.lds.S Geoff Levand
2014-08-26 16:08   ` Catalin Marinas
2014-08-26 19:33     ` Geoff Levand
2014-08-27  6:53       ` AKASHI Takahiro
2014-08-22 19:49 ` [PATCH 9/9] arm64: Add new cpu-return-addr device tree binding Geoff Levand
2014-08-27  8:30   ` Catalin Marinas
2014-08-29 21:45     ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140826161128.GE4078@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).