From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] watchdog: Add DA9063 PMIC watchdog driver.
Date: Wed, 27 Aug 2014 10:12:17 +0200 [thread overview]
Message-ID: <20140827081217.GD21770@pengutronix.de> (raw)
In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7D0B39787@SW-EX-MBX02.diasemi.com>
Hi Steve,
On Tue, Aug 26, 2014 at 03:21:53PM +0000, Opensource [Steve Twiss] wrote:
>
> On 26 August 2014 07:26, Markus Pargmann wrote
>
> > Subject: [PATCH v5] watchdog: Add DA9063 PMIC watchdog driver.
> >
>
> [...]
>
> > +
> > +static int da9063_wdt_stop(struct watchdog_device *wdd)
> > +{
> > + struct da9063_watchdog *wdt = watchdog_get_drvdata(wdd);
> > + int ret;
> > +
> > + mutex_lock(&wdt->lock);
> > + ret = regmap_update_bits(da9063->regmap, DA9063_REG_CONTROL_D,
> > + DA9063_TWDSCALE_MASK,
> > + DA9063_TWDSCALE_DISABLE);
> > + if (ret)
> > + dev_alert(wdt->da9063->dev, "Watchdog failed to stop (err = %d)\n",
> > + ret);
> > + mutex_unlock(&wdt->lock);
> > +
> > + return ret;
> > +}
> > +
>
> Hi Markus,
>
> A quick typo.
> ret = regmap_update_bits(da9063->regmap, DA9063_REG_CONTROL_D,
> should probably be wdt->da9063->regmap
yes, thank you. It seems I forgot to execute my checkpatch script before
sending. Sorry, will send a new version.
Best regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140827/30fdac58/attachment.sig>
next prev parent reply other threads:[~2014-08-27 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 6:26 [PATCH v5] watchdog: Add DA9063 PMIC watchdog driver Markus Pargmann
2014-08-26 15:21 ` Opensource [Steve Twiss]
2014-08-27 8:12 ` Markus Pargmann [this message]
2014-08-27 16:03 ` Opensource [Steve Twiss]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827081217.GD21770@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).