From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI
Date: Mon, 1 Sep 2014 18:14:51 +0100 [thread overview]
Message-ID: <20140901171451.GH608@arm.com> (raw)
In-Reply-To: <5404A821.5020207@arm.com>
On Mon, Sep 01, 2014 at 06:08:49PM +0100, Sudeep Holla wrote:
> On 01/09/14 17:58, Mark Brown wrote:
> > On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote:
> >
> >> Confused. Then how come smsc911x_drv_probe() has this line:
> >
> >> acpi_handle *ahandle = ACPI_HANDLE(&pdev->dev);
> >
> >> without any #ifdef's.
> >
> > There's a stub smsc911x_probe_config_acpi() provided in the non-ACPI
> > case, Arnd's suggestion is basically to remove the stub.
> >
>
> I think Catalin is referring to ACPI_HANDLE used without any #ifdefs
>
> Catalin, few macros like ACPI_HANDLE and ACPI_PTR are defined in
> include/linux/acpi.h even when CONFIG_ACPI is not set mainly to
> avoid #ifdef's around simple assignments like the above one and one
> in platform_driver.acpi_match_table
My comment was to Graeme who said that #ifdef's were needed because
acpi_handle (lowercase) was not defined in the !CONFIG_ACPI case.
However, further down in the patch it was used without any #ifdef's.
--
Catalin
next prev parent reply other threads:[~2014-09-01 17:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 15:05 [RFC PATCH for Juno 0/2] Drivers for Juno to boot from ACPI Hanjun Guo
2014-09-01 15:06 ` [RFC PATCH for Juno 1/2] net: smsc911x add support for probing " Hanjun Guo
2014-09-01 15:17 ` [Linaro-acpi] " Arnd Bergmann
2014-09-01 15:28 ` Graeme Gregory
2014-09-01 15:32 ` Arnd Bergmann
2014-09-01 16:53 ` Catalin Marinas
2014-09-01 16:58 ` Mark Brown
2014-09-01 17:08 ` Sudeep Holla
2014-09-01 17:14 ` Catalin Marinas [this message]
2014-09-01 17:33 ` Sudeep Holla
2014-09-01 17:03 ` Graeme Gregory
2014-09-15 4:08 ` Grant Likely
2014-09-15 9:24 ` Catalin Marinas
2014-09-01 17:04 ` Catalin Marinas
2014-09-01 17:11 ` Arnd Bergmann
2014-09-01 17:27 ` Catalin Marinas
2014-09-01 17:32 ` Graeme Gregory
2014-09-01 18:11 ` Mark Brown
2014-09-02 13:26 ` Catalin Marinas
2014-09-02 13:42 ` [Linaro-acpi] " Arnd Bergmann
2014-09-02 16:26 ` Mark Brown
2014-09-02 23:00 ` Rafael J. Wysocki
2014-09-03 15:09 ` Arnd Bergmann
2014-09-09 6:51 ` Jon Masters
2014-09-15 4:14 ` Grant Likely
2014-09-15 16:12 ` Mark Brown
2014-09-01 15:06 ` [RFC PATCH for Juno 2/2] tty: SBSA compatible UART Hanjun Guo
2014-09-01 15:26 ` Mark Brown
2014-09-01 17:12 ` Catalin Marinas
2014-09-01 17:18 ` Graeme Gregory
2014-09-01 17:29 ` Catalin Marinas
2014-09-01 15:29 ` [RFC PATCH for Juno 0/2] Drivers for Juno to boot from ACPI Arnd Bergmann
2014-09-09 6:55 ` Jon Masters
2014-09-09 10:55 ` Arnd Bergmann
2014-09-09 14:13 ` Jon Masters
2014-09-15 22:57 ` Grant Likely
2014-09-15 23:00 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901171451.GH608@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).