From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: imx6x-sdb: Add LCD support
Date: Tue, 2 Sep 2014 22:11:48 +0800 [thread overview]
Message-ID: <20140902141147.GL3135@dragon> (raw)
In-Reply-To: <CAOMZO5Ct0PiRViQkrQ24ZUCHmaC+UgY1rktmOH+4BY0s99yB-g@mail.gmail.com>
On Tue, Sep 02, 2014 at 11:01:06AM -0300, Fabio Estevam wrote:
> On Tue, Sep 2, 2014 at 10:50 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
>
> >> +&lcdif1 {
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_lcd>;
> >> + lcd-supply = <®_lcd_3v3>;
> >> + display = <&display0>;
> >> + status = "okay";
> >> +
> >> + display0: display {
> >
> > Shouldn't the node be named more specific, so that we do not run into
> > the kernel warning complaining duplicated property name?
>
> I do not see any warning here.
I'm not sure why you do not see it, but I do.
[ 0.037835] device-tree: Duplicate name in lcdif at 02220000, renamed to "display#1"
>
> It was on mx28 that I got the warning as it has "display: display".
I do not think the warning comes because of "display: display" but the
fact that lcdif node has a property named "display" and a child node
named "display" at the same time.
Shawn
>
> Last time on mx28 you asked me to look at mx6qdl-sabresd.dtsi for a
> reference, but display nodes there are inside the ldb node and do not
> have the "display: display", so not sure how to proceed.
>
> What do you suggest here?
next prev parent reply other threads:[~2014-09-02 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 17:50 [PATCH 1/2] ARM: dts: imx6sx: Add LCDIF compatible strings Fabio Estevam
2014-09-01 17:50 ` [PATCH 2/2] ARM: dts: imx6x-sdb: Add LCD support Fabio Estevam
2014-09-02 13:50 ` Shawn Guo
2014-09-02 14:01 ` Fabio Estevam
2014-09-02 14:11 ` Shawn Guo [this message]
2014-09-02 18:00 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902141147.GL3135@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).