* [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node @ 2014-09-02 10:52 Erik van Luijk 2014-09-02 16:33 ` Boris BREZILLON 2014-09-18 16:17 ` Nicolas Ferre 0 siblings, 2 replies; 5+ messages in thread From: Erik van Luijk @ 2014-09-02 10:52 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Erik van Luijk <evanluijk@interact.nl> --- arch/arm/boot/dts/at91sam9g45.dtsi | 7 +++++++ arch/arm/boot/dts/at91sam9m10g45ek.dts | 3 +++ 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi index 932a669..bf62c18 100644 --- a/arch/arm/boot/dts/at91sam9g45.dtsi +++ b/arch/arm/boot/dts/at91sam9g45.dtsi @@ -1070,6 +1070,13 @@ status = "disabled"; }; + rtc at fffffdb0 { + compatible = "atmel,at91rm9200-rtc"; + reg = <0xfffffdb0 0x30>; + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; + status = "disabled"; + }; + spi0: spi at fffa4000 { #address-cells = <1>; #size-cells = <0>; diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts index 96ccc7d..2dd2347 100644 --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts @@ -70,6 +70,9 @@ watchdog at fffffd40 { status = "okay"; + + rtc at fffffdb0 { + status = "okay"; }; mmc0: mmc at fff80000 { -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node 2014-09-02 10:52 [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node Erik van Luijk @ 2014-09-02 16:33 ` Boris BREZILLON 2014-09-03 6:09 ` Erik van Luijk 2014-09-18 16:17 ` Nicolas Ferre 1 sibling, 1 reply; 5+ messages in thread From: Boris BREZILLON @ 2014-09-02 16:33 UTC (permalink / raw) To: linux-arm-kernel Hi Erik, On Tue, 2 Sep 2014 12:52:12 +0200 Erik van Luijk <evanluijk@interact.nl> wrote: > Signed-off-by: Erik van Luijk <evanluijk@interact.nl> Except for the nitpicks you'll find below, you have my Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > arch/arm/boot/dts/at91sam9g45.dtsi | 7 +++++++ > arch/arm/boot/dts/at91sam9m10g45ek.dts | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi > index 932a669..bf62c18 100644 > --- a/arch/arm/boot/dts/at91sam9g45.dtsi > +++ b/arch/arm/boot/dts/at91sam9g45.dtsi > @@ -1070,6 +1070,13 @@ > status = "disabled"; > }; > > + rtc at fffffdb0 { > + compatible = "atmel,at91rm9200-rtc"; > + reg = <0xfffffdb0 0x30>; The RTC registers goes from 0xfffffdb0 to 0xfffffdc0, which means the size is 0x10 and not 0x30. This is not important here, because the following region is marked as reserved, but we prefer to keep the DT consistent with the datasheet. > + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + status = "disabled"; > + }; > + > spi0: spi at fffa4000 { > #address-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts > index 96ccc7d..2dd2347 100644 > --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts > +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts > @@ -70,6 +70,9 @@ > > watchdog at fffffd40 { > status = "okay"; > + > + rtc at fffffdb0 { > + status = "okay"; Try to keep SoC and board changes in distinct commits. > }; > > mmc0: mmc at fff80000 { Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node 2014-09-02 16:33 ` Boris BREZILLON @ 2014-09-03 6:09 ` Erik van Luijk 2014-09-03 7:09 ` Boris BREZILLON 0 siblings, 1 reply; 5+ messages in thread From: Erik van Luijk @ 2014-09-03 6:09 UTC (permalink / raw) To: linux-arm-kernel Hi Boris, Nicolas, Boris BREZILLON schreef op 2-9-2014 om 18:33: > Hi Erik, > > On Tue, 2 Sep 2014 12:52:12 +0200 > Erik van Luijk <evanluijk@interact.nl> wrote: > >> Signed-off-by: Erik van Luijk <evanluijk@interact.nl> > > Except for the nitpicks you'll find below, you have my > > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > >> --- >> arch/arm/boot/dts/at91sam9g45.dtsi | 7 +++++++ >> arch/arm/boot/dts/at91sam9m10g45ek.dts | 3 +++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi >> index 932a669..bf62c18 100644 >> --- a/arch/arm/boot/dts/at91sam9g45.dtsi >> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi >> @@ -1070,6 +1070,13 @@ >> status = "disabled"; >> }; >> >> + rtc at fffffdb0 { >> + compatible = "atmel,at91rm9200-rtc"; >> + reg = <0xfffffdb0 0x30>; > > The RTC registers goes from 0xfffffdb0 to 0xfffffdc0, which means the > size is 0x10 and not 0x30. This is not important here, because the > following region is marked as reserved, but we prefer to keep the DT > consistent with the datasheet. This is an inconsistency in the datasheet of the AT91SAM9G45 (and at least also AT91SAM9G15, AT91SAM9G25, AT91SAM9G35 and AT91SAM9M10). In the memory map (fig. 5-1) there is room for 16 bytes. But in the 'Real-time Clock (RTC) User Interface' (table 15-1) there is room for 48 bytes (0x30) excluding the Reserved Registers (which don't belong to the RTC on the AT91SAM9M10). Perhaps Nicolas can draw some attention to this at Atmel. > >> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; >> + status = "disabled"; >> + }; >> + >> spi0: spi at fffa4000 { >> #address-cells = <1>; >> #size-cells = <0>; >> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts >> index 96ccc7d..2dd2347 100644 >> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts >> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts >> @@ -70,6 +70,9 @@ >> >> watchdog at fffffd40 { >> status = "okay"; >> + >> + rtc at fffffdb0 { >> + status = "okay"; > > Try to keep SoC and board changes in distinct commits. Understood. > >> }; >> >> mmc0: mmc at fff80000 { > > > Best Regards, > > Boris > Regards, Erik ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node 2014-09-03 6:09 ` Erik van Luijk @ 2014-09-03 7:09 ` Boris BREZILLON 0 siblings, 0 replies; 5+ messages in thread From: Boris BREZILLON @ 2014-09-03 7:09 UTC (permalink / raw) To: linux-arm-kernel On Wed, 03 Sep 2014 08:09:28 +0200 Erik van Luijk <evanluijk@interact.nl> wrote: > > Hi Boris, Nicolas, > > Boris BREZILLON schreef op 2-9-2014 om 18:33: > > Hi Erik, > > > > On Tue, 2 Sep 2014 12:52:12 +0200 > > Erik van Luijk <evanluijk@interact.nl> wrote: > > > >> Signed-off-by: Erik van Luijk <evanluijk@interact.nl> > > > > Except for the nitpicks you'll find below, you have my > > > > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > >> --- > >> arch/arm/boot/dts/at91sam9g45.dtsi | 7 +++++++ > >> arch/arm/boot/dts/at91sam9m10g45ek.dts | 3 +++ > >> 2 files changed, 10 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi > b/arch/arm/boot/dts/at91sam9g45.dtsi > >> index 932a669..bf62c18 100644 > >> --- a/arch/arm/boot/dts/at91sam9g45.dtsi > >> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi > >> @@ -1070,6 +1070,13 @@ > >> status = "disabled"; > >> }; > >> > >> + rtc at fffffdb0 { > >> + compatible = "atmel,at91rm9200-rtc"; > >> + reg = <0xfffffdb0 0x30>; > > > > The RTC registers goes from 0xfffffdb0 to 0xfffffdc0, which means the > > size is 0x10 and not 0x30. This is not important here, because the > > following region is marked as reserved, but we prefer to keep the DT > > consistent with the datasheet. > > This is an inconsistency in the datasheet of the AT91SAM9G45 (and at > least also > AT91SAM9G15, AT91SAM9G25, AT91SAM9G35 and AT91SAM9M10). > In the memory map (fig. 5-1) there is room for 16 bytes. > But in the 'Real-time Clock (RTC) User Interface' (table 15-1) there is > room for > 48 bytes (0x30) excluding the Reserved Registers (which don't belong to > the RTC > on the AT91SAM9M10). Perhaps Nicolas can draw some attention to this at > Atmel. Indeed, I only had a look at the memory map. Given this input, you should keep your definition ;-). > > > > >> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > >> + status = "disabled"; > >> + }; > >> + > >> spi0: spi at fffa4000 { > >> #address-cells = <1>; > >> #size-cells = <0>; > >> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts > b/arch/arm/boot/dts/at91sam9m10g45ek.dts > >> index 96ccc7d..2dd2347 100644 > >> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts > >> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts > >> @@ -70,6 +70,9 @@ > >> > >> watchdog at fffffd40 { > >> status = "okay"; > >> + > >> + rtc at fffffdb0 { > >> + status = "okay"; > > > > Try to keep SoC and board changes in distinct commits. > > Understood. > > > > >> }; > >> > >> mmc0: mmc at fff80000 { > > > > > > Best Regards, > > > > Boris > > > > Regards, > > Erik -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node 2014-09-02 10:52 [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node Erik van Luijk 2014-09-02 16:33 ` Boris BREZILLON @ 2014-09-18 16:17 ` Nicolas Ferre 1 sibling, 0 replies; 5+ messages in thread From: Nicolas Ferre @ 2014-09-18 16:17 UTC (permalink / raw) To: linux-arm-kernel On 02/09/2014 12:52, Erik van Luijk : > Signed-off-by: Erik van Luijk <evanluijk@interact.nl> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> and added to the at91-3.18-dt3 branch. I also sent your remarks to the Documentation department in Atmel: thanks a lot for your help. > --- > arch/arm/boot/dts/at91sam9g45.dtsi | 7 +++++++ > arch/arm/boot/dts/at91sam9m10g45ek.dts | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi > index 932a669..bf62c18 100644 > --- a/arch/arm/boot/dts/at91sam9g45.dtsi > +++ b/arch/arm/boot/dts/at91sam9g45.dtsi > @@ -1070,6 +1070,13 @@ > status = "disabled"; > }; > > + rtc at fffffdb0 { > + compatible = "atmel,at91rm9200-rtc"; > + reg = <0xfffffdb0 0x30>; > + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + status = "disabled"; > + }; > + > spi0: spi at fffa4000 { > #address-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts > index 96ccc7d..2dd2347 100644 > --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts > +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts > @@ -70,6 +70,9 @@ > > watchdog at fffffd40 { > status = "okay"; BTW, there was an issue here: "};" missing.. I corrected it. > + > + rtc at fffffdb0 { > + status = "okay"; > }; > > mmc0: mmc at fff80000 { > -- Nicolas Ferre ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-18 16:17 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-02 10:52 [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node Erik van Luijk 2014-09-02 16:33 ` Boris BREZILLON 2014-09-03 6:09 ` Erik van Luijk 2014-09-03 7:09 ` Boris BREZILLON 2014-09-18 16:17 ` Nicolas Ferre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).