From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/8] power: reset: move hisilicon reboot code
Date: Sat, 6 Sep 2014 20:39:20 +0200 [thread overview]
Message-ID: <20140906183920.GA17047@earth.universe> (raw)
In-Reply-To: <1406551883-26154-6-git-send-email-haojian.zhuang@linaro.org>
Hi,
On Mon, Jul 28, 2014 at 08:51:20PM +0800, Haojian Zhuang wrote:
> Move reboot code from hisilicon platform driver into reset driver.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>
> [...]
> +static struct of_device_id hisi_reboot_of_match[] = {
> + { .compatible = "hisilicon,sysctrl" },
> + {}
> +};
> [...]
The patch looks fine, but it's missing DT Binding
documentation (see Documentation/devicetree/bindings).
Apart from that I suggest to change the compatible value
to something like "hisilicon,reset-sysctrl".
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140906/975b07f4/attachment.sig>
next prev parent reply other threads:[~2014-09-06 18:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 12:51 [PATCH v5 0/8] enable Hisilicon HIX5HD2 SoC Haojian Zhuang
2014-07-28 12:51 ` [PATCH v5 1/8] ARM: debug: Rename Hi3716 to HI5XHD2 Haojian Zhuang
2014-07-28 12:51 ` [PATCH v5 2/8] ARM: hisi: add ARCH_HISI Haojian Zhuang
2014-07-28 12:51 ` [PATCH v5 3/8] ARM: hisi: enable hix5hd2 SoC Haojian Zhuang
2014-07-28 12:51 ` [PATCH v5 4/8] ARM: dts: Add hix5hd2-dkb dts file Haojian Zhuang
2014-07-28 12:51 ` [PATCH v5 5/8] power: reset: move hisilicon reboot code Haojian Zhuang
2014-07-28 13:04 ` Arnd Bergmann
2014-09-06 18:39 ` Sebastian Reichel [this message]
2014-07-28 12:51 ` [PATCH v5 6/8] ARM: config: enable ARCH_HIX5HD2 Haojian Zhuang
2014-07-28 12:51 ` [PATCH v5 7/8] ARM: hisi: set l2 aux for pl310 Haojian Zhuang
2014-07-28 13:07 ` Arnd Bergmann
2014-07-28 13:41 ` [PATCH v6 " Haojian Zhuang
2014-07-28 12:51 ` [PATCH v5 8/8] ARM: hisi: remove smp from machine descriptor Haojian Zhuang
2014-07-28 13:08 ` Arnd Bergmann
2014-07-28 13:45 ` [PATCH v6 " Haojian Zhuang
2014-07-28 13:11 ` [PATCH v5 0/8] enable Hisilicon HIX5HD2 SoC Arnd Bergmann
2014-07-28 13:27 ` Haojian Zhuang
2014-07-29 6:40 ` Olof Johansson
2014-07-29 8:09 ` xuwei
2014-07-31 1:06 ` Olof Johansson
2014-07-31 1:51 ` Haojian Zhuang
2014-07-31 2:00 ` xuwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140906183920.GA17047@earth.universe \
--to=sre@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).