From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: PCI: Use PCI_CLASS_* defines for PCI class
Date: Mon, 8 Sep 2014 12:03:57 -0600 [thread overview]
Message-ID: <20140908180357.GA6159@obsidianresearch.com> (raw)
In-Reply-To: <CAErSpo7sOc72V3g5tOov8Yj4nKiuJupaUTKEEecHMcqEUrzh_g@mail.gmail.com>
On Mon, Sep 08, 2014 at 10:36:36AM -0600, Bjorn Helgaas wrote:
> Presumably these devices have PCI BARs (since that's how dev->resource
> got filled in), and we want to somehow ignore them, not assign
> resources to them, and not allow drivers to use whatever is mapped by
> the BARs. But clearing out the struct resources isn't really safe by
> itself. The hardware BAR still contains some value, and may still be
> enabled, which means that it may conflict with other devices.
I've seen this pattern before in the old mvebu stuff.
Essentially for that case the mvebu HW is a repurposed end port core,
so when working as a root port it presents an end port config space
(not a root port bridge config space). The BAR in that config space is
not relevant, so the old mvebu used code like this to hide it from the
PCI core. Otherwise the core will try to program it from the aperture,
and the default BAR size is really big, so it runs out of space.
Not sure if this is the same for this driver, but it looks very
similar..
Jason
next prev parent reply other threads:[~2014-09-08 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 8:05 [PATCH RESEND] ARM: PCI: Use PCI_CLASS_* defines for PCI class Rostislav Lisovy
2014-09-08 16:36 ` Bjorn Helgaas
2014-09-08 18:03 ` Jason Gunthorpe [this message]
2014-09-08 19:39 ` Bjorn Helgaas
2014-09-08 20:04 ` Jason Gunthorpe
2014-09-09 19:31 ` Bjorn Helgaas
2014-09-09 20:15 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908180357.GA6159@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).