linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/6] clk: Move all drivers to use internal API
Date: Mon, 08 Sep 2014 23:15:36 -0700	[thread overview]
Message-ID: <20140909061536.19023.90796@quantum> (raw)
In-Reply-To: <20140908061355.19023.47997@quantum>

Quoting Mike Turquette (2014-09-07 23:13:55)
> Quoting Tomeu Vizoso (2014-09-03 08:31:57)
> > In preparation to change the public API to return a per-user clk structure,
> > remove any usage of this public API from the clock implementations.
> > 
> > The reason for having this in a separate commit from the one that introduces
> > the implementation of the new functions is to separate the changes generated
> > with Coccinelle from the rest, and keep the patches' size reasonable.
> > 
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> > Tested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Tested-by: Heiko Stuebner <heiko@sntech.de>
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> Hi Tomeu,
> 
> Looks like the Coccinelle script had a false-positive.
> asm-generic/clkdev.h was converted from clk->clk_core and this blowed up
> clock drivers for architectures that don't provide an asm-specific
> clkdev.h implementation. This fixes x86's LPSS and a Microblaze driver.
> 
> I've rolled the following fix into your 2/9 patch. No action is
> necessary.
> 
> Regards,
> Mike
> 
> 
> 
> diff --git a/include/asm-generic/clkdev.h b/include/asm-generic/clkdev.h
> index 4320225..90a32a6 100644
> --- a/include/asm-generic/clkdev.h
> +++ b/include/asm-generic/clkdev.h
> @@ -15,10 +15,10 @@
> 
>  #include <linux/slab.h>
> 
> -struct clk_core;
> +struct clk;
> 
> -static inline int __clk_get(struct clk_core *clk) { return 1; }
> -static inline void __clk_put(struct clk_core *clk) { }
> +static inline int __clk_get(struct clk *clk) { return 1; }
> +static inline void __clk_put(struct clk *clk) { }
> 
>  static inline struct clk_lookup_alloc *__clkdev_alloc(size_t size)
>  {

Please disregard the above patch. I might have jumped the gun on this
one. I've posted an alternative (and hopefully correct) fix here:

http://lkml.kernel.org/r/<1410242868-14750-1-git-send-email-mturquette@linaro.org>

Regards,
Mike

  parent reply	other threads:[~2014-09-09  6:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03 15:29 [PATCH v9 0/6] Per-user clock constraints Tomeu Vizoso
2014-09-03 15:29 ` [PATCH v9 1/6] clk: Add temporary mapping to the existing API Tomeu Vizoso
     [not found]   ` <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com>
     [not found]     ` <20140908061355.19023.47997@quantum>
2014-09-09  6:15       ` Mike Turquette [this message]
2014-09-03 15:33 ` [PATCH v9 3/6] clk: use struct clk only for external API Tomeu Vizoso
2014-09-03 15:33   ` [PATCH v9 4/6] clk: per-user clock accounting for debug Tomeu Vizoso
2014-09-03 15:33   ` [PATCH v9 5/6] clk: Add floor and ceiling constraints to clock rates Tomeu Vizoso
2014-09-03 23:39     ` Stephen Boyd
2014-09-04  0:53       ` Mike Turquette
2014-09-04  8:53         ` Tomeu Vizoso
2014-09-04 13:34       ` Tomeu Vizoso
2014-09-03 15:33   ` [PATCH v9 6/6] clk: Warn of unbalanced clk_prepare() calls Tomeu Vizoso
2014-09-03 17:26 ` [PATCH v9 0/6] Per-user clock constraints Mike Turquette
2014-09-04  8:30   ` Tomeu Vizoso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140909061536.19023.90796@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).