* [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
@ 2014-09-10 1:33 Robin Gong
2014-09-10 3:21 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Robin Gong @ 2014-09-10 1:33 UTC (permalink / raw)
To: linux-arm-kernel
There is one weird data in rxfifo after one full rx/tx transfer
done sometimes. It looks a design issue and hard to workaround
totally, so disable dma functhion here. And will re-enable it
once the root cause found.
Signed-off-by: Robin Gong <b38343@freescale.com>
---
arch/arm/boot/dts/imx6dl.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi
index b453e0e..e84a1ff 100644
--- a/arch/arm/boot/dts/imx6dl.dtsi
+++ b/arch/arm/boot/dts/imx6dl.dtsi
@@ -102,6 +102,22 @@
};
};
+&ecspi1 {
+ dma-names = "", "";
+};
+
+&ecspi2 {
+ dma-names = "", "";
+};
+
+&ecspi3 {
+ dma-names = "", "";
+};
+
+&ecspi4 {
+ dma-names = "", "";
+};
+
&hdmi {
compatible = "fsl,imx6dl-hdmi";
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
2014-09-10 1:33 [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl Robin Gong
@ 2014-09-10 3:21 ` Shawn Guo
2014-09-10 5:16 ` Robin Gong
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2014-09-10 3:21 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 10, 2014 at 09:33:36AM +0800, Robin Gong wrote:
> There is one weird data in rxfifo after one full rx/tx transfer
> done sometimes. It looks a design issue and hard to workaround
> totally, so disable dma functhion here. And will re-enable it
> once the root cause found.
>
> Signed-off-by: Robin Gong <b38343@freescale.com>
> ---
> arch/arm/boot/dts/imx6dl.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi
> index b453e0e..e84a1ff 100644
> --- a/arch/arm/boot/dts/imx6dl.dtsi
> +++ b/arch/arm/boot/dts/imx6dl.dtsi
> @@ -102,6 +102,22 @@
> };
> };
>
> +&ecspi1 {
> + dma-names = "", "";
> +};
> +
> +&ecspi2 {
> + dma-names = "", "";
> +};
> +
> +&ecspi3 {
> + dma-names = "", "";
> +};
> +
> +&ecspi4 {
> + dma-names = "", "";
> +};
> +
This looks odd. Can we drop the dma properties from imx6qdl.dtsi,
and only add them in imx6q.dtsi instead?
Shawn
> &hdmi {
> compatible = "fsl,imx6dl-hdmi";
> };
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
2014-09-10 3:21 ` Shawn Guo
@ 2014-09-10 5:16 ` Robin Gong
0 siblings, 0 replies; 3+ messages in thread
From: Robin Gong @ 2014-09-10 5:16 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 10, 2014 at 11:21:30AM +0800, Shawn Guo wrote:
> On Wed, Sep 10, 2014 at 09:33:36AM +0800, Robin Gong wrote:
> > There is one weird data in rxfifo after one full rx/tx transfer
> > done sometimes. It looks a design issue and hard to workaround
> > totally, so disable dma functhion here. And will re-enable it
> > once the root cause found.
> >
> > Signed-off-by: Robin Gong <b38343@freescale.com>
> > ---
> > arch/arm/boot/dts/imx6dl.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi
> > index b453e0e..e84a1ff 100644
> > --- a/arch/arm/boot/dts/imx6dl.dtsi
> > +++ b/arch/arm/boot/dts/imx6dl.dtsi
> > @@ -102,6 +102,22 @@
> > };
> > };
> >
> > +&ecspi1 {
> > + dma-names = "", "";
> > +};
> > +
> > +&ecspi2 {
> > + dma-names = "", "";
> > +};
> > +
> > +&ecspi3 {
> > + dma-names = "", "";
> > +};
> > +
> > +&ecspi4 {
> > + dma-names = "", "";
> > +};
> > +
>
> This looks odd. Can we drop the dma properties from imx6qdl.dtsi,
> and only add them in imx6q.dtsi instead?
>
> Shawn
>
Ok, I'll send v2.
> > &hdmi {
> > compatible = "fsl,imx6dl-hdmi";
> > };
> > --
> > 1.9.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-10 5:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-10 1:33 [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl Robin Gong
2014-09-10 3:21 ` Shawn Guo
2014-09-10 5:16 ` Robin Gong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).