From: heikki.krogerus@linux.intel.com (Heikki Krogerus)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] acpi: lpss: convert from struct clk to struct clk_core
Date: Wed, 10 Sep 2014 08:30:56 +0300 [thread overview]
Message-ID: <20140910053056.GA30423@xps8300> (raw)
In-Reply-To: <20140909135209.GW13406@lahna.fi.intel.com>
On Tue, Sep 09, 2014 at 04:52:09PM +0300, Mika Westerberg wrote:
> On Tue, Sep 09, 2014 at 03:16:29PM +0200, Rafael J. Wysocki wrote:
> > On Monday, September 08, 2014 11:07:47 PM Mike Turquette wrote:
> > > Looks like this driver was missed during the original mass driver
> > > rework[0]. This patch converts the LPSS driver to the new clock provider
> > > data type (struct clk_core).
> > >
> > > If there are no objections I propose to roll this patch into a rebase of
> > > that patch[0] in my tree.
> > >
> > > [0] http://lkml.kernel.org/r/<1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com>
> > >
> > > Signed-off-by: Mike Turquette <mturquette@linaro.org>
> >
> > Mika, any comments here?
>
> Adding Heikki who recently did some clock changes to acpi_lpss.c.
>
> To me this looks fine.
Looks fine to me to.
> > > ---
> > > drivers/acpi/acpi_lpss.c | 6 +++---
> > > include/linux/platform_data/clk-lpss.h | 2 +-
> > > 2 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> > > index 9dfec48..454179f 100644
> > > --- a/drivers/acpi/acpi_lpss.c
> > > +++ b/drivers/acpi/acpi_lpss.c
> > > @@ -57,7 +57,7 @@ ACPI_MODULE_NAME("acpi_lpss");
> > > struct lpss_shared_clock {
> > > const char *name;
> > > unsigned long rate;
> > > - struct clk *clk;
> > > + struct clk_core *clk;
> > > };
> > >
> > > struct lpss_private_data;
> > > @@ -83,7 +83,7 @@ static struct lpss_device_desc lpss_dma_desc = {
> > > struct lpss_private_data {
> > > void __iomem *mmio_base;
> > > resource_size_t mmio_size;
> > > - struct clk *clk;
> > > + struct clk_core *clk;
> > > const struct lpss_device_desc *dev_desc;
> > > u32 prv_reg_ctx[LPSS_PRV_REG_COUNT];
> > > };
> > > @@ -278,7 +278,7 @@ static int register_device_clock(struct acpi_device *adev,
> > > const struct lpss_device_desc *dev_desc = pdata->dev_desc;
> > > struct lpss_shared_clock *shared_clock = dev_desc->shared_clock;
> > > const char *devname = dev_name(&adev->dev);
> > > - struct clk *clk = ERR_PTR(-ENODEV);
> > > + struct clk_core *clk = ERR_PTR(-ENODEV);
> > > struct lpss_clk_data *clk_data;
> > > const char *parent, *clk_name;
> > > void __iomem *prv_base;
> > > diff --git a/include/linux/platform_data/clk-lpss.h b/include/linux/platform_data/clk-lpss.h
> > > index 2390199..3c3237c 100644
> > > --- a/include/linux/platform_data/clk-lpss.h
> > > +++ b/include/linux/platform_data/clk-lpss.h
> > > @@ -15,7 +15,7 @@
> > >
> > > struct lpss_clk_data {
> > > const char *name;
> > > - struct clk *clk;
> > > + struct clk_core *clk;
> > > };
> > >
> > > extern int lpt_clk_init(void);
> > >
> >
> > --
> > I speak only for myself.
> > Rafael J. Wysocki, Intel Open Source Technology Center.
--
heikki
next prev parent reply other threads:[~2014-09-10 5:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 6:07 [PATCH 0/2] fixes for struct clk_core migration Mike Turquette
2014-09-09 6:07 ` [PATCH 1/2] acpi: lpss: convert from struct clk to struct clk_core Mike Turquette
2014-09-09 13:16 ` Rafael J. Wysocki
2014-09-09 13:52 ` Mika Westerberg
2014-09-10 5:30 ` Heikki Krogerus [this message]
2014-09-09 6:11 ` [PATCH 2/2] asm-generic: COMMON_CLK defines __clk_{get,put} Mike Turquette
2014-09-09 15:21 ` [PATCH 0/2] fixes for struct clk_core migration Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910053056.GA30423@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).