linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] arm64:mm: delete max_mapnr init.
Date: Thu, 11 Sep 2014 11:36:13 +0100	[thread overview]
Message-ID: <20140911103613.GB6158@arm.com> (raw)
In-Reply-To: <1410426973-32393-1-git-send-email-ganapatrao.kulkarni@caviumnetworks.com>

On Thu, Sep 11, 2014 at 10:16:13AM +0100, Ganapatrao Kulkarni wrote:
> setting max_mapnr results in to error, if enabled with CONFIG_NUMA,
> which i have to replace with function set_max_mapnr.
> However this variable is not used in arm64(with default defconfig) and better to
> delete instead.
> 
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com>
> ---
>  arch/arm64/mm/init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 5472c24..548bd01 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -256,7 +256,6 @@ static void __init free_unused_memmap(void)
>   */
>  void __init mem_init(void)
>  {
> -	max_mapnr   = pfn_to_page(max_pfn + PHYS_PFN_OFFSET) - mem_map;

I think it's cleaner to call set_max_mapnr in case this grows a use in core
code outside of pfn_valid (which we always override).

Will

  reply	other threads:[~2014-09-11 10:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  9:16 [RFC PATCH] arm64:mm: delete max_mapnr init Ganapatrao Kulkarni
2014-09-11 10:36 ` Will Deacon [this message]
2014-09-11 11:43   ` Ganapatrao Kulkarni
2014-09-11 12:13     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140911103613.GB6158@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).