* [RFC PATCH] arm64:mm: delete max_mapnr init.
@ 2014-09-11 9:16 Ganapatrao Kulkarni
2014-09-11 10:36 ` Will Deacon
0 siblings, 1 reply; 4+ messages in thread
From: Ganapatrao Kulkarni @ 2014-09-11 9:16 UTC (permalink / raw)
To: linux-arm-kernel
setting max_mapnr results in to error, if enabled with CONFIG_NUMA,
which i have to replace with function set_max_mapnr.
However this variable is not used in arm64(with default defconfig) and better to
delete instead.
Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com>
---
arch/arm64/mm/init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index 5472c24..548bd01 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -256,7 +256,6 @@ static void __init free_unused_memmap(void)
*/
void __init mem_init(void)
{
- max_mapnr = pfn_to_page(max_pfn + PHYS_PFN_OFFSET) - mem_map;
#ifndef CONFIG_SPARSEMEM_VMEMMAP
free_unused_memmap();
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [RFC PATCH] arm64:mm: delete max_mapnr init.
2014-09-11 9:16 [RFC PATCH] arm64:mm: delete max_mapnr init Ganapatrao Kulkarni
@ 2014-09-11 10:36 ` Will Deacon
2014-09-11 11:43 ` Ganapatrao Kulkarni
0 siblings, 1 reply; 4+ messages in thread
From: Will Deacon @ 2014-09-11 10:36 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 11, 2014 at 10:16:13AM +0100, Ganapatrao Kulkarni wrote:
> setting max_mapnr results in to error, if enabled with CONFIG_NUMA,
> which i have to replace with function set_max_mapnr.
> However this variable is not used in arm64(with default defconfig) and better to
> delete instead.
>
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com>
> ---
> arch/arm64/mm/init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 5472c24..548bd01 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -256,7 +256,6 @@ static void __init free_unused_memmap(void)
> */
> void __init mem_init(void)
> {
> - max_mapnr = pfn_to_page(max_pfn + PHYS_PFN_OFFSET) - mem_map;
I think it's cleaner to call set_max_mapnr in case this grows a use in core
code outside of pfn_valid (which we always override).
Will
^ permalink raw reply [flat|nested] 4+ messages in thread* [RFC PATCH] arm64:mm: delete max_mapnr init.
2014-09-11 10:36 ` Will Deacon
@ 2014-09-11 11:43 ` Ganapatrao Kulkarni
2014-09-11 12:13 ` Will Deacon
0 siblings, 1 reply; 4+ messages in thread
From: Ganapatrao Kulkarni @ 2014-09-11 11:43 UTC (permalink / raw)
To: linux-arm-kernel
Hi Will,
On Thu, Sep 11, 2014 at 4:06 PM, Will Deacon <will.deacon@arm.com> wrote:
> On Thu, Sep 11, 2014 at 10:16:13AM +0100, Ganapatrao Kulkarni wrote:
>> setting max_mapnr results in to error, if enabled with CONFIG_NUMA,
>> which i have to replace with function set_max_mapnr.
>> However this variable is not used in arm64(with default defconfig) and better to
>> delete instead.
>>
>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com>
>> ---
>> arch/arm64/mm/init.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index 5472c24..548bd01 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -256,7 +256,6 @@ static void __init free_unused_memmap(void)
>> */
>> void __init mem_init(void)
>> {
>> - max_mapnr = pfn_to_page(max_pfn + PHYS_PFN_OFFSET) - mem_map;
>
> I think it's cleaner to call set_max_mapnr in case this grows a use in core
> code outside of pfn_valid (which we always override).
agreed, thanks for your comment.
shall i send you the patch for this?
>
> Will
thanks
ganapat
^ permalink raw reply [flat|nested] 4+ messages in thread* [RFC PATCH] arm64:mm: delete max_mapnr init.
2014-09-11 11:43 ` Ganapatrao Kulkarni
@ 2014-09-11 12:13 ` Will Deacon
0 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2014-09-11 12:13 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 11, 2014 at 12:43:11PM +0100, Ganapatrao Kulkarni wrote:
> On Thu, Sep 11, 2014 at 4:06 PM, Will Deacon <will.deacon@arm.com> wrote:
> > On Thu, Sep 11, 2014 at 10:16:13AM +0100, Ganapatrao Kulkarni wrote:
> >> setting max_mapnr results in to error, if enabled with CONFIG_NUMA,
> >> which i have to replace with function set_max_mapnr.
> >> However this variable is not used in arm64(with default defconfig) and better to
> >> delete instead.
> >>
> >> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com>
> >> ---
> >> arch/arm64/mm/init.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> >> index 5472c24..548bd01 100644
> >> --- a/arch/arm64/mm/init.c
> >> +++ b/arch/arm64/mm/init.c
> >> @@ -256,7 +256,6 @@ static void __init free_unused_memmap(void)
> >> */
> >> void __init mem_init(void)
> >> {
> >> - max_mapnr = pfn_to_page(max_pfn + PHYS_PFN_OFFSET) - mem_map;
> >
> > I think it's cleaner to call set_max_mapnr in case this grows a use in core
> > code outside of pfn_valid (which we always override).
> agreed, thanks for your comment.
> shall i send you the patch for this?
Yes, please. Given that we don't support NUMA in mainline, the patch will be
queued for 3.18 (via Catalin).
Will
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-11 12:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-11 9:16 [RFC PATCH] arm64:mm: delete max_mapnr init Ganapatrao Kulkarni
2014-09-11 10:36 ` Will Deacon
2014-09-11 11:43 ` Ganapatrao Kulkarni
2014-09-11 12:13 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).