linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shijie8@gmail.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: gpmi: add proper raw access support
Date: Thu, 11 Sep 2014 20:09:30 +0800	[thread overview]
Message-ID: <20140911120928.GA1585@localhost.localdomain> (raw)
In-Reply-To: <1410339339-25561-1-git-send-email-boris.brezillon@free-electrons.com>

On Wed, Sep 10, 2014 at 10:55:39AM +0200, Boris BREZILLON wrote:
> Several MTD users (either in user or kernel space) expect a valid raw
> access support to NAND chip devices.
> This is particularly true for testing tools which are often touching the
> data stored in a NAND chip in raw mode to artificially generate errors.
> 
> The GPMI drivers do not implemenent raw access functions, and thus rely on
> default HW_ECC scheme implementation.
> The default implementation consider the data and OOB area as properly
> separated in their respective NAND section, which is not true for the GPMI
> controller.
> In this driver/controller some OOB data are stored at the beginning of the
> NAND data area (these data are called metadata in the driver), then ECC
> bytes are interleaved with data chunk (which is similar to the
> HW_ECC_SYNDROME scheme), and eventually the remaining bytes are used as
> OOB data.
> 
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> ---
> Hello,
> 
> This patch is providing raw access support to the GPMI driver which is
> particularly useful to run some tests on the NAND (the one coming in
> mind is the mtd_nandbiterrs testsuite).
> 
> I know this rework might break several user space tools which are relying
> on the default raw access implementation (I already experienced an issue
> with the kobs-ng tool provided by freescale), but many other tools will
> now work as expected.
If the kobs-ng can not works, there is no meaning that other tools
works.  So I do not think we need to implement these hooks. 

sorry, I will not Ack this patch.

thanks
Huang Shijie

  reply	other threads:[~2014-09-11 12:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  8:55 [PATCH] mtd: nand: gpmi: add proper raw access support Boris BREZILLON
2014-09-11 12:09 ` Huang Shijie [this message]
2014-09-11 12:36   ` Boris BREZILLON
2014-09-11 14:25     ` Huang Shijie
2014-09-11 14:38       ` Boris BREZILLON
2014-09-12  0:45         ` Huang Shijie
2014-09-12 12:30           ` Boris BREZILLON
2014-09-13 15:36             ` Huang Shijie
2014-09-13 17:38               ` Brian Norris
2014-09-14 14:07                 ` Boris BREZILLON
2014-09-15 14:43                 ` Huang Shijie
2014-09-15 20:12                   ` Boris BREZILLON
2014-09-17 15:26                     ` Huang Shijie
2014-09-17 18:16                       ` Boris BREZILLON
2014-09-29  1:22     ` Iwo Mergler
2014-09-30  8:04       ` Boris Brezillon
2014-10-02  6:52         ` Iwo Mergler
2014-09-11 14:29 ` Huang Shijie
2014-09-11 14:45   ` Boris BREZILLON
2014-09-12  0:40     ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140911120928.GA1585@localhost.localdomain \
    --to=shijie8@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).