From: shijie8@gmail.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: gpmi: add proper raw access support
Date: Thu, 11 Sep 2014 22:29:32 +0800 [thread overview]
Message-ID: <20140911142930.GB2543@localhost.localdomain> (raw)
In-Reply-To: <1410339339-25561-1-git-send-email-boris.brezillon@free-electrons.com>
On Wed, Sep 10, 2014 at 10:55:39AM +0200, Boris BREZILLON wrote:
+static int gpmi_ecc_read_page_raw(struct mtd_info *mtd,
> + struct nand_chip *chip, uint8_t *buf,
> + int oob_required, int page)
> +{
> + struct gpmi_nand_data *this = chip->priv;
> + struct bch_geometry *nfc_geo = &this->bch_geometry;
> + int eccsize = nfc_geo->ecc_chunk_size;
> + int eccbytes = DIV_ROUND_UP(nfc_geo->ecc_strength * nfc_geo->gf_len,
> + 8);
In actually, the ECC can be _NOT_ bytes aligned.
you should not round up to byte.
it's hard to implement this hook.
thanks
Huang Shijie
> + uint8_t *oob = chip->oob_poi;
> + int step;
> + int column = 0;
> + uint8_t *orig_buf = buf;
> +
> + chip->read_buf(mtd, oob, nfc_geo->metadata_size);
> + oob += nfc_geo->metadata_size;
> +
> + column += nfc_geo->metadata_size;
> + for (step = 0; step < nfc_geo->ecc_chunk_count; step++) {
> + chip->read_buf(mtd, buf, eccsize);
> + buf += eccsize;
> + column += eccsize;
> + chip->read_buf(mtd, oob, eccbytes);
> + oob += eccbytes;
> + column += eccbytes;
> + }
> +
> + if (column < mtd->writesize + mtd->oobsize)
> + chip->read_buf(mtd, oob,
> + mtd->writesize + mtd->oobsize - column);
> +
> + block_mark_swapping(this, orig_buf, chip->oob_poi);
> +
> + return 0;
> +}
next prev parent reply other threads:[~2014-09-11 14:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 8:55 [PATCH] mtd: nand: gpmi: add proper raw access support Boris BREZILLON
2014-09-11 12:09 ` Huang Shijie
2014-09-11 12:36 ` Boris BREZILLON
2014-09-11 14:25 ` Huang Shijie
2014-09-11 14:38 ` Boris BREZILLON
2014-09-12 0:45 ` Huang Shijie
2014-09-12 12:30 ` Boris BREZILLON
2014-09-13 15:36 ` Huang Shijie
2014-09-13 17:38 ` Brian Norris
2014-09-14 14:07 ` Boris BREZILLON
2014-09-15 14:43 ` Huang Shijie
2014-09-15 20:12 ` Boris BREZILLON
2014-09-17 15:26 ` Huang Shijie
2014-09-17 18:16 ` Boris BREZILLON
2014-09-29 1:22 ` Iwo Mergler
2014-09-30 8:04 ` Boris Brezillon
2014-10-02 6:52 ` Iwo Mergler
2014-09-11 14:29 ` Huang Shijie [this message]
2014-09-11 14:45 ` Boris BREZILLON
2014-09-12 0:40 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911142930.GB2543@localhost.localdomain \
--to=shijie8@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).