From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v9 5/5] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock
Date: Fri, 12 Sep 2014 15:13:34 -0700 [thread overview]
Message-ID: <20140912151334.cd53fca611a7de487f23241b@linux-foundation.org> (raw)
In-Reply-To: <1410509864-10019-6-git-send-email-javier.martinez@collabora.co.uk>
On Fri, 12 Sep 2014 10:17:43 +0200 Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote:
> The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
> This patch adds support for the RTC and is based on a driver
> added by Simon Glass to the Chrome OS kernel 3.8 tree.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Would it be appropriate to gather Simon's signoff?
> +static inline int max77802_rtc_calculate_wday(u8 shifted)
> +{
> + int counter = -1;
> +
> + while (shifted) {
> + shifted >>= 1;
> + counter++;
> + }
Can't use log2() or similar?
> + return counter;
> +}
next prev parent reply other threads:[~2014-09-12 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 8:17 [PATCH RESEND v9 0/5] Add Maxim 77802 RTC support Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas
2014-09-12 15:12 ` Doug Anderson
2014-09-12 15:54 ` Javier Martinez Canillas
2014-09-12 16:03 ` Doug Anderson
2014-09-12 22:05 ` Andrew Morton
2014-09-15 14:03 ` Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 2/5] rtc: max77686: Remove dead code for SMPL and WTSR Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 3/5] rtc: max77686: Fail to probe if no RTC regmap irqchip is set Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 4/5] rtc: max77686: Remove unneded info log Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 5/5] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas
2014-09-12 22:13 ` Andrew Morton [this message]
2014-09-15 14:07 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912151334.cd53fca611a7de487f23241b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox