From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.
Date: Sun, 14 Sep 2014 18:39:11 +0900 [thread overview]
Message-ID: <20140914093911.GB9028@mtj.dyndns.org> (raw)
In-Reply-To: <CAOHikRA8LiNkMuzqe-Kgrf4QWbJ_jpXRGHdf+rsrCmq6R0GjDg@mail.gmail.com>
Hello,
On Sun, Sep 14, 2014 at 11:36:51AM +0530, Suman Tripathi wrote:
> We can maintain same piece (IS_ERR(ctx->csr_mux)), then we can do the
> below instead of NULL ??
>
> ctx->csr_mux = res ? devm_ioremap_resource(dev, res) : ERR_PTR(-EINVAL);
Setting it to NULL on failure would probably make more sense. No need
to carry around ERR_PTR() value around.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-09-14 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1410508448-25111-1-git-send-email-stripathi@apm.com>
[not found] ` <1410508448-25111-2-git-send-email-stripathi@apm.com>
2014-09-12 17:50 ` [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver Tejun Heo
[not found] ` <CAOHikRA8LiNkMuzqe-Kgrf4QWbJ_jpXRGHdf+rsrCmq6R0GjDg@mail.gmail.com>
2014-09-14 9:39 ` Tejun Heo [this message]
[not found] ` <CAOHikRAFM-FETGGXroNV39Yi-jChMA-W37ufhiMx4O2WgWpxFg@mail.gmail.com>
[not found] ` <CAOHikRDdfKTxCXHGsywP+c8=1eLmMCf3fuC2pmH2WH-6ymHMAA@mail.gmail.com>
2014-09-15 7:44 ` Tejun Heo
2014-09-15 8:49 ` Russell King - ARM Linux
[not found] <1411390893-22911-1-git-send-email-stripathi@apm.com>
[not found] ` <1411390893-22911-2-git-send-email-stripathi@apm.com>
2014-09-23 14:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140914093911.GB9028@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).