From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] arm: Convert pr_warning to pr_warn
Date: Mon, 15 Sep 2014 16:56:56 +0100 [thread overview]
Message-ID: <20140915155656.GA29744@arm.com> (raw)
In-Reply-To: <7995478e8c658478cd37dabb996f7269405251ac.1410632835.git.joe@perches.com>
On Sat, Sep 13, 2014 at 07:31:12PM +0100, Joe Perches wrote:
> Use the more common pr_warn.
>
> Other miscellanea:
>
> o Coalesce formats
> o Realign arguments
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/include/asm/syscall.h | 8 ++++----
> arch/arm/kernel/atags_parse.c | 2 +-
> arch/arm/kernel/hw_breakpoint.c | 18 +++++++++---------
> arch/arm/kernel/irq.c | 4 ++--
> arch/arm/kernel/perf_event_cpu.c | 4 ++--
> arch/arm/kernel/smp.c | 2 +-
> arch/arm/kernel/unwind.c | 24 ++++++++++++------------
> arch/arm/mm/idmap.c | 2 +-
> arch/arm/mm/mmu.c | 4 ++--
> 9 files changed, 34 insertions(+), 34 deletions(-)
It's Russell's call on this, but it really looks like more trouble than it's
worth imo. Having git blame identify the person who wrote the original code
is considerably more useful than being pointed at somebody making cosmetic
changes.
Will
next prev parent reply other threads:[~2014-09-15 15:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 18:31 [PATCH 0/8] arm: Convert pr_warning to pr_warn Joe Perches
2014-09-13 18:31 ` [PATCH 1/8] " Joe Perches
2014-09-15 15:56 ` Will Deacon [this message]
2014-09-15 16:02 ` Joe Perches
2014-09-16 16:07 ` Russell King - ARM Linux
2014-09-16 16:18 ` Joe Perches
2014-09-16 19:24 ` Uwe Kleine-König
2014-09-16 19:57 ` Russell King - ARM Linux
2014-09-16 20:08 ` Joe Perches
2014-09-13 18:31 ` [PATCH 2/8] arm: mach-davinci: " Joe Perches
2014-09-13 18:31 ` [PATCH 3/8] arm: mach-ep93xx: " Joe Perches
2014-09-13 18:31 ` [PATCH 4/8] arm: mach-imx: " Joe Perches
2014-09-16 1:51 ` Shawn Guo
2014-09-13 18:31 ` [PATCH 5/8] arm: mach-omap2: " Joe Perches
2014-09-18 16:54 ` Tony Lindgren
2014-09-13 18:31 ` [PATCH 6/8] arm: mach-orion5x: " Joe Perches
2014-09-13 19:16 ` Andrew Lunn
2014-09-13 21:51 ` Jason Cooper
2014-09-13 18:31 ` [PATCH 7/8] arm: mach-pxa: " Joe Perches
2014-09-21 17:02 ` Robert Jarzmik
2014-09-13 18:31 ` [PATCH 8/8] arm: mach-u300: " Joe Perches
2014-09-23 15:10 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915155656.GA29744@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).