From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/12] ARM: omap2plus_defconfig: Add cpufreq to defconfig
Date: Thu, 18 Sep 2014 11:23:12 -0500 [thread overview]
Message-ID: <20140918162312.GA1245@kahuna> (raw)
In-Reply-To: <20140918162041.GF14505@atomide.com>
On 09:20-20140918, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140918 09:12]:
> > On 20:12-20140915, Tony Lindgren wrote:
> > > Note that we can now use the CONFIG_GENERIC_CPUFREQ_CPU0,
> > > so let's only enable that.
> > >
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > ---
> > > arch/arm/configs/omap2plus_defconfig | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > > index fc63855..9d232a5 100644
> > > --- a/arch/arm/configs/omap2plus_defconfig
> > > +++ b/arch/arm/configs/omap2plus_defconfig
> > > @@ -43,6 +43,13 @@ CONFIG_ARM_APPENDED_DTB=y
> > > CONFIG_ARM_ATAG_DTB_COMPAT=y
> > > CONFIG_CMDLINE="root=/dev/mmcblk0p2 rootwait console=ttyO2,115200"
> > > CONFIG_KEXEC=y
> > > +CONFIG_CPU_FREQ=y
> > > +CONFIG_CPU_FREQ_GOV_POWERSAVE=y
> > > +CONFIG_CPU_FREQ_GOV_USERSPACE=y
> > > +CONFIG_CPU_FREQ_GOV_ONDEMAND=y
> > > +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
> > > +CONFIG_GENERIC_CPUFREQ_CPU0=y
> > > +# CONFIG_ARM_OMAP2PLUS_CPUFREQ is not set
> >
> > With this
> > we get performace as the default governor.
> >
> > could we use CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND as the default
> > instead? on Many TI SoCs using Highest frequency is not really too nice
> > of an idea for long periods of time. And not everything is upstream to
> > support things optimially - example avs class 0, 1.5 ABB consolidation
> > with cpufreq etc.. We definitely need thermal enabled as well for device
> > safety needs.
>
> OK, sure. I've applied the following version with your changes folded
> in.
>
> Regards,
>
> Tony
>
> 8< ---------------
> From: Tony Lindgren <tony@atomide.com>
> Date: Thu, 18 Sep 2014 09:01:07 -0700
> Subject: [PATCH] ARM: omap2plus_defconfig: Add cpufreq to defconfig
>
> Note that we can now use the CONFIG_GENERIC_CPUFREQ_CPU0,
> so let's only enable that. Let's use CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND
> as suggested by Nishant.
>
> And also let's enable thermal as explained by Nishant Menon:
>
> Many TI SoCs using Highest frequency is not really too nice of an idea for
> long periods of time. And not everything is upstream to support things
> optimially - example avs class 0, 1.5 ABB consolidation with cpufreq etc..
> We definitely need thermal enabled as well for device safety needs.
>
> Cc: Nishanth Menon <nm@ti.com>
> [tony at atomide.com: updated per Nishant's suggestions]
> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -43,6 +43,14 @@ CONFIG_ARM_APPENDED_DTB=y
> CONFIG_ARM_ATAG_DTB_COMPAT=y
> CONFIG_CMDLINE="root=/dev/mmcblk0p2 rootwait console=ttyO2,115200"
> CONFIG_KEXEC=y
> +CONFIG_CPU_FREQ=y
> +CONFIG_CPU_FREQ_STAT_DETAILS=y
> +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
> +CONFIG_CPU_FREQ_GOV_POWERSAVE=y
> +CONFIG_CPU_FREQ_GOV_USERSPACE=y
> +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
> +CONFIG_GENERIC_CPUFREQ_CPU0=y
> +# CONFIG_ARM_OMAP2PLUS_CPUFREQ is not set
> CONFIG_CPU_IDLE=y
> CONFIG_BINFMT_MISC=y
> CONFIG_PM_DEBUG=y
> @@ -162,7 +170,9 @@ CONFIG_SENSORS_LM75=m
> CONFIG_THERMAL=y
> CONFIG_THERMAL_GOV_FAIR_SHARE=y
> CONFIG_THERMAL_GOV_USER_SPACE=y
> +CONFIG_CPU_THERMAL=y
> CONFIG_TI_SOC_THERMAL=y
> +CONFIG_TI_THERMAL=y
> CONFIG_OMAP4_THERMAL=y
> CONFIG_OMAP5_THERMAL=y
> CONFIG_DRA752_THERMAL=y
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-09-18 16:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 3:11 [PATCH 01/12] ARM: OMAP2+: Add hwmod flag for HWMOD_RECONFIG_IO_CHAIN Tony Lindgren
2014-09-16 3:11 ` [PATCH 02/12] ARM: OMAP3: Use force-idle for UARTs because of DMA errata Tony Lindgren
2014-09-16 17:00 ` Paul Walmsley
2014-09-16 17:44 ` Tony Lindgren
2014-09-17 16:46 ` Paul Walmsley
2014-09-16 3:11 ` [PATCH 03/12] ARM: dts: omap3-overo: Fix UART wake-up events Tony Lindgren
2014-09-16 3:11 ` [PATCH 04/12] ARM: dts: omap: Remove WAKEUPENABLE mux options for UARTs Tony Lindgren
2014-09-16 3:11 ` [PATCH 05/12] ARM: dts: Do not set pulls for I2C lines Tony Lindgren
2014-09-16 3:12 ` [PATCH 06/12] ARM: dts: Add support for Ethernet on some N900 macro boards Tony Lindgren
2014-09-16 3:12 ` [PATCH 07/12] ARM: dts: Enable PMIC idle configuration for LDP Tony Lindgren
2014-09-16 3:12 ` [PATCH 08/12] ARM: omap2plus_defconfig: Shrink with savedefconfig Tony Lindgren
2014-09-16 4:56 ` Felipe Balbi
2014-09-18 15:57 ` Tony Lindgren
2014-09-18 16:03 ` Felipe Balbi
2014-09-16 3:12 ` [PATCH 09/12] ARM: omap2plus_defconfig: Add cpufreq to defconfig Tony Lindgren
2014-09-18 16:11 ` Nishanth Menon
2014-09-18 16:20 ` Tony Lindgren
2014-09-18 16:23 ` Nishanth Menon [this message]
2014-09-16 3:12 ` [PATCH 10/12] ARM: omap2plus_defconfig: Add support for distros with systemd Tony Lindgren
2014-09-18 7:01 ` Javier Martinez Canillas
2014-09-16 3:12 ` [PATCH 11/12] ARM: omap2plus_defconfig: Enable battery and reset drivers Tony Lindgren
2014-09-16 3:12 ` [PATCH 12/12] ARM: omap2plus_defconfig: Enable some display features Tony Lindgren
2014-09-16 16:04 ` [PATCH 01/12] ARM: OMAP2+: Add hwmod flag for HWMOD_RECONFIG_IO_CHAIN Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918162312.GA1245@kahuna \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).