public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] i2c: cadence: Remove .owner field for driver
Date: Sat, 20 Sep 2014 11:11:07 +0200	[thread overview]
Message-ID: <20140920091106.GB1612@katana> (raw)
In-Reply-To: <c076984af7e65c433fdfd3a3b0f8d20da2c18013.1407931005.git.michal.simek@xilinx.com>

On Wed, Aug 13, 2014 at 01:56:51PM +0200, Michal Simek wrote:
> There is no need to init .owner field.
> 
> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> "mmc: remove .owner field for drivers using module_platform_driver"
> 
> This patch removes the superflous .owner field for drivers which

It says drivers, but does only one...

> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."

... so: any interest in doing this for the whole subsystem? Basically
good catch, though.

> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/i2c/busses/i2c-cadence.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index 63f3f03ecc9b..04d0a7e449ef 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -890,7 +890,6 @@ MODULE_DEVICE_TABLE(of, cdns_i2c_of_match);
>  static struct platform_driver cdns_i2c_drv = {
>  	.driver = {
>  		.name  = DRIVER_NAME,
> -		.owner = THIS_MODULE,
>  		.of_match_table = cdns_i2c_of_match,
>  		.pm = &cdns_i2c_dev_pm_ops,
>  	},
> --
> 1.8.2.3
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140920/ec4cb1c1/attachment.sig>

  reply	other threads:[~2014-09-20  9:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13 11:56 [PATCH 1/2] i2c: cadence: Remove .owner field for driver Michal Simek
2014-09-20  9:11 ` Wolfram Sang [this message]
2014-09-22  9:36   ` Michal Simek
2014-11-07 18:15     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140920091106.GB1612@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox