From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm64: dmi: Add SMBIOS/DMI support
Date: Mon, 22 Sep 2014 18:02:32 +0100 [thread overview]
Message-ID: <20140922170231.GM30085@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20140922100912.GG30085@e104818-lin.cambridge.arm.com>
On Mon, Sep 22, 2014 at 11:09:12AM +0100, Catalin Marinas wrote:
> On Sat, Sep 20, 2014 at 12:03:01AM +0100, Ard Biesheuvel wrote:
> > From: Yi Li <yi.li@linaro.org>
> >
> > SMBIOS is important for server hardware vendors. It implements a spec for
> > providing descriptive information about the platform. Things like serial
> > numbers, physical layout of the ports, build configuration data, and the like.
> >
> > This has been tested by dmidecode and lshw tools.
> >
> > This patch adds the call to dmi_scan_machine() to arm64_enter_virtual_mode(),
> > as that is the point where the EFI Configuration Tables are registered as
> > being available. It needs to be in an early_initcall anyway as dmi_id_init(),
> > which is an arch_initcall itself, depends on dmi_scan_machine() having been
> > called already.
> >
> > Signed-off-by: Yi Li <yi.li@linaro.org>
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Merged (until the next revert ;)). Thanks.
And I'm about to revert it now. If Linux doesn't boot as an EFI
application, with this patch applied I get lots of:
WARNING: CPU: 4 PID: 1 at
/work/Linux/linux-2.6-aarch64/drivers/firmware/dmi_scan.c:591
dmi_matches+0x10c/0x110()
dmi check: not initialized yet.
Modules linked in:
CPU: 4 PID: 1 Comm: swapper/0 Not tainted 3.17.0-rc4+ #606
Call trace:
[<ffffffc000087fb0>] dump_backtrace+0x0/0x124
[<ffffffc0000880e4>] show_stack+0x10/0x1c
[<ffffffc0004d58f8>] dump_stack+0x74/0xb8
[<ffffffc0000ab640>] warn_slowpath_common+0x8c/0xb4
[<ffffffc0000ab6b4>] warn_slowpath_fmt+0x4c/0x58
[<ffffffc0003f2d7c>] dmi_matches+0x108/0x110
[<ffffffc0003f2da8>] dmi_check_system+0x24/0x68
[<ffffffc0006974c4>] atkbd_init+0x10/0x34
[<ffffffc0000814ac>] do_one_initcall+0x88/0x1a0
[<ffffffc00067aab4>] kernel_init_freeable+0x148/0x1e8
[<ffffffc0004d2c64>] kernel_init+0x10/0xd4
--
Catalin
next prev parent reply other threads:[~2014-09-22 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 23:03 [PATCH v3] arm64: dmi: Add SMBIOS/DMI support Ard Biesheuvel
2014-09-22 10:09 ` Catalin Marinas
2014-09-22 17:02 ` Catalin Marinas [this message]
2014-09-22 19:44 ` Ard Biesheuvel
2014-09-23 8:23 ` Ard Biesheuvel
2014-09-23 21:21 ` Mark Salter
2014-09-23 21:25 ` Mark Salter
2014-09-24 5:36 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922170231.GM30085@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).