linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: fix .is_enabled() of shared gate clock
Date: Mon, 22 Sep 2014 21:49:49 -0700	[thread overview]
Message-ID: <20140923044949.GA7487@localhost> (raw)
In-Reply-To: <1410831334-7859-1-git-send-email-shawn.guo@freescale.com>

On Tue, Sep 16, 2014 at 09:35:33AM +0800, Shawn Guo wrote:
> Commit 63288b721a80 ("ARM: imx: fix shared gate clock") attempted to fix
> an issue with particular enable/disable sequence from two shared gate
> clocks.  But unfortunately, while it partially fixed the issue, it also
> did something wrong in .is_enabled() function hook.  In case of shared
> gate, the function shouldn't really query the hardware state via
> share_count, because the function is trying to query the enabling state
> of the clock in question, not the hardware state which is shared by
> multiple clocks.
> 
> Fix the issue by returning the enable_count of the clock itself which is
> maintained by clock core, in case it's a clock sharing hardware gate
> with others.  As the result, the initialization of share_count per
> hardware state is not needed now.  So remove it.
> 
> Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
> Fixes: 63288b721a80 ("ARM: imx: fix shared gate clock")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> ---
> Hi arm-soc folks,
> 
> Please apply it for 3.17.  Thanks.

Applied.


-Olof

      parent reply	other threads:[~2014-09-23  4:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16  1:35 [PATCH] ARM: imx: fix .is_enabled() of shared gate clock Shawn Guo
2014-09-16  1:43 ` Fabio Estevam
2014-09-23  4:49 ` Olof Johansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140923044949.GA7487@localhost \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).