From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Tue, 23 Sep 2014 15:36:45 +0200 [thread overview]
Message-ID: <20140923133645.GA18924@kwain> (raw)
In-Reply-To: <2909480.SL9c0XWUbW@wuerfel>
Arnd,
On Tue, Sep 23, 2014 at 12:39:04PM +0200, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 12:28:03 Antoine Tenart wrote:
> > + if (dev->of_node) {
> > + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata);
> > + if (ret)
> > + goto clk_err;
> > + } else {
> > + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> > + if (ret)
> > + goto clk_err;
> > + }
> >
>
> Why do you care about the non-DT case here? I think it would be nicer to
> open-code the ci_hdrc_usb2_dt_probe() function in here and remove
> the dma_set_mask_and_coherent(), which should not even be necessary for
> the case where you have a hardwired platform device.
>
I thought we agreed to call dma_set_mask_and_coherent():
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/273335.html
I do not have a strong opinion on this as I only use the dt case for my
usage.
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-23 13:36 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 10:27 [PATCH v6 00/12] ARM: berlin: USB support Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 01/12] reset: add the Berlin reset controller driver Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 03/12] ARM: Berlin: select the reset controller Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 05/12] phy: add the Berlin USB PHY driver Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx Antoine Tenart
2014-09-23 10:39 ` Arnd Bergmann
2014-09-23 13:36 ` Antoine Tenart [this message]
2014-09-23 16:44 ` Arnd Bergmann
2014-09-23 16:55 ` Felipe Balbi
2014-09-23 17:37 ` Arnd Bergmann
2014-09-23 17:43 ` Felipe Balbi
2014-09-24 2:27 ` Peter Chen
2014-09-24 7:44 ` Arnd Bergmann
2014-09-24 8:30 ` Arnd Bergmann
2014-09-24 11:29 ` Peter Chen
2014-09-24 12:23 ` Arnd Bergmann
2014-09-25 0:56 ` Peter Chen
2014-09-25 14:15 ` Felipe Balbi
2014-09-25 23:39 ` Peter Chen
2014-09-26 0:37 ` Felipe Balbi
2014-09-26 0:39 ` Felipe Balbi
2014-09-26 7:20 ` Arnd Bergmann
2014-09-26 15:43 ` Felipe Balbi
2014-09-28 0:40 ` Peter Chen
2014-10-13 8:47 ` Peter Chen
2014-09-25 14:09 ` Felipe Balbi
2014-09-24 23:58 ` Sören Brinkmann
2014-09-29 14:57 ` Antoine Tenart
2014-09-25 1:16 ` Peter Chen
2014-09-25 7:11 ` Arnd Bergmann
2014-09-26 0:23 ` Peter Chen
2014-09-26 7:01 ` Arnd Bergmann
2014-09-25 19:12 ` Arnd Bergmann
2014-09-25 19:54 ` Antoine Tenart
2014-09-29 15:08 ` Antoine Tenart
2014-10-01 12:39 ` Antoine Tenart
2014-09-30 0:12 ` Peter Chen
2014-09-30 10:03 ` Arnd Bergmann
2014-09-30 12:39 ` Peter Chen
2014-09-30 13:43 ` Arnd Bergmann
2014-10-01 6:35 ` Peter Chen
2014-10-01 8:41 ` Arnd Bergmann
2014-10-01 12:25 ` Peter Chen
2014-10-01 23:40 ` Peter Chen
2014-09-23 10:28 ` [PATCH v6 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923133645.GA18924@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).