linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: make arrays containing machine compatible strings const
Date: Wed, 24 Sep 2014 10:32:42 -0700	[thread overview]
Message-ID: <20140924173242.GA18667@localhost> (raw)
In-Reply-To: <20140924050104.GD24803@localhost>

On Tue, Sep 23, 2014 at 10:01:04PM -0700, Olof Johansson wrote:
> On Thu, Sep 11, 2014 at 11:19:13PM +0200, Uwe Kleine-K??nig wrote:
> > The definition
> > 
> > 	static const char *axxia_dt_match[] __initconst = {
> > 		...
> > 
> > defines a changable array of constant strings. That is you must not do:
> > 
> > 	*axxia_dt_match[0] = 'k';
> > 
> > but
> > 
> > 	axxia_dt_match[0] = "different string";
> > 
> > is fine. So the annotation __initconst is wrong and yields a compiler
> > error when other really const variables are added with __initconst.
> > 
> > As the struct machine_desc member dt_compat is declared as
> > 
> > 	const char *const *dt_compat;
> > 
> > making the arrays const is the better alternative over changing all
> > annotations to __initdata.
> > 
> > Signed-off-by: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> > 
> > this is similar to the fix I sent earlier today which only fixed omap2.
> > Does it make sense to split this patch per platform?
> 
> 
> We should be fine applying it as-is. Applied to next/cleanup.

...and dropped again. It conflicts with new platform additions. I'll
apply and fixup those towards the end of the merge window.

No action needed on your behalf, besides possibly reminding me in case
I forget about it.


-Olof

  reply	other threads:[~2014-09-24 17:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 21:19 [PATCH] ARM: make arrays containing machine compatible strings const Uwe Kleine-König
2014-09-24  5:01 ` Olof Johansson
2014-09-24 17:32   ` Olof Johansson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-02-18 20:01 Uwe Kleine-König
2015-02-18 20:38 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924173242.GA18667@localhost \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).