From: sudipm.mukherjee@gmail.com (Sudip Mukherjee)
To: linux-arm-kernel@lists.infradead.org
Subject: Legacy Code in gpmc-onenand.c
Date: Sun, 28 Sep 2014 21:44:07 +0530 [thread overview]
Message-ID: <20140928161407.GA2493@sudip-PC> (raw)
In-Reply-To: <5427744E.4040409@gmail.com>
On Sat, Sep 27, 2014 at 10:37:02PM -0400, nick wrote:
> Greetings Kevin and others,
> I am wondering if the below code is legacy I can remove it as stated it the fix me.
> Cheers Nick
> else {
> /*
> * FIX ME: Appears to be legacy code from initial ONENAND commit.
> * Unclear what boards this is for and if this can be removed.
> */
> if (!cpu_is_omap34xx())
> onenand_sync.wait_on_read = true;
> }
the FIX ME does not say that you can remove the code. It says you need to find out that the code is being used by which board. And if you want to remove it then you have to explain why the code is removed , and after removing what will be the effect , and if there is no effect then why there is no effect.
Good Luck.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2014-09-28 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 2:37 Legacy Code in gpmc-onenand.c nick
2014-09-28 2:51 ` Al Viro
2014-09-28 16:14 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928161407.GA2493@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).