* [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume
@ 2014-09-28 2:50 Nicholas Krause
2014-09-28 3:31 ` Randy Dunlap
2014-09-28 16:23 ` Sudip Mukherjee
0 siblings, 2 replies; 5+ messages in thread
From: Nicholas Krause @ 2014-09-28 2:50 UTC (permalink / raw)
To: linux-arm-kernel
This removes the FIXME message and issue with reading in this driver before resuming
in the function, sa1111_resume.
Signed-off-by: Nicholas Krause <yocto6@gmail.com>
---
arch/arm/common/sa1111.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
index e57d7e5..0c4b9a9 100644
--- a/arch/arm/common/sa1111.c
+++ b/arch/arm/common/sa1111.c
@@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
/*
* Ensure that the SA1111 is still here.
- * FIXME: shouldn't do this here.
*/
- id = sa1111_readl(sachip->base + SA1111_SKID);
if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
__sa1111_remove(sachip);
platform_set_drvdata(dev, NULL);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume
2014-09-28 2:50 [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume Nicholas Krause
@ 2014-09-28 3:31 ` Randy Dunlap
2014-09-28 4:07 ` nick
2014-09-28 16:23 ` Sudip Mukherjee
1 sibling, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2014-09-28 3:31 UTC (permalink / raw)
To: linux-arm-kernel
On 09/27/14 19:50, Nicholas Krause wrote:
> This removes the FIXME message and issue with reading in this driver before resuming
> in the function, sa1111_resume.
You need to explain why this makes any sense.
Hint: it doesn't.
> Signed-off-by: Nicholas Krause <yocto6@gmail.com>
> ---
> arch/arm/common/sa1111.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
> index e57d7e5..0c4b9a9 100644
> --- a/arch/arm/common/sa1111.c
> +++ b/arch/arm/common/sa1111.c
> @@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
>
> /*
> * Ensure that the SA1111 is still here.
> - * FIXME: shouldn't do this here.
> */
> - id = sa1111_readl(sachip->base + SA1111_SKID);
> if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
> __sa1111_remove(sachip);
> platform_set_drvdata(dev, NULL);
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume
2014-09-28 3:31 ` Randy Dunlap
@ 2014-09-28 4:07 ` nick
0 siblings, 0 replies; 5+ messages in thread
From: nick @ 2014-09-28 4:07 UTC (permalink / raw)
To: linux-arm-kernel
On 14-09-27 11:31 PM, Randy Dunlap wrote:
> On 09/27/14 19:50, Nicholas Krause wrote:
>> This removes the FIXME message and issue with reading in this driver before resuming
>> in the function, sa1111_resume.
>
> You need to explain why this makes any sense.
> Hint: it doesn't.
>
>> Signed-off-by: Nicholas Krause <yocto6@gmail.com>
>> ---
>> arch/arm/common/sa1111.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
>> index e57d7e5..0c4b9a9 100644
>> --- a/arch/arm/common/sa1111.c
>> +++ b/arch/arm/common/sa1111.c
>> @@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
>>
>> /*
>> * Ensure that the SA1111 is still here.
>> - * FIXME: shouldn't do this here.
>> */
>> - id = sa1111_readl(sachip->base + SA1111_SKID);
>> if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
>> __sa1111_remove(sachip);
>> platform_set_drvdata(dev, NULL);
>>
>
>
Thanks for the reply Randy. I was wondering if was what the FIX ME meant if it meant something else please let me
known.
Sorry,
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume
2014-09-28 2:50 [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume Nicholas Krause
2014-09-28 3:31 ` Randy Dunlap
@ 2014-09-28 16:23 ` Sudip Mukherjee
2014-09-28 20:45 ` nick
1 sibling, 1 reply; 5+ messages in thread
From: Sudip Mukherjee @ 2014-09-28 16:23 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Sep 27, 2014 at 10:50:52PM -0400, Nicholas Krause wrote:
> This removes the FIXME message and issue with reading in this driver before resuming
> in the function, sa1111_resume.
>
> Signed-off-by: Nicholas Krause <yocto6@gmail.com>
> ---
> arch/arm/common/sa1111.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
> index e57d7e5..0c4b9a9 100644
> --- a/arch/arm/common/sa1111.c
> +++ b/arch/arm/common/sa1111.c
> @@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
>
> /*
> * Ensure that the SA1111 is still here.
> - * FIXME: shouldn't do this here.
> */
> - id = sa1111_readl(sachip->base + SA1111_SKID);
do you understand the effect of removing this???
what is the value of id in the next part of the code?
thanks
sudip
> if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
> __sa1111_remove(sachip);
> platform_set_drvdata(dev, NULL);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume
2014-09-28 16:23 ` Sudip Mukherjee
@ 2014-09-28 20:45 ` nick
0 siblings, 0 replies; 5+ messages in thread
From: nick @ 2014-09-28 20:45 UTC (permalink / raw)
To: linux-arm-kernel
On 14-09-28 12:23 PM, Sudip Mukherjee wrote:
> On Sat, Sep 27, 2014 at 10:50:52PM -0400, Nicholas Krause wrote:
>> This removes the FIXME message and issue with reading in this driver before resuming
>> in the function, sa1111_resume.
>>
>> Signed-off-by: Nicholas Krause <yocto6@gmail.com>
>> ---
>> arch/arm/common/sa1111.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
>> index e57d7e5..0c4b9a9 100644
>> --- a/arch/arm/common/sa1111.c
>> +++ b/arch/arm/common/sa1111.c
>> @@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
>>
>> /*
>> * Ensure that the SA1111 is still here.
>> - * FIXME: shouldn't do this here.
>> */
>> - id = sa1111_readl(sachip->base + SA1111_SKID);
>
> do you understand the effect of removing this???
> what is the value of id in the next part of the code?
>
> thanks
> sudip
>> if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
>> __sa1111_remove(sachip);
>> platform_set_drvdata(dev, NULL);
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
We will set the driver data to NULL and therefore may cause a bug due to NULL data.
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-28 20:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-28 2:50 [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume Nicholas Krause
2014-09-28 3:31 ` Randy Dunlap
2014-09-28 4:07 ` nick
2014-09-28 16:23 ` Sudip Mukherjee
2014-09-28 20:45 ` nick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).