From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: kvm: fix CPU hotplug
Date: Mon, 29 Sep 2014 16:03:09 +0200 [thread overview]
Message-ID: <20140929140309.GJ3095@cbox> (raw)
In-Reply-To: <1411397568-4738-1-git-send-email-vladimir.murzin@arm.com>
On Mon, Sep 22, 2014 at 03:52:48PM +0100, Vladimir Murzin wrote:
> On some platforms with no power management capabilities, the hotplug
> implementation is allowed to return from a smp_ops.cpu_die() call as a
> function return. Upon a CPU onlining event, the KVM CPU notifier tries
> to reinstall the hyp stub, which fails on platform where no reset took
> place following a hotplug event, with the message:
>
> CPU1: smp_ops.cpu_die() returned, trying to resuscitate
> CPU1: Booted secondary processor
> Kernel panic - not syncing: unexpected prefetch abort in Hyp mode at: 0x80409540
> unexpected data abort in Hyp mode at: 0x80401fe8
> unexpected HVC/SVC trap in Hyp mode at: 0x805c6170
>
> since KVM code is trying to reinstall the stub on a system where it is
> already configured.
>
> To prevent this issue, this patch adds a check in the KVM hotplug
> notifier that detects if the HYP stub really needs re-installing when a
> CPU is onlined and skips the installation call if the stub is already in
> place, which means that the CPU has not been reset.
>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Applied to queue, thanks
-Christoffer
prev parent reply other threads:[~2014-09-29 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 14:52 [PATCH] arm: kvm: fix CPU hotplug Vladimir Murzin
2014-09-29 14:03 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929140309.GJ3095@cbox \
--to=christoffer.dall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).