linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] ARM: move #include <asm/cp15.h> into cacheflush.h
Date: Tue, 30 Sep 2014 11:03:55 +0100	[thread overview]
Message-ID: <20140930100355.GM5182@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.11.1409300016060.5311@knanqh.ubzr>

On Tue, Sep 30, 2014 at 12:30:06AM -0400, Nicolas Pitre wrote:
> On Mon, 29 Sep 2014, Brian Norris wrote:
> 
> > There are several places where an explicit include of <asm/cp15.h> is needed
> > just because cacheflush.h uses one of its macros in v7_exit_coherency_flush().
> > Let's put the include in the proper header.
> > 
> > These obviously have some dependencies, so I'd focus on:
> >   (1) Is patch 1 acceptable? If so, then:
> 
> Well, I'm wondering if it is really a gain to force a dependency for 
> cp15.h on every user of cacheflush.h just because of the seldomly used 
> v7_exit_coherency_flush(). But I don't mind either ways.

I don't like unnecessary dependencies.  We have too many of them already,
and it basically means that touching any header file triggers a full
kernel rebuild.

If we go down the path of adding unnecessary dependencies, we might as
well do away with make and just script the damn thing, and that'll
probably be faster since there'll be no dependencies to track.  Just
throw everything through ccache and let it deal with anything which
has changed.  Just don't allow your disk to fill up during the build,
ccache really doesn't like that.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

      reply	other threads:[~2014-09-30 10:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30  1:35 [PATCH 0/5] ARM: move #include <asm/cp15.h> into cacheflush.h Brian Norris
2014-09-30  1:35 ` [PATCH 1/5] ARM: include missing cp15.h header Brian Norris
2014-09-30  1:35 ` [PATCH 2/5] ARM: mvebu: drop unnecessary include Brian Norris
2014-09-30  1:35 ` [PATCH 3/5] ARM: rockchip: " Brian Norris
2014-09-30  1:35 ` [PATCH 4/5] ARM: vexpress: " Brian Norris
2014-09-30  1:35 ` [PATCH 5/5] ARM: brcmstb: " Brian Norris
2014-09-30  4:30 ` [PATCH 0/5] ARM: move #include <asm/cp15.h> into cacheflush.h Nicolas Pitre
2014-09-30 10:03   ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140930100355.GM5182@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).