linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nicoleotsuka@gmail.com (Nicolin Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: fsl: fix dependencies for wm8962
Date: Tue, 30 Sep 2014 12:43:44 -0700	[thread overview]
Message-ID: <20140930194340.GA13318@Alpha> (raw)
In-Reply-To: <CAOMZO5B3LztUdafDCo8bzLwbmeBB3N-rpQLxXMvb0pXgtGVugA@mail.gmail.com>

On Tue, Sep 30, 2014 at 02:38:49PM -0300, Fabio Estevam wrote:
> On Tue, Sep 30, 2014 at 1:45 PM, Mark Brown <broonie@kernel.org> wrote:
> > That select shouldn't be there in the first place, I asked Nicolin to
> > fix this when I applied the driver but he's not got round to it yet.
> 
> Would the below change be a proper fix?
> 
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 6164e78..081e406 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig

> -       select SND_SOC_CS42XX8_I2C
> -       select SND_SOC_SGTL5000
> -       select SND_SOC_WM8962

Okay..if Mark means this...I think it makes sense to me now.

But in this case, we shall add them into imx_v6_v7_defconfig instead.

Thank you
Nicolin

  reply	other threads:[~2014-09-30 19:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 11:43 [PATCH] ASoC: fsl: fix dependencies for wm8962 Arnd Bergmann
2014-09-30 16:45 ` Mark Brown
2014-09-30 17:38   ` Fabio Estevam
2014-09-30 19:43     ` Nicolin Chen [this message]
2014-09-30 19:48       ` Fabio Estevam
2014-09-30 20:37         ` Nicolin Chen
2014-09-30 17:42   ` Nicolin Chen
2014-09-30 23:09     ` Mark Brown
2014-09-30 23:26       ` Nicolin Chen
2014-10-01 12:22         ` Mark Brown
2014-10-01 17:51           ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140930194340.GA13318@Alpha \
    --to=nicoleotsuka@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).