From: nicoleotsuka@gmail.com (Nicolin Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: fsl: fix dependencies for wm8962
Date: Tue, 30 Sep 2014 16:26:18 -0700 [thread overview]
Message-ID: <20140930232617.GA1732@Asurada> (raw)
In-Reply-To: <20140930230906.GQ4273@sirena.org.uk>
On Wed, Oct 01, 2014 at 12:09:06AM +0100, Mark Brown wrote:
> On Tue, Sep 30, 2014 at 10:42:42AM -0700, Nicolin Chen wrote:
> > On Tue, Sep 30, 2014 at 05:45:10PM +0100, Mark Brown wrote:
>
> > > That select shouldn't be there in the first place, I asked Nicolin to
> > > fix this when I applied the driver but he's not got round to it yet.
>
> > I think I might have missed something around those days, even though
> > the 'Applied' mail seemly doesn't have any comment against this part:
> > http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080083.html
>
> > Is that possible for you to copy and paste the comments again?
>
> I suspect it was on an earlier version of the patch or a cover letter;
> IIRC you were resending while I was reviewing.
I checked the Archive, the patch only got one version without cover
letter. And this version only got one reply which is the Applied mail.
I guess your earlier reply might have been swallowed somehow so I
couldn't read it.
Anyway, it's my fault that I didn't pay attention to the Kconfig part.
The driver is initially designed for imx-cs42888, but I changed my mind
to merge it with others before I sent it. And I didn't rewrite the part
inside the Kconfig. Will be careful next time.
And I think Fabio's suggestion/patch has no problem right?
Thank you
Nicolin
next prev parent reply other threads:[~2014-09-30 23:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 11:43 [PATCH] ASoC: fsl: fix dependencies for wm8962 Arnd Bergmann
2014-09-30 16:45 ` Mark Brown
2014-09-30 17:38 ` Fabio Estevam
2014-09-30 19:43 ` Nicolin Chen
2014-09-30 19:48 ` Fabio Estevam
2014-09-30 20:37 ` Nicolin Chen
2014-09-30 17:42 ` Nicolin Chen
2014-09-30 23:09 ` Mark Brown
2014-09-30 23:26 ` Nicolin Chen [this message]
2014-10-01 12:22 ` Mark Brown
2014-10-01 17:51 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930232617.GA1732@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).