linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: carlo@caione.org (Carlo Caione)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: meson: add meson8 machine definition
Date: Thu, 2 Oct 2014 20:29:57 +0200	[thread overview]
Message-ID: <20141002182957.GA15355@nuc> (raw)
In-Reply-To: <20141002170519.GA29052@gmail.com>

On gio, ott 02, 2014 at 07:05:19 +0200, Beniamino Galvani wrote:
> On Thu, Oct 02, 2014 at 11:24:54AM +0200, Arnd Bergmann wrote:
> > On Wednesday 01 October 2014 23:29:41 Beniamino Galvani wrote:
> > > 
> > > +static const char * const m8_common_board_compat[] = {
> > > +       "amlogic,meson8",
> > > +       NULL,
> > > +};
> > > +
> > >  DT_MACHINE_START(AML8726_MX, "Amlogic Meson6 platform")
> > >         .dt_compat      = m6_common_board_compat,
> > >  MACHINE_END
> > >  
> > > +DT_MACHINE_START(MESON8, "Amlogic Meson8 platform")
> > > +       .dt_compat      = m8_common_board_compat,
> > > +MACHINE_END
> > > 
> > 
> > I'd just add the meson8 string to the m6_common_board_compat list and
> > rename it.
> 
> From what I've seen so far the two families are very similar and share
> most of the IP cores, so a unique DT machine is a good idea.
> 
> Does the MACH_MESON8 Kconfig symbol still make sense or can I drop it
> and rename MACH_MESON6 to MACH_MESON?

I would still leave two different MACH_ for meson6 and meson8 since the
two architectures aren't _so_ similar.

thanks,

-- 
Carlo Caione

  reply	other threads:[~2014-10-02 18:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 21:29 [PATCH 0/6] ARM: add machine and dts files for Amlogic Meson8 Beniamino Galvani
2014-10-01 21:29 ` [PATCH 1/6] ARM: meson: add meson8 machine definition Beniamino Galvani
2014-10-02  9:24   ` Arnd Bergmann
2014-10-02 17:05     ` Beniamino Galvani
2014-10-02 18:29       ` Carlo Caione [this message]
2014-10-02  9:28   ` Arnd Bergmann
2014-10-02 17:08     ` Beniamino Galvani
2014-10-01 21:29 ` [PATCH 2/6] ARM: dts: add dtsi for Amlogic Meson8 SoCs Beniamino Galvani
2014-10-01 21:29 ` [PATCH 3/6] ARM: dts: add dts for Tronsmart S89 Elite TV box Beniamino Galvani
2014-10-01 21:29 ` [PATCH 4/6] of: add vendor prefix for Tronsmart Beniamino Galvani
2014-10-01 21:29 ` [PATCH 5/6] ARM: document Tronsmart compatible properties Beniamino Galvani
2014-10-01 21:29 ` [PATCH 6/6] ARM: meson: document meson8 " Beniamino Galvani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141002182957.GA15355@nuc \
    --to=carlo@caione.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).