* [PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module
@ 2014-10-03 9:01 Torsten Fleischer
2014-10-04 2:48 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Torsten Fleischer @ 2014-10-03 9:01 UTC (permalink / raw)
To: linux-arm-kernel
The call of 'kfree(ci->hw_bank.regmap)' in ci_hdrc_remove() sometimes causes
a kernel oops when removing the ci_hdrc module.
Since there is no separate memory allocated for the ci->hw_bank.regmap array,
there is no need to free it.
Signed-off-by: Torsten Fleischer <to-fleischer@t-online.de>
---
drivers/usb/chipidea/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 619d13e..4ecb650 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -732,7 +732,6 @@ static int ci_hdrc_remove(struct platform_device *pdev)
ci_role_destroy(ci);
ci_hdrc_enter_lpm(ci, true);
usb_phy_shutdown(ci->transceiver);
- kfree(ci->hw_bank.regmap);
return 0;
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module
2014-10-03 9:01 [PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module Torsten Fleischer
@ 2014-10-04 2:48 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2014-10-04 2:48 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 03, 2014 at 11:01:20AM +0200, Torsten Fleischer wrote:
> The call of 'kfree(ci->hw_bank.regmap)' in ci_hdrc_remove() sometimes causes
> a kernel oops when removing the ci_hdrc module.
>
> Since there is no separate memory allocated for the ci->hw_bank.regmap array,
> there is no need to free it.
>
> Signed-off-by: Torsten Fleischer <to-fleischer@t-online.de>
> ---
> drivers/usb/chipidea/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 619d13e..4ecb650 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -732,7 +732,6 @@ static int ci_hdrc_remove(struct platform_device *pdev)
> ci_role_destroy(ci);
> ci_hdrc_enter_lpm(ci, true);
> usb_phy_shutdown(ci->transceiver);
> - kfree(ci->hw_bank.regmap);
>
> return 0;
> }
> --
> 1.8.4.5
>
Good fix, applied, thanks.
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-04 2:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-03 9:01 [PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module Torsten Fleischer
2014-10-04 2:48 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).