From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: sun7i: cubieboard2: Enable the AXP209
Date: Mon, 6 Oct 2014 15:25:46 +0200 [thread overview]
Message-ID: <20141006132546.GJ4090@lukather> (raw)
In-Reply-To: <CAGb2v65goZ6nf2Bk3m4oZWHv98+F=ZZSEcKx+9ni-JRgMCqokw@mail.gmail.com>
On Mon, Oct 06, 2014 at 08:16:47PM +0800, Chen-Yu Tsai wrote:
> BTW,
>
> On Mon, Oct 6, 2014 at 8:07 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Fri, Oct 03, 2014 at 04:49:25PM +0800, Chen-Yu Tsai wrote:
> >> Hi,
> >>
> >> On Sun, Sep 21, 2014 at 4:06 AM, Maxime Ripard
> >> <maxime.ripard@free-electrons.com> wrote:
> >> > Add the AXP209 PMIC with the regulators in use on the cubie2.
> >> >
> >> > The RTC regulator can be disabled, but since the RTC driver doesn't grab the
> >> > regulator for now, the driver wouldn't work anymore.
>
> This is wrong. The RTC regulator, i.e. LDO1, can not be disabled.
> From the datasheet: "LDO1?30mA?????", or "Always effective/enabled".
> And it is defined in the driver without enabling controls.
Yeah, I know, it was supposed to be fixed too.
I ended up dropping this patch, and will resubmit it.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141006/d27736fb/attachment.sig>
prev parent reply other threads:[~2014-10-06 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 20:06 [PATCH 0/3] sunxi: Add AXP209 regulator support Maxime Ripard
2014-09-20 20:06 ` [PATCH 1/3] regulator: axp20x: Use parent device as regulator configuration device Maxime Ripard
2014-09-23 1:18 ` Mark Brown
2014-09-20 20:06 ` [PATCH 2/3] mfd: axp209x: Drop the parent supplies field Maxime Ripard
2014-09-24 6:32 ` Maxime Ripard
2014-09-24 7:03 ` Lee Jones
2014-09-20 20:06 ` [PATCH 3/3] ARM: sun7i: cubieboard2: Enable the AXP209 Maxime Ripard
2014-09-25 10:05 ` Maxime Ripard
2014-10-03 8:49 ` Chen-Yu Tsai
2014-10-06 12:07 ` Maxime Ripard
2014-10-06 12:16 ` Chen-Yu Tsai
2014-10-06 13:25 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006132546.GJ4090@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox